Re: [PATCH 3/8] staging: wfx: standardize the error when vif does not exist

2020-10-10 Thread Jérôme Pouiller
On Saturday 10 October 2020 14:40:34 CEST Greg Kroah-Hartman wrote: > On Sat, Oct 10, 2020 at 02:22:13PM +0200, Jérôme Pouiller wrote: > > On Friday 9 October 2020 20:52:47 CEST Kalle Valo wrote: > > > Jerome Pouiller writes: > > > > > > > From: Jérôme Pouiller > > > > > > > > Smatch complains:

Re: [PATCH 3/8] staging: wfx: standardize the error when vif does not exist

2020-10-10 Thread Jérôme Pouiller
On Friday 9 October 2020 20:52:47 CEST Kalle Valo wrote: > Jerome Pouiller writes: > > > From: Jérôme Pouiller > > > > Smatch complains: > > > >drivers/staging/wfx/hif_rx.c:177 hif_scan_complete_indication() warn: > > potential NULL parameter dereference 'wvif' > >

Re: [PATCH 3/8] staging: wfx: standardize the error when vif does not exist

2020-10-10 Thread Greg Kroah-Hartman
On Sat, Oct 10, 2020 at 02:22:13PM +0200, Jérôme Pouiller wrote: > On Friday 9 October 2020 20:52:47 CEST Kalle Valo wrote: > > Jerome Pouiller writes: > > > > > From: Jérôme Pouiller > > > > > > Smatch complains: > > > > > >drivers/staging/wfx/hif_rx.c:177 hif_scan_complete_indication()

Re: [PATCH 3/8] staging: wfx: standardize the error when vif does not exist

2020-10-09 Thread Kalle Valo
Jerome Pouiller writes: > From: Jérôme Pouiller > > Smatch complains: > >drivers/staging/wfx/hif_rx.c:177 hif_scan_complete_indication() warn: > potential NULL parameter dereference 'wvif' >drivers/staging/wfx/data_tx.c:576 wfx_flush() warn: potential NULL > parameter dereference

[PATCH 3/8] staging: wfx: standardize the error when vif does not exist

2020-10-09 Thread Jerome Pouiller
From: Jérôme Pouiller Smatch complains: drivers/staging/wfx/hif_rx.c:177 hif_scan_complete_indication() warn: potential NULL parameter dereference 'wvif' drivers/staging/wfx/data_tx.c:576 wfx_flush() warn: potential NULL parameter dereference 'wvif' Indeed, if the vif id returned by