Re: [PATCH 3.16 00/99] 3.16.84-rc1 review
On Thu, 2020-05-21 at 15:37 -0700, Guenter Roeck wrote: > On 5/21/20 1:20 PM, Ben Hutchings wrote: > > On Wed, 2020-05-20 at 14:23 -0700, Guenter Roeck wrote: > > > On 5/20/20 7:13 AM, Ben Hutchings wrote: > > > > This is the start of the stable review cycle for the 3.16.84 release. > > > > There are 99 patches in this series, which will be posted as responses > > > > to this one. If anyone has any issues with these being applied, please > > > > let me know. > > > > > > > > Responses should be made by Fri May 22 20:00:00 UTC 2020. > > > > Anything received after that time might be too late. > > > > > > > Build results: > > > total: 135 pass: 135 fail: 0 > > > Qemu test results: > > > total: 230 pass: 227 fail: 3 > > > Failed tests: > > > arm:cubieboard:multi_v7_defconfig:mem512:sun4i-a10-cubieboard:initrd > > > arm:cubieboard:multi_v7_defconfig:usb:mem512:sun4i-a10-cubieboard:rootfs > > > > > > arm:cubieboard:multi_v7_defconfig:sata:mem512:sun4i-a10-cubieboard:rootfs > > > > > > The arm tests fail due to a compile error. > > > > > > drivers/clk/tegra/clk-tegra-periph.c:524:65: error: 'CLK_IS_CRITICAL' > > > undeclared here (not in a function); did you mean 'CLK_IS_BASIC'? > > > > I already looked at your first test results and dropped the patch that > > uses CLK_IS_CRITICAL, so there's something else going wrong there... > > > > Ah yes. Sorry, I didn't notice that there was a rebuild. > > Images are fine; the three failing tests should not have been > tested in the first place (they never did, but I didn't update > the blacklist when I increased the qemu memory size to 512MB). OK, thanks for checking. Ben. -- Ben Hutchings Logic doesn't apply to the real world. - Marvin Minsky signature.asc Description: This is a digitally signed message part
Re: [PATCH 3.16 00/99] 3.16.84-rc1 review
On 5/21/20 1:20 PM, Ben Hutchings wrote: > On Wed, 2020-05-20 at 14:23 -0700, Guenter Roeck wrote: >> On 5/20/20 7:13 AM, Ben Hutchings wrote: >>> This is the start of the stable review cycle for the 3.16.84 release. >>> There are 99 patches in this series, which will be posted as responses >>> to this one. If anyone has any issues with these being applied, please >>> let me know. >>> >>> Responses should be made by Fri May 22 20:00:00 UTC 2020. >>> Anything received after that time might be too late. >>> >> Build results: >> total: 135 pass: 135 fail: 0 >> Qemu test results: >> total: 230 pass: 227 fail: 3 >> Failed tests: >> arm:cubieboard:multi_v7_defconfig:mem512:sun4i-a10-cubieboard:initrd >> arm:cubieboard:multi_v7_defconfig:usb:mem512:sun4i-a10-cubieboard:rootfs >> >> arm:cubieboard:multi_v7_defconfig:sata:mem512:sun4i-a10-cubieboard:rootfs >> >> The arm tests fail due to a compile error. >> >> drivers/clk/tegra/clk-tegra-periph.c:524:65: error: 'CLK_IS_CRITICAL' >> undeclared here (not in a function); did you mean 'CLK_IS_BASIC'? > > I already looked at your first test results and dropped the patch that > uses CLK_IS_CRITICAL, so there's something else going wrong there... > Ah yes. Sorry, I didn't notice that there was a rebuild. Images are fine; the three failing tests should not have been tested in the first place (they never did, but I didn't update the blacklist when I increased the qemu memory size to 512MB). Guenter signature.asc Description: OpenPGP digital signature
Re: [PATCH 3.16 00/99] 3.16.84-rc1 review
On Thu, 2020-05-21 at 00:40 -0700, Guenter Roeck wrote:
> On 5/20/20 7:47 PM, Chen-Yu Tsai wrote:
> > On Thu, May 21, 2020 at 5:23 AM Guenter Roeck wrote:
> > > On 5/20/20 7:13 AM, Ben Hutchings wrote:
> > > > This is the start of the stable review cycle for the 3.16.84 release.
> > > > There are 99 patches in this series, which will be posted as responses
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Fri May 22 20:00:00 UTC 2020.
> > > > Anything received after that time might be too late.
> > > >
> > > Build results:
> > > total: 135 pass: 135 fail: 0
> > > Qemu test results:
> > > total: 230 pass: 227 fail: 3
> > > Failed tests:
> > >
> > > arm:cubieboard:multi_v7_defconfig:mem512:sun4i-a10-cubieboard:initrd
> > >
> > > arm:cubieboard:multi_v7_defconfig:usb:mem512:sun4i-a10-cubieboard:rootfs
> > >
> > > arm:cubieboard:multi_v7_defconfig:sata:mem512:sun4i-a10-cubieboard:rootfs
> > >
> > > The arm tests fail due to a compile error.
> > >
> > > drivers/clk/tegra/clk-tegra-periph.c:524:65: error: 'CLK_IS_CRITICAL'
> > > undeclared here (not in a function); did you mean 'CLK_IS_BASIC'?
> >
> > This looks like a result of having
> >
> > clk: tegra: Mark fuse clock as critical
> > [bf83b96f87ae2abb1e535306ea53608e8de5dfbb]
> >
> > In which case you probably need to add
> >
> > 32b9b1096186 clk: Allow clocks to be marked as CRITICAL
> >
>
> Then you might also need commit ef56b79b66f ("clk: fix critical
> clock locking") which fixes it.
At this stage I don't think it makes sense to add the feature to 3.16.
Ben.
--
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.
signature.asc
Description: This is a digitally signed message part
Re: [PATCH 3.16 00/99] 3.16.84-rc1 review
On Wed, 2020-05-20 at 14:23 -0700, Guenter Roeck wrote: > On 5/20/20 7:13 AM, Ben Hutchings wrote: > > This is the start of the stable review cycle for the 3.16.84 release. > > There are 99 patches in this series, which will be posted as responses > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Fri May 22 20:00:00 UTC 2020. > > Anything received after that time might be too late. > > > Build results: > total: 135 pass: 135 fail: 0 > Qemu test results: > total: 230 pass: 227 fail: 3 > Failed tests: > arm:cubieboard:multi_v7_defconfig:mem512:sun4i-a10-cubieboard:initrd > arm:cubieboard:multi_v7_defconfig:usb:mem512:sun4i-a10-cubieboard:rootfs > > arm:cubieboard:multi_v7_defconfig:sata:mem512:sun4i-a10-cubieboard:rootfs > > The arm tests fail due to a compile error. > > drivers/clk/tegra/clk-tegra-periph.c:524:65: error: 'CLK_IS_CRITICAL' > undeclared here (not in a function); did you mean 'CLK_IS_BASIC'? I already looked at your first test results and dropped the patch that uses CLK_IS_CRITICAL, so there's something else going wrong there... Ben. -- Ben Hutchings Reality is just a crutch for people who can't handle science fiction. signature.asc Description: This is a digitally signed message part
Re: [PATCH 3.16 00/99] 3.16.84-rc1 review
On 5/20/20 7:47 PM, Chen-Yu Tsai wrote:
> On Thu, May 21, 2020 at 5:23 AM Guenter Roeck wrote:
>>
>> On 5/20/20 7:13 AM, Ben Hutchings wrote:
>>> This is the start of the stable review cycle for the 3.16.84 release.
>>> There are 99 patches in this series, which will be posted as responses
>>> to this one. If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Fri May 22 20:00:00 UTC 2020.
>>> Anything received after that time might be too late.
>>>
>> Build results:
>> total: 135 pass: 135 fail: 0
>> Qemu test results:
>> total: 230 pass: 227 fail: 3
>> Failed tests:
>> arm:cubieboard:multi_v7_defconfig:mem512:sun4i-a10-cubieboard:initrd
>>
>> arm:cubieboard:multi_v7_defconfig:usb:mem512:sun4i-a10-cubieboard:rootfs
>>
>> arm:cubieboard:multi_v7_defconfig:sata:mem512:sun4i-a10-cubieboard:rootfs
>>
>> The arm tests fail due to a compile error.
>>
>> drivers/clk/tegra/clk-tegra-periph.c:524:65: error: 'CLK_IS_CRITICAL'
>> undeclared here (not in a function); did you mean 'CLK_IS_BASIC'?
>
> This looks like a result of having
>
> clk: tegra: Mark fuse clock as critical
> [bf83b96f87ae2abb1e535306ea53608e8de5dfbb]
>
> In which case you probably need to add
>
> 32b9b1096186 clk: Allow clocks to be marked as CRITICAL
>
Then you might also need commit ef56b79b66f ("clk: fix critical
clock locking") which fixes it.
Guenter
Re: [PATCH 3.16 00/99] 3.16.84-rc1 review
On Thu, May 21, 2020 at 5:23 AM Guenter Roeck wrote: > > On 5/20/20 7:13 AM, Ben Hutchings wrote: > > This is the start of the stable review cycle for the 3.16.84 release. > > There are 99 patches in this series, which will be posted as responses > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Fri May 22 20:00:00 UTC 2020. > > Anything received after that time might be too late. > > > Build results: > total: 135 pass: 135 fail: 0 > Qemu test results: > total: 230 pass: 227 fail: 3 > Failed tests: > arm:cubieboard:multi_v7_defconfig:mem512:sun4i-a10-cubieboard:initrd > > arm:cubieboard:multi_v7_defconfig:usb:mem512:sun4i-a10-cubieboard:rootfs > > arm:cubieboard:multi_v7_defconfig:sata:mem512:sun4i-a10-cubieboard:rootfs > > The arm tests fail due to a compile error. > > drivers/clk/tegra/clk-tegra-periph.c:524:65: error: 'CLK_IS_CRITICAL' > undeclared here (not in a function); did you mean 'CLK_IS_BASIC'? This looks like a result of having clk: tegra: Mark fuse clock as critical [bf83b96f87ae2abb1e535306ea53608e8de5dfbb] In which case you probably need to add 32b9b1096186 clk: Allow clocks to be marked as CRITICAL to the pile. ChenYu
Re: [PATCH 3.16 00/99] 3.16.84-rc1 review
On 5/20/20 7:13 AM, Ben Hutchings wrote: > This is the start of the stable review cycle for the 3.16.84 release. > There are 99 patches in this series, which will be posted as responses > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Fri May 22 20:00:00 UTC 2020. > Anything received after that time might be too late. > Build results: total: 135 pass: 135 fail: 0 Qemu test results: total: 230 pass: 227 fail: 3 Failed tests: arm:cubieboard:multi_v7_defconfig:mem512:sun4i-a10-cubieboard:initrd arm:cubieboard:multi_v7_defconfig:usb:mem512:sun4i-a10-cubieboard:rootfs arm:cubieboard:multi_v7_defconfig:sata:mem512:sun4i-a10-cubieboard:rootfs The arm tests fail due to a compile error. drivers/clk/tegra/clk-tegra-periph.c:524:65: error: 'CLK_IS_CRITICAL' undeclared here (not in a function); did you mean 'CLK_IS_BASIC'? Guenter
[PATCH 3.16 00/99] 3.16.84-rc1 review
This is the start of the stable review cycle for the 3.16.84 release. There are 99 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Fri May 22 20:00:00 UTC 2020. Anything received after that time might be too late. All the patches have also been committed to the linux-3.16.y-rc branch of https://git.kernel.org/pub/scm/linux/kernel/git/bwh/linux-stable-rc.git . A shortlog and diffstat can be found below. Ben. - Al Viro (1): propagate_one(): mnt_set_mountpoint() needs mount_lock [b0d3869ce9eeacbb1bbd541909beeef4126426d5] Alexandre Belloni (2): ARM: dts: at91: sama5d3: define clock rate range for tcb1 [a7e0f3fc01df4b1b7077df777c37feae8c9e8b6d] ARM: dts: at91: sama5d3: fix maximum peripheral clock rates [ee0aa926ddb0bd8ba59e33e3803b3b5804e3f5da] Ard Biesheuvel (1): efi/x86: Map the entire EFI vendor string before copying it [ffc2760bcf2dba0dbef74013ed73eea8310cc52c] Arnd Bergmann (2): sparc32: fix struct ipc64_perm type definition [34ca70ef7d3a9fa7e89151597db5e37ae1d429b4] x86: kvm: avoid unused variable warning [7288bde1f9df6c1475675419bdd7725ce84dec56] Bin Liu (1): usb: dwc3: turn off VBUS when leaving host mode [09ed259fac621634d51cd986aa8d65f035662658] Bryan O'Donoghue (2): usb: gadget: f_ecm: Use atomic_t to track in-flight request [d710562e01c48d59be3f60d58b7a85958b39aeda] usb: gadget: f_ncm: Use atomic_t to track in-flight request [5b24c28cfe136597dc3913e1c00b119307a20c7e] Chen Yucong (1): kvm: x86: use macros to compute bank MSRs [81760dccf8d1fe5b128b58736fe3f56a566133cb] Christoffer Dall (1): KVM: arm64: Only sign-extend MMIO up to register width [b6ae256afd32f96bec0117175b329d0dd617655e] Christophe JAILLET (1): pxa168fb: Fix the function used to release some memory in an error handling path [3c911fe799d1c338d94b78e7182ad452c37af897] Chuhong Yuan (1): crypto: picoxcell - adjust the position of tasklet_init and fix missed tasklet_kill [7f8c36fe9be46862c4f3c5302f769378028a34fa] Colin Ian King (2): iwlegacy: ensure loop counter addr does not wrap and cause an infinite loop [c2f9a4e4a5abfc84c01b738496b3fd2d471e0b18] staging: wlan-ng: ensure error return is actually returned [4cc41cbce536876678b35e03c4a8a7bb72c78fa9] Dan Carpenter (3): brcmfmac: Fix use after free in brcmf_sdio_readframes() [216b44000ada87a63891a8214c347e05a4aea8fe] mm/mempolicy.c: fix out of bounds write in mpol_parse_str() [c7a91bc7c2e17e0a9c8b9745a2cb118891218fd1] power: supply: sbs-battery: Fix a signedness bug in sbs_get_battery_capacity() [eb368de6de32925c65a97c1e929a31cae2155aee] Daniel Jordan (3): padata: always acquire cpu_hotplug_lock before pinst->lock [38228e8848cd7dd86ccb90406af32de0cad24be3] padata: initialize pd->cpu with effective cpumask [ec9c7d19336ee98ecba8de80128aa405c45feebb] padata: purge get_cpu and reorder_via_wq from padata_do_serial [065cf577135a4977931c7a1e1edf442bfd9773dd] Daniel Kiper (1): efi: Use early_mem*() instead of early_io*() [abc93f8eb6e46a480485f19256bdbda36ec78a84] Eric Dumazet (4): bonding/alb: properly access headers in bond_alb_xmit() [38f88c45404293bbc027b956def6c10cbd45c616] cls_rsvp: fix rsvp_policy [cb3c0e6bdf64d0d124e94ce43cbe4ccbb9b37f51] net_sched: ematch: reject invalid TCF_EM_SIMPLE [55cd9f67f1e45de8517cdaab985fb8e56c0bc1d8] tcp: clear tp->total_retrans in tcp_disconnect() [c13c48c00a6bc1febc73902505bdec0967bd7095] Fabian Frederick (1): nfs: use kmap/kunmap directly [0795bf8357c1887e2a95e6e4f5b89d0896a0d929] Filipe Manana (1): Btrfs: fix race between adding and putting tree mod seq elements and nodes [7227ff4de55d931bbdc156c8ef0ce4f100c78a5b] Geert Uytterhoeven (1): nfs: NFS_SWAP should depend on SWAP [474c4f306eefbb21b67ebd1de802d005c7d7ecdc] Guenter Roeck (1): brcmfmac: abort and release host after error [863844ee3bd38219c88e82966d1df36a77716f3e] Herbert Xu (7): crypto: af_alg - Use bh_lock_sock in sk_destruct [37f96694cf73ba116993a9d2d99ad6a75fa7fdb0] crypto: api - Check spawn->alg under lock in crypto_drop_spawn [7db3b61b6bba4310f454588c2ca6faf2958ad79f] crypto: api - Fix race condition in crypto_spawn_alg [73669cc556462f4e50376538d77ee312142e8a8a] crypto: pcrypt - Do not clear MAY_SLEEP flag in original request [e8d998264bffade3cfe0536559f712ab9058d654] crypto: pcrypt - Fix user-after-free on module unload [07bfd9bdf568a38d9440c607b72342036011f727] padata: Remove broken queue flushing
