Re: [PATCH 31/33] perf, tools: Support generic events as pmu event names v2

2012-10-29 Thread Peter Zijlstra
On Sun, 2012-10-28 at 20:12 +0100, Andi Kleen wrote: > > Note I wrote and posted all this before you posted last week, but the wheels > of perf review grind so slowly that you overtook me. > > Peter Z., to be honest all these later patches are just caused by not having > generic TSX

Re: [PATCH 31/33] perf, tools: Support generic events as pmu event names v2

2012-10-29 Thread Peter Zijlstra
On Sun, 2012-10-28 at 20:12 +0100, Andi Kleen wrote: Note I wrote and posted all this before you posted last week, but the wheels of perf review grind so slowly that you overtook me. Peter Z., to be honest all these later patches are just caused by not having generic TSX events/modifiers

Re: [PATCH 31/33] perf, tools: Support generic events as pmu event names v2

2012-10-28 Thread Andi Kleen
On Sat, Oct 27, 2012 at 09:42:00PM +0200, Jiri Olsa wrote: > On Fri, Oct 26, 2012 at 01:30:13PM -0700, Andi Kleen wrote: > > From: Andi Kleen > > > > Extend the parser/lexer to allow generic event names like > > "instructions" as a sysfs supplied PMU event name. > > > > This resolves the

Re: [PATCH 31/33] perf, tools: Support generic events as pmu event names v2

2012-10-28 Thread Andi Kleen
On Sat, Oct 27, 2012 at 09:42:00PM +0200, Jiri Olsa wrote: On Fri, Oct 26, 2012 at 01:30:13PM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Extend the parser/lexer to allow generic event names like instructions as a sysfs supplied PMU event name. This resolves the

Re: [PATCH 31/33] perf, tools: Support generic events as pmu event names v2

2012-10-27 Thread Jiri Olsa
On Fri, Oct 26, 2012 at 01:30:13PM -0700, Andi Kleen wrote: > From: Andi Kleen > > Extend the parser/lexer to allow generic event names like > "instructions" as a sysfs supplied PMU event name. > > This resolves the problem that cpu/instructions/ gives a parse > error, even when the kernel

Re: [PATCH 31/33] perf, tools: Support generic events as pmu event names v2

2012-10-27 Thread Jiri Olsa
On Fri, Oct 26, 2012 at 01:30:13PM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Extend the parser/lexer to allow generic event names like instructions as a sysfs supplied PMU event name. This resolves the problem that cpu/instructions/ gives a parse error, even when the

[PATCH 31/33] perf, tools: Support generic events as pmu event names v2

2012-10-26 Thread Andi Kleen
From: Andi Kleen Extend the parser/lexer to allow generic event names like "instructions" as a sysfs supplied PMU event name. This resolves the problem that cpu/instructions/ gives a parse error, even when the kernel supplies a "instructions" event This is useful to add sysfs specified

[PATCH 31/33] perf, tools: Support generic events as pmu event names v2

2012-10-26 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com Extend the parser/lexer to allow generic event names like instructions as a sysfs supplied PMU event name. This resolves the problem that cpu/instructions/ gives a parse error, even when the kernel supplies a instructions event This is useful to add sysfs