Re: [PATCH 34/37] perf hists browser: Support flat callchains

2015-11-25 Thread Namhyung Kim
Hi Arnaldo, On Tue, Nov 24, 2015 at 11:10:25PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Nov 24, 2015 at 10:34:18PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Nov 25, 2015 at 10:26:08AM +0900, Namhyung Kim escreveu: > > > On Tue, Nov 24, 2015 at 12:45:51PM -0200, Arnaldo

Re: [PATCH 34/37] perf hists browser: Support flat callchains

2015-11-25 Thread Namhyung Kim
Hi Arnaldo, On Tue, Nov 24, 2015 at 11:10:25PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Nov 24, 2015 at 10:34:18PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Nov 25, 2015 at 10:26:08AM +0900, Namhyung Kim escreveu: > > > On Tue, Nov 24, 2015 at 12:45:51PM -0200, Arnaldo

Re: [PATCH 34/37] perf hists browser: Support flat callchains

2015-11-24 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 24, 2015 at 10:34:18PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Nov 25, 2015 at 10:26:08AM +0900, Namhyung Kim escreveu: > > On Tue, Nov 24, 2015 at 12:45:51PM -0200, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Nov 24, 2015 at 02:27:08PM +0900, Namhyung Kim escreveu: > > >

Re: [PATCH 34/37] perf hists browser: Support flat callchains

2015-11-24 Thread Namhyung Kim
Hi Arnaldo, On Tue, Nov 24, 2015 at 12:45:51PM -0200, Arnaldo Carvalho de Melo wrote: > Em Tue, Nov 24, 2015 at 02:27:08PM +0900, Namhyung Kim escreveu: > > On Mon, Nov 23, 2015 at 04:16:48PM +0100, Frederic Weisbecker wrote: > > > On Thu, Nov 19, 2015 at 02:53:20PM -0300, Arnaldo Carvalho de

Re: [PATCH 34/37] perf hists browser: Support flat callchains

2015-11-24 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 25, 2015 at 10:26:08AM +0900, Namhyung Kim escreveu: > On Tue, Nov 24, 2015 at 12:45:51PM -0200, Arnaldo Carvalho de Melo wrote: > > Em Tue, Nov 24, 2015 at 02:27:08PM +0900, Namhyung Kim escreveu: > > > On Mon, Nov 23, 2015 at 04:16:48PM +0100, Frederic Weisbecker wrote: > > > > On

Re: [PATCH 34/37] perf hists browser: Support flat callchains

2015-11-24 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 24, 2015 at 02:27:08PM +0900, Namhyung Kim escreveu: > On Mon, Nov 23, 2015 at 04:16:48PM +0100, Frederic Weisbecker wrote: > > On Thu, Nov 19, 2015 at 02:53:20PM -0300, Arnaldo Carvalho de Melo wrote: > > > From: Namhyung Kim > > [...] > > > > > +int

Re: [PATCH 34/37] perf hists browser: Support flat callchains

2015-11-24 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 24, 2015 at 10:34:18PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Nov 25, 2015 at 10:26:08AM +0900, Namhyung Kim escreveu: > > On Tue, Nov 24, 2015 at 12:45:51PM -0200, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Nov 24, 2015 at 02:27:08PM +0900, Namhyung Kim escreveu: > > >

Re: [PATCH 34/37] perf hists browser: Support flat callchains

2015-11-24 Thread Namhyung Kim
Hi Arnaldo, On Tue, Nov 24, 2015 at 12:45:51PM -0200, Arnaldo Carvalho de Melo wrote: > Em Tue, Nov 24, 2015 at 02:27:08PM +0900, Namhyung Kim escreveu: > > On Mon, Nov 23, 2015 at 04:16:48PM +0100, Frederic Weisbecker wrote: > > > On Thu, Nov 19, 2015 at 02:53:20PM -0300, Arnaldo Carvalho de

Re: [PATCH 34/37] perf hists browser: Support flat callchains

2015-11-24 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 25, 2015 at 10:26:08AM +0900, Namhyung Kim escreveu: > On Tue, Nov 24, 2015 at 12:45:51PM -0200, Arnaldo Carvalho de Melo wrote: > > Em Tue, Nov 24, 2015 at 02:27:08PM +0900, Namhyung Kim escreveu: > > > On Mon, Nov 23, 2015 at 04:16:48PM +0100, Frederic Weisbecker wrote: > > > > On

Re: [PATCH 34/37] perf hists browser: Support flat callchains

2015-11-24 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 24, 2015 at 02:27:08PM +0900, Namhyung Kim escreveu: > On Mon, Nov 23, 2015 at 04:16:48PM +0100, Frederic Weisbecker wrote: > > On Thu, Nov 19, 2015 at 02:53:20PM -0300, Arnaldo Carvalho de Melo wrote: > > > From: Namhyung Kim > > [...] > > > > > +int

Re: [PATCH 34/37] perf hists browser: Support flat callchains

2015-11-23 Thread Namhyung Kim
On Mon, Nov 23, 2015 at 04:16:48PM +0100, Frederic Weisbecker wrote: > On Thu, Nov 19, 2015 at 02:53:20PM -0300, Arnaldo Carvalho de Melo wrote: > > From: Namhyung Kim > > > > The flat callchain mode is to print all chains in a single, simple > > hierarchy so make it easy to see. > > > >

Re: [PATCH 34/37] perf hists browser: Support flat callchains

2015-11-23 Thread Frederic Weisbecker
On Thu, Nov 19, 2015 at 02:53:20PM -0300, Arnaldo Carvalho de Melo wrote: > From: Namhyung Kim > > The flat callchain mode is to print all chains in a single, simple > hierarchy so make it easy to see. > > Currently perf report --tui doesn't show flat callchains properly. With > flat

Re: [PATCH 34/37] perf hists browser: Support flat callchains

2015-11-23 Thread Namhyung Kim
On Mon, Nov 23, 2015 at 04:16:48PM +0100, Frederic Weisbecker wrote: > On Thu, Nov 19, 2015 at 02:53:20PM -0300, Arnaldo Carvalho de Melo wrote: > > From: Namhyung Kim > > > > The flat callchain mode is to print all chains in a single, simple > > hierarchy so make it easy to

Re: [PATCH 34/37] perf hists browser: Support flat callchains

2015-11-23 Thread Frederic Weisbecker
On Thu, Nov 19, 2015 at 02:53:20PM -0300, Arnaldo Carvalho de Melo wrote: > From: Namhyung Kim > > The flat callchain mode is to print all chains in a single, simple > hierarchy so make it easy to see. > > Currently perf report --tui doesn't show flat callchains properly.

[PATCH 34/37] perf hists browser: Support flat callchains

2015-11-19 Thread Arnaldo Carvalho de Melo
From: Namhyung Kim The flat callchain mode is to print all chains in a single, simple hierarchy so make it easy to see. Currently perf report --tui doesn't show flat callchains properly. With flat callchains, only leaf nodes are added to the final rbtree so it should show entries in parent

[PATCH 34/37] perf hists browser: Support flat callchains

2015-11-19 Thread Arnaldo Carvalho de Melo
From: Namhyung Kim The flat callchain mode is to print all chains in a single, simple hierarchy so make it easy to see. Currently perf report --tui doesn't show flat callchains properly. With flat callchains, only leaf nodes are added to the final rbtree so it should show