Re: [PATCH 4/4] ACPI/IORT: Don't call iommu_ops->add_device directly

2018-12-17 Thread Hanjun Guo 
On 2018/12/11 23:05, Joerg Roedel wrote:
> From: Joerg Roedel 
> 
> Make sure to invoke this call-back through the proper
> function of the IOMMU-API.
> 
> Signed-off-by: Joerg Roedel 
> ---
>  drivers/acpi/arm64/iort.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Robin and Lorenzo know this better than me, but it's
pretty straight forward to me,

Acked-by: Hanjun Guo 

Thanks
Hanjun

[PATCH 4/4] ACPI/IORT: Don't call iommu_ops->add_device directly

2018-12-11 Thread Joerg Roedel 
From: Joerg Roedel 

Make sure to invoke this call-back through the proper
function of the IOMMU-API.

Signed-off-by: Joerg Roedel 
---
 drivers/acpi/arm64/iort.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index 70f4e80b9246..d4f7c1adc048 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -805,8 +805,8 @@ static inline int iort_add_device_replay(const struct 
iommu_ops *ops,
 {
int err = 0;
 
-   if (ops->add_device && dev->bus && !dev->iommu_group)
-   err = ops->add_device(dev);
+   if (dev->bus && !dev->iommu_group)
+   err = iommu_probe_device(dev);
 
return err;
 }
-- 
2.17.1