Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Fri, Mar 26, 2021 at 08:20:07AM -0600, Alex Williamson wrote: > On Fri, 26 Mar 2021 09:40:30 +0300 > Leon Romanovsky wrote: <...> > > > > It supports by writing: echo "bus,pm" > reset_methods. > > Regarding comma, IMHO it is easiest pattern for the parsing. > > > > Anyway, The in-kernel

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Fri, 26 Mar 2021 09:40:30 +0300 Leon Romanovsky wrote: > On Thu, Mar 25, 2021 at 11:53:24AM -0600, Alex Williamson wrote: > > On Thu, 25 Mar 2021 18:09:58 +0200 > > Leon Romanovsky wrote: > > > > > On Thu, Mar 25, 2021 at 08:55:04AM -0600, Alex Williamson wrote: > > > > On Thu, 25 Mar

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Fri, Mar 26, 2021 at 10:18:25AM +0100, Krzysztof Wilczyński wrote: > Hello, > > [...] > > Aside of the sysfs interface, would this new functionality also require > anything to be overridden at boot time via passing some command-line > arguments? Not sure how relevant such thing would be to

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

Hello, [...] Aside of the sysfs interface, would this new functionality also require anything to be overridden at boot time via passing some command-line arguments? Not sure how relevant such thing would be to device, but, whatnot reset, though. I am curious whether there would be a need for

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Thu, Mar 25, 2021 at 11:53:24AM -0600, Alex Williamson wrote: > On Thu, 25 Mar 2021 18:09:58 +0200 > Leon Romanovsky wrote: > > > On Thu, Mar 25, 2021 at 08:55:04AM -0600, Alex Williamson wrote: > > > On Thu, 25 Mar 2021 10:37:54 +0200 > > > Leon Romanovsky wrote: > > > > > > > On Wed,

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Thu, 25 Mar 2021 18:09:58 +0200 Leon Romanovsky wrote: > On Thu, Mar 25, 2021 at 08:55:04AM -0600, Alex Williamson wrote: > > On Thu, 25 Mar 2021 10:37:54 +0200 > > Leon Romanovsky wrote: > > > > > On Wed, Mar 24, 2021 at 11:17:29AM -0600, Alex Williamson wrote: > > > > On Wed, 24 Mar

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Thu, Mar 25, 2021 at 10:52:57PM +0530, Amey Narkhede wrote: > On 21/03/25 06:09PM, Leon Romanovsky wrote: > > On Thu, Mar 25, 2021 at 08:55:04AM -0600, Alex Williamson wrote: > > > On Thu, 25 Mar 2021 10:37:54 +0200 > > > Leon Romanovsky wrote: > > > > > > > On Wed, Mar 24, 2021 at 11:17:29AM

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/25 06:09PM, Leon Romanovsky wrote: > On Thu, Mar 25, 2021 at 08:55:04AM -0600, Alex Williamson wrote: > > On Thu, 25 Mar 2021 10:37:54 +0200 > > Leon Romanovsky wrote: > > > > > On Wed, Mar 24, 2021 at 11:17:29AM -0600, Alex Williamson wrote: > > > > On Wed, 24 Mar 2021 17:13:56 +0200 >

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Thu, Mar 25, 2021 at 09:56:37PM +0530, Amey Narkhede wrote: > On 21/03/25 10:37AM, Leon Romanovsky wrote: > > On Wed, Mar 24, 2021 at 11:17:29AM -0600, Alex Williamson wrote: > > > On Wed, 24 Mar 2021 17:13:56 +0200 > > > Leon Romanovsky wrote: <...> > > I expect that QEMU sets same reset

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/25 10:37AM, Leon Romanovsky wrote: > On Wed, Mar 24, 2021 at 11:17:29AM -0600, Alex Williamson wrote: > > On Wed, 24 Mar 2021 17:13:56 +0200 > > Leon Romanovsky wrote: > > <...> > > > > Yes, and real testing/debugging almost always requires kernel rebuild. > > > Everything else is waste

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Thu, Mar 25, 2021 at 08:55:04AM -0600, Alex Williamson wrote: > On Thu, 25 Mar 2021 10:37:54 +0200 > Leon Romanovsky wrote: > > > On Wed, Mar 24, 2021 at 11:17:29AM -0600, Alex Williamson wrote: > > > On Wed, 24 Mar 2021 17:13:56 +0200 > > > Leon Romanovsky wrote: > > > > <...> > > > > >

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Thu, 25 Mar 2021 10:37:54 +0200 Leon Romanovsky wrote: > On Wed, Mar 24, 2021 at 11:17:29AM -0600, Alex Williamson wrote: > > On Wed, 24 Mar 2021 17:13:56 +0200 > > Leon Romanovsky wrote: > > <...> > > > > Yes, and real testing/debugging almost always requires kernel rebuild. > > >

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Wed, Mar 24, 2021 at 11:17:29AM -0600, Alex Williamson wrote: > On Wed, 24 Mar 2021 17:13:56 +0200 > Leon Romanovsky wrote: <...> > > Yes, and real testing/debugging almost always requires kernel rebuild. > > Everything else is waste of time. > > Sorry, this is nonsense. Allowing users to

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Wed, 24 Mar 2021 17:13:56 +0200 Leon Romanovsky wrote: > On Wed, Mar 24, 2021 at 08:37:43AM -0600, Alex Williamson wrote: > > On Wed, 24 Mar 2021 12:03:00 +0200 > > Leon Romanovsky wrote: > > > > > On Mon, Mar 22, 2021 at 11:10:03AM -0600, Alex Williamson wrote: > > > > On Sun, 21 Mar

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Wed, Mar 24, 2021 at 08:37:43AM -0600, Alex Williamson wrote: > On Wed, 24 Mar 2021 12:03:00 +0200 > Leon Romanovsky wrote: > > > On Mon, Mar 22, 2021 at 11:10:03AM -0600, Alex Williamson wrote: > > > On Sun, 21 Mar 2021 10:40:55 +0200 > > > Leon Romanovsky wrote: > > > > > > > On Sat,

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Wed, 24 Mar 2021 12:03:00 +0200 Leon Romanovsky wrote: > On Mon, Mar 22, 2021 at 11:10:03AM -0600, Alex Williamson wrote: > > On Sun, 21 Mar 2021 10:40:55 +0200 > > Leon Romanovsky wrote: > > > > > On Sat, Mar 20, 2021 at 08:59:42AM -0600, Alex Williamson wrote: > > > > On Sat, 20 Mar

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Mon, Mar 22, 2021 at 11:10:03AM -0600, Alex Williamson wrote: > On Sun, 21 Mar 2021 10:40:55 +0200 > Leon Romanovsky wrote: > > > On Sat, Mar 20, 2021 at 08:59:42AM -0600, Alex Williamson wrote: > > > On Sat, 20 Mar 2021 11:10:08 +0200 > > > Leon Romanovsky wrote: > > > > On Fri, Mar 19,

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Tue, 23 Mar 2021 10:06:25 -0600 Alex Williamson wrote: > On Tue, 23 Mar 2021 21:02:21 +0530 > Amey Narkhede wrote: > > > On 21/03/23 08:44AM, Alex Williamson wrote: > > > On Tue, 23 Mar 2021 15:34:19 +0100 > > > Pali Rohár wrote: > > > > > > > On Thursday 18 March 2021 20:01:55 Amey

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Tue, 23 Mar 2021 21:02:21 +0530 Amey Narkhede wrote: > On 21/03/23 08:44AM, Alex Williamson wrote: > > On Tue, 23 Mar 2021 15:34:19 +0100 > > Pali Rohár wrote: > > > > > On Thursday 18 March 2021 20:01:55 Amey Narkhede wrote: > > > > On 21/03/17 09:13PM, Pali Rohár wrote: > > > > > On

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/23 08:44AM, Alex Williamson wrote: > On Tue, 23 Mar 2021 15:34:19 +0100 > Pali Rohár wrote: > > > On Thursday 18 March 2021 20:01:55 Amey Narkhede wrote: > > > On 21/03/17 09:13PM, Pali Rohár wrote: > > > > On Wednesday 17 March 2021 14:00:20 Alex Williamson wrote: > > > > > On Wed, 17

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Tue, 23 Mar 2021 15:34:19 +0100 Pali Rohár wrote: > On Thursday 18 March 2021 20:01:55 Amey Narkhede wrote: > > On 21/03/17 09:13PM, Pali Rohár wrote: > > > On Wednesday 17 March 2021 14:00:20 Alex Williamson wrote: > > > > On Wed, 17 Mar 2021 20:40:24 +0100 > > > > Pali Rohár wrote: > >

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Thursday 18 March 2021 20:01:55 Amey Narkhede wrote: > On 21/03/17 09:13PM, Pali Rohár wrote: > > On Wednesday 17 March 2021 14:00:20 Alex Williamson wrote: > > > On Wed, 17 Mar 2021 20:40:24 +0100 > > > Pali Rohár wrote: > > > > > > > On Wednesday 17 March 2021 13:32:45 Alex Williamson wrote:

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Sun, 21 Mar 2021 10:40:55 +0200 Leon Romanovsky wrote: > On Sat, Mar 20, 2021 at 08:59:42AM -0600, Alex Williamson wrote: > > On Sat, 20 Mar 2021 11:10:08 +0200 > > Leon Romanovsky wrote: > > > On Fri, Mar 19, 2021 at 10:23:13AM -0600, Alex Williamson wrote: > > > > > > > > What if we

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/21 10:40AM, Leon Romanovsky wrote: > On Sat, Mar 20, 2021 at 08:59:42AM -0600, Alex Williamson wrote: > > On Sat, 20 Mar 2021 11:10:08 +0200 > > Leon Romanovsky wrote: > > > On Fri, Mar 19, 2021 at 10:23:13AM -0600, Alex Williamson wrote: > > > > > > > > What if we taint the kernel or

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Sat, Mar 20, 2021 at 08:59:42AM -0600, Alex Williamson wrote: > On Sat, 20 Mar 2021 11:10:08 +0200 > Leon Romanovsky wrote: > > On Fri, Mar 19, 2021 at 10:23:13AM -0600, Alex Williamson wrote: > > > > > > What if we taint the kernel or pci_warn() for cases where either all > > > the reset

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Sat, 20 Mar 2021 11:10:08 +0200 Leon Romanovsky wrote: > On Fri, Mar 19, 2021 at 10:23:13AM -0600, Alex Williamson wrote: > > > > What if we taint the kernel or pci_warn() for cases where either all > > the reset methods are disabled, ie. 'echo none > reset_method', or any > > time a device

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Fri, Mar 19, 2021 at 10:23:13AM -0600, Alex Williamson wrote: > On Fri, 19 Mar 2021 14:59:47 +0200 > Leon Romanovsky wrote: > > > On Thu, Mar 18, 2021 at 07:34:56PM +0100, Enrico Weigelt, metux IT consult > > wrote: > > > On 18.03.21 18:22, Leon Romanovsky wrote: > > > > > > > Which email

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Fri, Mar 19, 2021 at 10:57:11AM -0500, Bjorn Helgaas wrote: > On Fri, Mar 19, 2021 at 02:59:47PM +0200, Leon Romanovsky wrote: > > On Thu, Mar 18, 2021 at 07:34:56PM +0100, Enrico Weigelt, metux IT consult > > wrote: > > > On 18.03.21 18:22, Leon Romanovsky wrote: > > > > > > > Which email

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Fri, 19 Mar 2021 14:59:47 +0200 Leon Romanovsky wrote: > On Thu, Mar 18, 2021 at 07:34:56PM +0100, Enrico Weigelt, metux IT consult > wrote: > > On 18.03.21 18:22, Leon Romanovsky wrote: > > > > > Which email client do you use? > > > Your responses are grouped as one huge block without

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Fri, Mar 19, 2021 at 02:59:47PM +0200, Leon Romanovsky wrote: > On Thu, Mar 18, 2021 at 07:34:56PM +0100, Enrico Weigelt, metux IT consult > wrote: > > On 18.03.21 18:22, Leon Romanovsky wrote: > > > > > Which email client do you use? Your responses are grouped as > > > one huge block

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/19 05:37PM, Leon Romanovsky wrote: > On Fri, Mar 19, 2021 at 08:53:17PM +0530, Amey Narkhede wrote: > > On 21/03/19 03:05PM, Leon Romanovsky wrote: > > <...> > > > > > > It was exactly the reason why I think that VM usecase presented by > > > > > you is not viable. > > > > > > > > > Well

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Fri, Mar 19, 2021 at 02:48:12PM +0100, Enrico Weigelt, metux IT consult wrote: > On 19.03.21 13:59, Leon Romanovsky wrote: <...> > In any case, I still fail to see why giving operators an debug knob > should make anything worse. I see this patch as a workaround to stop and provide quirks

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Fri, Mar 19, 2021 at 08:53:17PM +0530, Amey Narkhede wrote: > On 21/03/19 03:05PM, Leon Romanovsky wrote: <...> > > > > It was exactly the reason why I think that VM usecase presented by > > > > you is not viable. > > > > > > > Well I didn't present it as new use case. I just gave existing >

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/19 03:05PM, Leon Romanovsky wrote: > On Thu, Mar 18, 2021 at 11:13:44PM +0530, Amey Narkhede wrote: > > On 21/03/18 07:35PM, Leon Romanovsky wrote: > > > On Thu, Mar 18, 2021 at 10:31:43PM +0530, Amey Narkhede wrote: > > > > On 21/03/18 04:57PM, Leon Romanovsky wrote: > > > > > On Thu,

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 19.03.21 13:59, Leon Romanovsky wrote: I really doubt we can influence that by any technical decision here in the kernel. There are subsystems that succeeded to do it, for example netdev, RDMA e.t.c. I'd guess either hi-end / server or embedded products - already mentioned that these are

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Thu, Mar 18, 2021 at 06:58:25PM +0100, Enrico Weigelt, metux IT consult wrote: > On 18.03.21 18:35, Leon Romanovsky wrote: > > > I see it as a good example of cheap solution. Vendor won't fix your > > touchpad because distros provide workaround. The same will be with reset. > > Usually,

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Thu, Mar 18, 2021 at 11:13:44PM +0530, Amey Narkhede wrote: > On 21/03/18 07:35PM, Leon Romanovsky wrote: > > On Thu, Mar 18, 2021 at 10:31:43PM +0530, Amey Narkhede wrote: > > > On 21/03/18 04:57PM, Leon Romanovsky wrote: > > > > On Thu, Mar 18, 2021 at 07:52:52PM +0530, Amey Narkhede wrote: >

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Thu, Mar 18, 2021 at 07:34:56PM +0100, Enrico Weigelt, metux IT consult wrote: > On 18.03.21 18:22, Leon Romanovsky wrote: > > > Which email client do you use? > > Your responses are grouped as one huge block without any chance to respond > > to you on specific point or answer to your

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 18.03.21 18:22, Leon Romanovsky wrote: Which email client do you use? Your responses are grouped as one huge block without any chance to respond to you on specific point or answer to your question. I'm reading this thread in Tbird, and threading / quoting all looks nice. I see your flow

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 18.03.21 18:43, Amey Narkhede wrote: Well I didn't present it as new use case. I just gave existing usecase based on existing reset attribute. Nothing new here. Nothing really changes wrt that use case. As a board driver maintainer, I fully support your case. At least as a

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 18.03.21 18:35, Leon Romanovsky wrote: I see it as a good example of cheap solution. Vendor won't fix your touchpad because distros provide workaround. The same will be with reset. Usually, vendor won't fix it, anyways, regardless of any kernel workarounds. Most Vendors are already

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 15.03.21 00:55, Pali Rohár wrote: Moreover for mPCIe form factor cards, boards can share one PERST# signal with more PCIe cards and control this signal via GPIO. So asserting PERST# GPIO can trigger Warm reset for more PCIe cards, not just one. It depends on board or topology. The

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/18 07:35PM, Leon Romanovsky wrote: > On Thu, Mar 18, 2021 at 10:31:43PM +0530, Amey Narkhede wrote: > > On 21/03/18 04:57PM, Leon Romanovsky wrote: > > > On Thu, Mar 18, 2021 at 07:52:52PM +0530, Amey Narkhede wrote: > > > > On 21/03/18 11:09AM, Leon Romanovsky wrote: > > > > > On Wed,

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/18 07:22PM, Leon Romanovsky wrote: > On Thu, Mar 18, 2021 at 10:39:35AM -0600, Alex Williamson wrote: > > On Thu, 18 Mar 2021 11:09:34 +0200 > > Leon Romanovsky wrote: > > <...> > > > > I'm lost here, does vfio-pci use sysfs interface or internal to the > > > kernel API? > > > > > > If

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Thu, Mar 18, 2021 at 10:31:43PM +0530, Amey Narkhede wrote: > On 21/03/18 04:57PM, Leon Romanovsky wrote: > > On Thu, Mar 18, 2021 at 07:52:52PM +0530, Amey Narkhede wrote: > > > On 21/03/18 11:09AM, Leon Romanovsky wrote: > > > > On Wed, Mar 17, 2021 at 11:31:40AM -0600, Alex Williamson wrote:

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Thu, Mar 18, 2021 at 10:39:35AM -0600, Alex Williamson wrote: > On Thu, 18 Mar 2021 11:09:34 +0200 > Leon Romanovsky wrote: <...> > > I'm lost here, does vfio-pci use sysfs interface or internal to the kernel > > API? > > > > If it is latter then we don't really need sysfs, if not, we still

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/18 04:57PM, Leon Romanovsky wrote: > On Thu, Mar 18, 2021 at 07:52:52PM +0530, Amey Narkhede wrote: > > On 21/03/18 11:09AM, Leon Romanovsky wrote: > > > On Wed, Mar 17, 2021 at 11:31:40AM -0600, Alex Williamson wrote: > > > > On Wed, 17 Mar 2021 15:58:40 +0200 > > > > Leon Romanovsky

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Thu, 18 Mar 2021 11:09:34 +0200 Leon Romanovsky wrote: > On Wed, Mar 17, 2021 at 11:31:40AM -0600, Alex Williamson wrote: > > On Wed, 17 Mar 2021 15:58:40 +0200 > > Leon Romanovsky wrote: > > > > > On Wed, Mar 17, 2021 at 06:47:18PM +0530, Amey Narkhede wrote: > > > > On 21/03/17

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Thu, Mar 18, 2021 at 07:52:52PM +0530, Amey Narkhede wrote: > On 21/03/18 11:09AM, Leon Romanovsky wrote: > > On Wed, Mar 17, 2021 at 11:31:40AM -0600, Alex Williamson wrote: > > > On Wed, 17 Mar 2021 15:58:40 +0200 > > > Leon Romanovsky wrote: > > > > > > > On Wed, Mar 17, 2021 at 06:47:18PM

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/17 09:13PM, Pali Rohár wrote: > On Wednesday 17 March 2021 14:00:20 Alex Williamson wrote: > > On Wed, 17 Mar 2021 20:40:24 +0100 > > Pali Rohár wrote: > > > > > On Wednesday 17 March 2021 13:32:45 Alex Williamson wrote: > > > > On Wed, 17 Mar 2021 20:24:24 +0100 > > > > Pali Rohár

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/18 11:09AM, Leon Romanovsky wrote: > On Wed, Mar 17, 2021 at 11:31:40AM -0600, Alex Williamson wrote: > > On Wed, 17 Mar 2021 15:58:40 +0200 > > Leon Romanovsky wrote: > > > > > On Wed, Mar 17, 2021 at 06:47:18PM +0530, Amey Narkhede wrote: > > > > On 21/03/17 01:47PM, Leon Romanovsky

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Wed, Mar 17, 2021 at 11:31:40AM -0600, Alex Williamson wrote: > On Wed, 17 Mar 2021 15:58:40 +0200 > Leon Romanovsky wrote: > > > On Wed, Mar 17, 2021 at 06:47:18PM +0530, Amey Narkhede wrote: > > > On 21/03/17 01:47PM, Leon Romanovsky wrote: > > > > On Wed, Mar 17, 2021 at 04:53:09PM +0530,

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Wednesday 17 March 2021 14:00:20 Alex Williamson wrote: > On Wed, 17 Mar 2021 20:40:24 +0100 > Pali Rohár wrote: > > > On Wednesday 17 March 2021 13:32:45 Alex Williamson wrote: > > > On Wed, 17 Mar 2021 20:24:24 +0100 > > > Pali Rohár wrote: > > > > > > > On Wednesday 17 March 2021

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Wed, 17 Mar 2021 20:40:24 +0100 Pali Rohár wrote: > On Wednesday 17 March 2021 13:32:45 Alex Williamson wrote: > > On Wed, 17 Mar 2021 20:24:24 +0100 > > Pali Rohár wrote: > > > > > On Wednesday 17 March 2021 13:15:36 Alex Williamson wrote: > > > > On Wed, 17 Mar 2021 20:02:06 +0100 > >

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Wednesday 17 March 2021 13:32:45 Alex Williamson wrote: > On Wed, 17 Mar 2021 20:24:24 +0100 > Pali Rohár wrote: > > > On Wednesday 17 March 2021 13:15:36 Alex Williamson wrote: > > > On Wed, 17 Mar 2021 20:02:06 +0100 > > > Pali Rohár wrote: > > > > > > > On Monday 15 March 2021 09:03:39

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Wed, 17 Mar 2021 20:24:24 +0100 Pali Rohár wrote: > On Wednesday 17 March 2021 13:15:36 Alex Williamson wrote: > > On Wed, 17 Mar 2021 20:02:06 +0100 > > Pali Rohár wrote: > > > > > On Monday 15 March 2021 09:03:39 Alex Williamson wrote: > > > > On Mon, 15 Mar 2021 15:52:38 +0100 > > >

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Wednesday 17 March 2021 13:15:36 Alex Williamson wrote: > On Wed, 17 Mar 2021 20:02:06 +0100 > Pali Rohár wrote: > > > On Monday 15 March 2021 09:03:39 Alex Williamson wrote: > > > On Mon, 15 Mar 2021 15:52:38 +0100 > > > Pali Rohár wrote: > > > > > > > On Monday 15 March 2021 08:34:09

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Wed, 17 Mar 2021 20:02:06 +0100 Pali Rohár wrote: > On Monday 15 March 2021 09:03:39 Alex Williamson wrote: > > On Mon, 15 Mar 2021 15:52:38 +0100 > > Pali Rohár wrote: > > > > > On Monday 15 March 2021 08:34:09 Alex Williamson wrote: > > > > On Mon, 15 Mar 2021 14:52:26 +0100 > > > >

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Monday 15 March 2021 09:03:39 Alex Williamson wrote: > On Mon, 15 Mar 2021 15:52:38 +0100 > Pali Rohár wrote: > > > On Monday 15 March 2021 08:34:09 Alex Williamson wrote: > > > On Mon, 15 Mar 2021 14:52:26 +0100 > > > Pali Rohár wrote: > > > > > > > On Monday 15 March 2021 19:13:23 Amey

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Wed, 17 Mar 2021 15:58:40 +0200 Leon Romanovsky wrote: > On Wed, Mar 17, 2021 at 06:47:18PM +0530, Amey Narkhede wrote: > > On 21/03/17 01:47PM, Leon Romanovsky wrote: > > > On Wed, Mar 17, 2021 at 04:53:09PM +0530, Amey Narkhede wrote: > > > > On 21/03/17 01:02PM, Leon Romanovsky wrote:

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Wed, Mar 17, 2021 at 06:47:18PM +0530, Amey Narkhede wrote: > On 21/03/17 01:47PM, Leon Romanovsky wrote: > > On Wed, Mar 17, 2021 at 04:53:09PM +0530, Amey Narkhede wrote: > > > On 21/03/17 01:02PM, Leon Romanovsky wrote: > > > > On Wed, Mar 17, 2021 at 03:54:47PM +0530, Amey Narkhede wrote: >

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/17 01:47PM, Leon Romanovsky wrote: > On Wed, Mar 17, 2021 at 04:53:09PM +0530, Amey Narkhede wrote: > > On 21/03/17 01:02PM, Leon Romanovsky wrote: > > > On Wed, Mar 17, 2021 at 03:54:47PM +0530, Amey Narkhede wrote: > > > > On 21/03/17 06:20AM, Leon Romanovsky wrote: > > > > > On Mon,

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Wed, Mar 17, 2021 at 04:53:09PM +0530, Amey Narkhede wrote: > On 21/03/17 01:02PM, Leon Romanovsky wrote: > > On Wed, Mar 17, 2021 at 03:54:47PM +0530, Amey Narkhede wrote: > > > On 21/03/17 06:20AM, Leon Romanovsky wrote: > > > > On Mon, Mar 15, 2021 at 06:32:32PM +, Raphael Norwitz wrote:

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/17 01:02PM, Leon Romanovsky wrote: > On Wed, Mar 17, 2021 at 03:54:47PM +0530, Amey Narkhede wrote: > > On 21/03/17 06:20AM, Leon Romanovsky wrote: > > > On Mon, Mar 15, 2021 at 06:32:32PM +, Raphael Norwitz wrote: > > > > On Mon, Mar 15, 2021 at 10:29:50AM -0600, Alex Williamson

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Wed, Mar 17, 2021 at 03:54:47PM +0530, Amey Narkhede wrote: > On 21/03/17 06:20AM, Leon Romanovsky wrote: > > On Mon, Mar 15, 2021 at 06:32:32PM +, Raphael Norwitz wrote: > > > On Mon, Mar 15, 2021 at 10:29:50AM -0600, Alex Williamson wrote: > > > > On Mon, 15 Mar 2021 21:03:41 +0530 > > >

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/17 06:20AM, Leon Romanovsky wrote: > On Mon, Mar 15, 2021 at 06:32:32PM +, Raphael Norwitz wrote: > > On Mon, Mar 15, 2021 at 10:29:50AM -0600, Alex Williamson wrote: > > > On Mon, 15 Mar 2021 21:03:41 +0530 > > > Amey Narkhede wrote: > > > > > > > On 21/03/15 05:07PM, Leon

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Mon, Mar 15, 2021 at 06:32:32PM +, Raphael Norwitz wrote: > On Mon, Mar 15, 2021 at 10:29:50AM -0600, Alex Williamson wrote: > > On Mon, 15 Mar 2021 21:03:41 +0530 > > Amey Narkhede wrote: > > > > > On 21/03/15 05:07PM, Leon Romanovsky wrote: > > > > On Mon, Mar 15, 2021 at 08:34:09AM

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Mon, Mar 15, 2021 at 10:29:50AM -0600, Alex Williamson wrote: > On Mon, 15 Mar 2021 21:03:41 +0530 > Amey Narkhede wrote: > > > On 21/03/15 05:07PM, Leon Romanovsky wrote: > > > On Mon, Mar 15, 2021 at 08:34:09AM -0600, Alex Williamson wrote: > > > > On Mon, 15 Mar 2021 14:52:26 +0100 > > >

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Mon, 15 Mar 2021 21:03:41 +0530 Amey Narkhede wrote: > On 21/03/15 05:07PM, Leon Romanovsky wrote: > > On Mon, Mar 15, 2021 at 08:34:09AM -0600, Alex Williamson wrote: > > > On Mon, 15 Mar 2021 14:52:26 +0100 > > > Pali Rohár wrote: > > > > > > > On Monday 15 March 2021 19:13:23 Amey

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/15 05:07PM, Leon Romanovsky wrote: > On Mon, Mar 15, 2021 at 08:34:09AM -0600, Alex Williamson wrote: > > On Mon, 15 Mar 2021 14:52:26 +0100 > > Pali Rohár wrote: > > > > > On Monday 15 March 2021 19:13:23 Amey Narkhede wrote: > > > > slot reset (pci_dev_reset_slot_function) and

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Mon, Mar 15, 2021 at 08:34:09AM -0600, Alex Williamson wrote: > On Mon, 15 Mar 2021 14:52:26 +0100 > Pali Rohár wrote: > > > On Monday 15 March 2021 19:13:23 Amey Narkhede wrote: > > > slot reset (pci_dev_reset_slot_function) and secondary bus > > > reset(pci_parent_bus_reset) which I think

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Mon, 15 Mar 2021 15:52:38 +0100 Pali Rohár wrote: > On Monday 15 March 2021 08:34:09 Alex Williamson wrote: > > On Mon, 15 Mar 2021 14:52:26 +0100 > > Pali Rohár wrote: > > > > > On Monday 15 March 2021 19:13:23 Amey Narkhede wrote: > > > > slot reset (pci_dev_reset_slot_function) and

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Monday 15 March 2021 08:34:09 Alex Williamson wrote: > On Mon, 15 Mar 2021 14:52:26 +0100 > Pali Rohár wrote: > > > On Monday 15 March 2021 19:13:23 Amey Narkhede wrote: > > > slot reset (pci_dev_reset_slot_function) and secondary bus > > > reset(pci_parent_bus_reset) which I think are hot

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Mon, 15 Mar 2021 14:52:26 +0100 Pali Rohár wrote: > On Monday 15 March 2021 19:13:23 Amey Narkhede wrote: > > slot reset (pci_dev_reset_slot_function) and secondary bus > > reset(pci_parent_bus_reset) which I think are hot reset and > > warm reset respectively. > > No. PCI secondary bus

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Monday 15 March 2021 19:13:23 Amey Narkhede wrote: > slot reset (pci_dev_reset_slot_function) and secondary bus > reset(pci_parent_bus_reset) which I think are hot reset and > warm reset respectively. No. PCI secondary bus reset = PCIe Hot Reset. Slot reset is just another type of reset, which

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On 21/03/15 12:55AM, Pali Rohár wrote: > On Friday 12 March 2021 23:04:52 ameynarkhed...@gmail.com wrote: > > From: Amey Narkhede > > > > Add reset_methods_enabled bitmap to struct pci_dev to > > keep track of user preferred device reset mechanisms. > > Add reset_method sysfs attribute to query

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

On Friday 12 March 2021 23:04:52 ameynarkhed...@gmail.com wrote: > From: Amey Narkhede > > Add reset_methods_enabled bitmap to struct pci_dev to > keep track of user preferred device reset mechanisms. > Add reset_method sysfs attribute to query and set > user preferred device reset mechanisms. >

[PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

From: Amey Narkhede Add reset_methods_enabled bitmap to struct pci_dev to keep track of user preferred device reset mechanisms. Add reset_method sysfs attribute to query and set user preferred device reset mechanisms. Signed-off-by: Amey Narkhede --- Reviewed-by: Alex Williamson Reviewed-by: