Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-08-01 Thread Francisco Jerez
Giovanni Gherdovich writes: > On Mon, 2018-07-30 at 11:32 -0700, Francisco Jerez wrote: >> Mel Gorman writes: >>  >> > On Sat, Jul 28, 2018 at 01:21:51PM -0700, Francisco Jerez wrote: >> > > > > Please revert this series, it led to significant energy usage and >> > > > > graphics performance reg

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-31 Thread Srinivas Pandruvada
On Tue, 2018-07-31 at 17:04 +0200, Peter Zijlstra wrote: > On Mon, Jul 30, 2018 at 07:06:21AM -0700, Srinivas Pandruvada wrote: > > On Mon, 2018-07-30 at 14:16 +0300, Eero Tamminen wrote: > > > Questions: > > > > > > * Does currently kernel CPU freq management have any idea which > > > IO > > >

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-31 Thread Peter Zijlstra
On Mon, Jul 30, 2018 at 07:06:21AM -0700, Srinivas Pandruvada wrote: > On Mon, 2018-07-30 at 14:16 +0300, Eero Tamminen wrote: > > Questions: > > > > * Does currently kernel CPU freq management have any idea which IO > >devices share TDP with the CPU cores? > No. The requests we do to hardwar

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-31 Thread Giovanni Gherdovich
On Mon, 2018-07-30 at 11:32 -0700, Francisco Jerez wrote: > Mel Gorman writes: >  > > On Sat, Jul 28, 2018 at 01:21:51PM -0700, Francisco Jerez wrote: > > > > > Please revert this series, it led to significant energy usage and > > > > > graphics performance regressions [1].  The reasons are roughl

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-30 Thread Francisco Jerez
Mel Gorman writes: > On Sat, Jul 28, 2018 at 01:21:51PM -0700, Francisco Jerez wrote: >> >> Please revert this series, it led to significant energy usage and >> >> graphics performance regressions [1]. The reasons are roughly the ones >> >> we discussed by e-mail off-list last April: This causes

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-30 Thread Srinivas Pandruvada
On Mon, 2018-07-30 at 16:43 +0100, Mel Gorman wrote: > On Sat, Jul 28, 2018 at 01:21:51PM -0700, Francisco Jerez wrote: > > > > Please revert this series, it led to significant energy usage > > > > and > > > > graphics performance regressions [1]. The reasons are roughly > > > > the ones > > > > w

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-30 Thread Mel Gorman
On Sat, Jul 28, 2018 at 01:21:51PM -0700, Francisco Jerez wrote: > >> Please revert this series, it led to significant energy usage and > >> graphics performance regressions [1]. The reasons are roughly the ones > >> we discussed by e-mail off-list last April: This causes the intel_pstate > >> dri

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-30 Thread Srinivas Pandruvada
On Mon, 2018-07-30 at 14:16 +0300, Eero Tamminen wrote: > Hi Mel, > > On 28.07.2018 15:36, Mel Gorman wrote: > > On Fri, Jul 27, 2018 at 10:34:03PM -0700, Francisco Jerez wrote: > > > Srinivas Pandruvada writes: > > > > > > > Enable HWP boost on Skylake server and workstations. > > > > > > > >

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-30 Thread Srinivas Pandruvada
Hi Eero, On Mon, 2018-07-30 at 11:33 +0300, Eero Tamminen wrote: > Hi, > > On 28.07.2018 17:14, Srinivas Pandruvada wrote: > > On Fri, 2018-07-27 at 22:34 -0700, Francisco Jerez wrote: > > > Srinivas Pandruvada writes: > > > > > > > Enable HWP boost on Skylake server and workstations. > > > > >

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-30 Thread Eero Tamminen
Hi Mel, On 28.07.2018 15:36, Mel Gorman wrote: On Fri, Jul 27, 2018 at 10:34:03PM -0700, Francisco Jerez wrote: Srinivas Pandruvada writes: Enable HWP boost on Skylake server and workstations. Please revert this series, it led to significant energy usage and graphics performance regressio

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-30 Thread Eero Tamminen
Hi, On 28.07.2018 17:14, Srinivas Pandruvada wrote: On Fri, 2018-07-27 at 22:34 -0700, Francisco Jerez wrote: Srinivas Pandruvada writes: Enable HWP boost on Skylake server and workstations. Please revert this series, it led to significant energy usage and graphics performance regressions

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-28 Thread Pandruvada, Srinivas
On Sat, 2018-07-28 at 13:23 -0700, Francisco Jerez wrote: > "Pandruvada, Srinivas" writes: > > > On Sat, 2018-07-28 at 07:14 -0700, Srinivas Pandruvada wrote: > > > On Fri, 2018-07-27 at 22:34 -0700, Francisco Jerez wrote: > > > > Srinivas Pandruvada > > > > writes: > > > > > > > > > Enable HWP

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-28 Thread Francisco Jerez
"Pandruvada, Srinivas" writes: > On Sat, 2018-07-28 at 07:14 -0700, Srinivas Pandruvada wrote: >> On Fri, 2018-07-27 at 22:34 -0700, Francisco Jerez wrote: >> > Srinivas Pandruvada writes: >> > >> > > Enable HWP boost on Skylake server and workstations. >> > > >> > >> > Please revert this ser

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-28 Thread Francisco Jerez
Srinivas Pandruvada writes: > On Fri, 2018-07-27 at 22:34 -0700, Francisco Jerez wrote: >> Srinivas Pandruvada writes: >> >> > Enable HWP boost on Skylake server and workstations. >> > >> >> Please revert this series, it led to significant energy usage and >> graphics performance regressions

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-28 Thread Francisco Jerez
Mel Gorman writes: > On Fri, Jul 27, 2018 at 10:34:03PM -0700, Francisco Jerez wrote: >> Srinivas Pandruvada writes: >> >> > Enable HWP boost on Skylake server and workstations. >> > >> >> Please revert this series, it led to significant energy usage and >> graphics performance regressions [1]

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-28 Thread Srinivas Pandruvada
On Fri, 2018-07-27 at 22:34 -0700, Francisco Jerez wrote: > Srinivas Pandruvada writes: > > > Enable HWP boost on Skylake server and workstations. > > > > Please revert this series, it led to significant energy usage and > graphics performance regressions [1]. Which SKX platform is targeted to

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-28 Thread Mel Gorman
On Fri, Jul 27, 2018 at 10:34:03PM -0700, Francisco Jerez wrote: > Srinivas Pandruvada writes: > > > Enable HWP boost on Skylake server and workstations. > > > > Please revert this series, it led to significant energy usage and > graphics performance regressions [1]. The reasons are roughly the

Re: [PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-07-27 Thread Francisco Jerez
Srinivas Pandruvada writes: > Enable HWP boost on Skylake server and workstations. > Please revert this series, it led to significant energy usage and graphics performance regressions [1]. The reasons are roughly the ones we discussed by e-mail off-list last April: This causes the intel_pstate

[PATCH 4/4] cpufreq: intel_pstate: enable boost for Skylake Xeon

2018-06-05 Thread Srinivas Pandruvada
Enable HWP boost on Skylake server and workstations. Reported-by: Mel Gorman Tested-by: Giovanni Gherdovich Signed-off-by: Srinivas Pandruvada --- drivers/cpufreq/intel_pstate.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/int