Re: [PATCH 4/4] mm: zero-seek shrinkers

2018-10-12 Thread Vlastimil Babka
On 10/9/18 8:47 PM, Johannes Weiner wrote: > The page cache and most shrinkable slab caches hold data that has been > read from disk, but there are some caches that only cache CPU work, > such as the dentry and inode caches of procfs and sysfs, as well as > the subset of radix tree nodes that

Re: [PATCH 4/4] mm: zero-seek shrinkers

2018-10-12 Thread Vlastimil Babka
On 10/9/18 8:47 PM, Johannes Weiner wrote: > The page cache and most shrinkable slab caches hold data that has been > read from disk, but there are some caches that only cache CPU work, > such as the dentry and inode caches of procfs and sysfs, as well as > the subset of radix tree nodes that

Re: [PATCH 4/4] mm: zero-seek shrinkers

2018-10-10 Thread Johannes Weiner
On Wed, Oct 10, 2018 at 01:03:50AM +, Rik van Riel wrote: > On Tue, 2018-10-09 at 14:47 -0400, Johannes Weiner wrote: > > > These workloads also deal with tens of thousands of open files and > > use > > /proc for introspection, which ends up growing the proc_inode_cache > > to > > absurdly

Re: [PATCH 4/4] mm: zero-seek shrinkers

2018-10-10 Thread Johannes Weiner
On Wed, Oct 10, 2018 at 01:03:50AM +, Rik van Riel wrote: > On Tue, 2018-10-09 at 14:47 -0400, Johannes Weiner wrote: > > > These workloads also deal with tens of thousands of open files and > > use > > /proc for introspection, which ends up growing the proc_inode_cache > > to > > absurdly

Re: [PATCH 4/4] mm: zero-seek shrinkers

2018-10-09 Thread Rik van Riel
On Tue, 2018-10-09 at 14:47 -0400, Johannes Weiner wrote: > These workloads also deal with tens of thousands of open files and > use > /proc for introspection, which ends up growing the proc_inode_cache > to > absurdly large sizes - again at the cost of valuable cache space, > which isn't a

Re: [PATCH 4/4] mm: zero-seek shrinkers

2018-10-09 Thread Rik van Riel
On Tue, 2018-10-09 at 14:47 -0400, Johannes Weiner wrote: > These workloads also deal with tens of thousands of open files and > use > /proc for introspection, which ends up growing the proc_inode_cache > to > absurdly large sizes - again at the cost of valuable cache space, > which isn't a

Re: [PATCH 4/4] mm: zero-seek shrinkers

2018-10-09 Thread Andrew Morton
On Tue, 9 Oct 2018 15:15:56 -0700 Andrew Morton wrote: > Seems sane, but I'm somewhat worried about unexpected effects on other > workloads. So I think I'll hold this over for 4.20. Or shouldn't I? Meant 4.21. But on reflection this is perhaps excessively cautious.

Re: [PATCH 4/4] mm: zero-seek shrinkers

2018-10-09 Thread Andrew Morton
On Tue, 9 Oct 2018 15:15:56 -0700 Andrew Morton wrote: > Seems sane, but I'm somewhat worried about unexpected effects on other > workloads. So I think I'll hold this over for 4.20. Or shouldn't I? Meant 4.21. But on reflection this is perhaps excessively cautious.

Re: [PATCH 4/4] mm: zero-seek shrinkers

2018-10-09 Thread Andrew Morton
On Tue, 9 Oct 2018 14:47:33 -0400 Johannes Weiner wrote: > The page cache and most shrinkable slab caches hold data that has been > read from disk, but there are some caches that only cache CPU work, > such as the dentry and inode caches of procfs and sysfs, as well as > the subset of radix

Re: [PATCH 4/4] mm: zero-seek shrinkers

2018-10-09 Thread Andrew Morton
On Tue, 9 Oct 2018 14:47:33 -0400 Johannes Weiner wrote: > The page cache and most shrinkable slab caches hold data that has been > read from disk, but there are some caches that only cache CPU work, > such as the dentry and inode caches of procfs and sysfs, as well as > the subset of radix

[PATCH 4/4] mm: zero-seek shrinkers

2018-10-09 Thread Johannes Weiner
The page cache and most shrinkable slab caches hold data that has been read from disk, but there are some caches that only cache CPU work, such as the dentry and inode caches of procfs and sysfs, as well as the subset of radix tree nodes that track non-resident page cache. Currently, all these

[PATCH 4/4] mm: zero-seek shrinkers

2018-10-09 Thread Johannes Weiner
The page cache and most shrinkable slab caches hold data that has been read from disk, but there are some caches that only cache CPU work, such as the dentry and inode caches of procfs and sysfs, as well as the subset of radix tree nodes that track non-resident page cache. Currently, all these