Re: [PATCH 4/4] mtd: rawnand: meson: only initialize the RB completion once

2019-04-19 Thread Miquel Raynal
Hi Martin, Martin Blumenstingl wrote on Thu, 18 Apr 2019 21:44:05 +0200: > Hi Liang, > > On Mon, Apr 15, 2019 at 8:04 AM Liang Yang wrote: > > > > > > On 2019/4/12 6:00, Martin Blumenstingl wrote: > > > Documentation/scheduler/completion.txt states: > > >Calling init_completion() on the

Re: [PATCH 4/4] mtd: rawnand: meson: only initialize the RB completion once

2019-04-18 Thread Liang Yang
Hi Martin, On 2019/4/19 3:44, Martin Blumenstingl wrote: Hi Liang, On Mon, Apr 15, 2019 at 8:04 AM Liang Yang wrote: On 2019/4/12 6:00, Martin Blumenstingl wrote: Documentation/scheduler/completion.txt states: Calling init_completion() on the same completion object twice is most

Re: [PATCH 4/4] mtd: rawnand: meson: only initialize the RB completion once

2019-04-18 Thread Martin Blumenstingl
Hi Liang, On Mon, Apr 15, 2019 at 8:04 AM Liang Yang wrote: > > > On 2019/4/12 6:00, Martin Blumenstingl wrote: > > Documentation/scheduler/completion.txt states: > >Calling init_completion() on the same completion object twice is > >most likely a bug as it re-initializes the queue to an

Re: [PATCH 4/4] mtd: rawnand: meson: only initialize the RB completion once

2019-04-15 Thread Liang Yang
On 2019/4/12 6:00, Martin Blumenstingl wrote: Documentation/scheduler/completion.txt states: Calling init_completion() on the same completion object twice is most likely a bug as it re-initializes the queue to an empty queue and enqueued tasks could get "lost" - use

[PATCH 4/4] mtd: rawnand: meson: only initialize the RB completion once

2019-04-11 Thread Martin Blumenstingl
Documentation/scheduler/completion.txt states: Calling init_completion() on the same completion object twice is most likely a bug as it re-initializes the queue to an empty queue and enqueued tasks could get "lost" - use reinit_completion() in that case, but be aware of other races.