Re: [PATCH 4/4] perf/x86/cqm: Support cqm/mbm only for perf events

2016-04-25 Thread Peter Zijlstra
On Mon, Apr 25, 2016 at 04:23:58PM +, Luck, Tony wrote: > >> Hence removing support for the parts which are broken rather than > >> pretending to support it and giving incorrect data. > > > > Uh what, how about attempt to fix it? > > No hope to do that by 4.6 release ... so I suggested to Vika

RE: [PATCH 4/4] perf/x86/cqm: Support cqm/mbm only for perf events

2016-04-25 Thread Luck, Tony
>> Hence removing support for the parts which are broken rather than >> pretending to support it and giving incorrect data. > > Uh what, how about attempt to fix it? No hope to do that by 4.6 release ... so I suggested to Vikas that it would be better to disable the feature now so users wouldn't

Re: [PATCH 4/4] perf/x86/cqm: Support cqm/mbm only for perf events

2016-04-25 Thread Peter Zijlstra
On Fri, Apr 22, 2016 at 05:27:21PM -0700, Vikas Shivappa wrote: > The cgroup support for cqm is broken. Instead of mapping RMID to a > cgroup currently its mapped to the task and then hence when task moves > cgroup we get incorrect count. > > Also the conflict handling code which is meant to handl

[PATCH 4/4] perf/x86/cqm: Support cqm/mbm only for perf events

2016-04-22 Thread Vikas Shivappa
The cgroup support for cqm is broken. Instead of mapping RMID to a cgroup currently its mapped to the task and then hence when task moves cgroup we get incorrect count. Also the conflict handling code which is meant to handle the case of co-existing cgroup and task events, is broken. It reports ve