Re: [PATCH 4/4] perf annotate: Introduce source_code to collect actual code

2017-02-23 Thread Ravi Bangoria
Hi Taeung, On Wednesday 22 February 2017 03:38 PM, Taeung Song wrote: > + INIT_LIST_HEAD(>src->code); > + > + while (!feof(file)) { > + int nr; > + char *c, *parsed_line; > + struct source_code *code; > + > + if (getline(, , file) < 0) { > +

Re: [PATCH 4/4] perf annotate: Introduce source_code to collect actual code

2017-02-23 Thread Ravi Bangoria
Hi Taeung, On Wednesday 22 February 2017 03:38 PM, Taeung Song wrote: > + INIT_LIST_HEAD(>src->code); > + > + while (!feof(file)) { > + int nr; > + char *c, *parsed_line; > + struct source_code *code; > + > + if (getline(, , file) < 0) { > +

Re: [PATCH 4/4] perf annotate: Introduce source_code to collect actual code

2017-02-22 Thread Taeung Song
On 02/22/2017 08:27 PM, Namhyung Kim wrote: On Wed, Feb 22, 2017 at 7:08 PM, Taeung Song wrote: The output of perf-annotate has a problem. It is so confusing that the output is mixed with both source code and assembly code. IMHO, we need readable annotate view based

Re: [PATCH 4/4] perf annotate: Introduce source_code to collect actual code

2017-02-22 Thread Taeung Song
On 02/22/2017 08:27 PM, Namhyung Kim wrote: On Wed, Feb 22, 2017 at 7:08 PM, Taeung Song wrote: The output of perf-annotate has a problem. It is so confusing that the output is mixed with both source code and assembly code. IMHO, we need readable annotate view based on source code, not mixed

Re: [PATCH 4/4] perf annotate: Introduce source_code to collect actual code

2017-02-22 Thread Namhyung Kim
On Wed, Feb 22, 2017 at 7:08 PM, Taeung Song wrote: > The output of perf-annotate has a problem. > It is so confusing that the output is mixed with > both source code and assembly code. > IMHO, we need readable annotate view based on source code, > not mixed view. (not

Re: [PATCH 4/4] perf annotate: Introduce source_code to collect actual code

2017-02-22 Thread Namhyung Kim
On Wed, Feb 22, 2017 at 7:08 PM, Taeung Song wrote: > The output of perf-annotate has a problem. > It is so confusing that the output is mixed with > both source code and assembly code. > IMHO, we need readable annotate view based on source code, > not mixed view. (not depending on 'objdump -S')

[PATCH 4/4] perf annotate: Introduce source_code to collect actual code

2017-02-22 Thread Taeung Song
The output of perf-annotate has a problem. It is so confusing that the output is mixed with both source code and assembly code. IMHO, we need readable annotate view based on source code, not mixed view. (not depending on 'objdump -S') And to do that, we can collect actual source code per

[PATCH 4/4] perf annotate: Introduce source_code to collect actual code

2017-02-22 Thread Taeung Song
The output of perf-annotate has a problem. It is so confusing that the output is mixed with both source code and assembly code. IMHO, we need readable annotate view based on source code, not mixed view. (not depending on 'objdump -S') And to do that, we can collect actual source code per