[PATCH 4/4] power_supply: bq24261 charger driver

2014-07-08 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC ---

[PATCH 4/4] power_supply: bq24261 charger driver

2014-07-08 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-07-03 Thread Sebastian Reichel
Hi, On Mon, Jun 30, 2014 at 03:25:55PM +0530, Jenny TC wrote: > This patch introduces BQ24261 charger driver. The driver makes use of power > supply charging driver to setup charging. So the driver does hardware > abstraction and handles h/w specific corner cases. The charging logic resides >

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-07-03 Thread Sebastian Reichel
Hi, On Mon, Jun 30, 2014 at 03:25:55PM +0530, Jenny TC wrote: This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with

[PATCH 4/4] power_supply: bq24261 charger driver

2014-06-30 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC ---

[PATCH 4/4] power_supply: bq24261 charger driver

2014-06-30 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC

[PATCH 4/4] power_supply: bq24261 charger driver

2014-06-19 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC ---

[PATCH 4/4] power_supply: bq24261 charger driver

2014-06-19 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-02-25 Thread Jenny Tc
On Fri, Feb 21, 2014 at 03:44:00PM +0100, Pavel Machek wrote: > Hi! > > > > > +static inline int bq24261_set_cv(struct bq24261_charger *chip, int cv) > > > > +{ > > > > + int bat_volt; > > > > + int ret; > > > > + u8 reg_val; > > > > + u8 vindpm_val = 0x0; > > > > + > > >

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-02-25 Thread Jenny Tc
On Fri, Feb 21, 2014 at 03:44:00PM +0100, Pavel Machek wrote: Hi! +static inline int bq24261_set_cv(struct bq24261_charger *chip, int cv) +{ + int bat_volt; + int ret; + u8 reg_val; + u8 vindpm_val = 0x0; + + /* + * Setting

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-02-21 Thread Pavel Machek
Hi! > > > +static inline int bq24261_set_cv(struct bq24261_charger *chip, int cv) > > > +{ > > > + int bat_volt; > > > + int ret; > > > + u8 reg_val; > > > + u8 vindpm_val = 0x0; > > > + > > > + /* > > > + * Setting VINDPM value as per the battery voltage > > > + * VBatt Vindpm

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-02-21 Thread Pavel Machek
Hi! +static inline int bq24261_set_cv(struct bq24261_charger *chip, int cv) +{ + int bat_volt; + int ret; + u8 reg_val; + u8 vindpm_val = 0x0; + + /* + * Setting VINDPM value as per the battery voltage + * VBatt Vindpm Register Setting + * 3.7v

[PATCH 4/4] power_supply: bq24261 charger driver

2014-02-19 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC ---

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-02-19 Thread Jenny Tc
On Tue, Feb 04, 2014 at 12:36:21PM +0100, Pavel Machek wrote: > > +#define BQ24261_MIN_CV 3500 > > +#define BQ24261_MAX_CV 4440 > > Other defines use uV as an unit :-(. uV is used if the value is read from psy class. For register configurations uses mV. Will change the name to reflect mV > > +

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-02-19 Thread Jenny Tc
On Tue, Feb 04, 2014 at 12:36:21PM +0100, Pavel Machek wrote: +#define BQ24261_MIN_CV 3500 +#define BQ24261_MAX_CV 4440 Other defines use uV as an unit :-(. uV is used if the value is read from psy class. For register configurations uses mV. Will change the name to reflect mV + /* If

[PATCH 4/4] power_supply: bq24261 charger driver

2014-02-19 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-02-04 Thread Pavel Machek
Hi! > +#define DEV_MANUFACTURER "TI" > +#define DEV_MANUFACTURER_NAME_SIZE 4 This is unneccessarily complicated for no reason. You copy "TI" to struct, just so that ou can return pointer to the field on get_property. What about simply returning "TI" from get_property, without defines and

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-02-04 Thread Pavel Machek
Hi! +#define DEV_MANUFACTURER TI +#define DEV_MANUFACTURER_NAME_SIZE 4 This is unneccessarily complicated for no reason. You copy TI to struct, just so that ou can return pointer to the field on get_property. What about simply returning TI from get_property, without defines and copying?

[PATCH 4/4] power_supply: bq24261 charger driver

2014-02-03 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC ---

[PATCH 4/4] power_supply: bq24261 charger driver

2014-02-03 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-30 Thread Jenny Tc
On Thu, Jan 30, 2014 at 06:01:54PM +0100, Pavel Machek wrote: > Hi! > > > diff --git a/drivers/power/Makefile b/drivers/power/Makefile > > index 77535fd..6d184c8 100644 > > --- a/drivers/power/Makefile > > +++ b/drivers/power/Makefile > > @@ -59,4 +59,5 @@ obj-$(CONFIG_CHARGER_BQ24735) +=

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-30 Thread Pavel Machek
Hi! > diff --git a/drivers/power/Makefile b/drivers/power/Makefile > index 77535fd..6d184c8 100644 > --- a/drivers/power/Makefile > +++ b/drivers/power/Makefile > @@ -59,4 +59,5 @@ obj-$(CONFIG_CHARGER_BQ24735) += bq24735-charger.o > obj-$(CONFIG_POWER_AVS) += avs/ >

[PATCH 4/4] power_supply: bq24261 charger driver

2014-01-30 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC ---

[PATCH 4/4] power_supply: bq24261 charger driver

2014-01-30 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-30 Thread Pavel Machek
Hi! diff --git a/drivers/power/Makefile b/drivers/power/Makefile index 77535fd..6d184c8 100644 --- a/drivers/power/Makefile +++ b/drivers/power/Makefile @@ -59,4 +59,5 @@ obj-$(CONFIG_CHARGER_BQ24735) += bq24735-charger.o obj-$(CONFIG_POWER_AVS) += avs/

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-30 Thread Jenny Tc
On Thu, Jan 30, 2014 at 06:01:54PM +0100, Pavel Machek wrote: Hi! diff --git a/drivers/power/Makefile b/drivers/power/Makefile index 77535fd..6d184c8 100644 --- a/drivers/power/Makefile +++ b/drivers/power/Makefile @@ -59,4 +59,5 @@ obj-$(CONFIG_CHARGER_BQ24735) +=

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-29 Thread Pavel Machek
On Wed 2014-01-29 18:53:34, Jenny Tc wrote: > On Tue, Jan 28, 2014 at 07:14:45AM -0700, Pavel Machek wrote: > > > +#define BQ24261_ICHRG_MASK (0x1F << 3) > > > +#define BQ24261_ICHRG_100ma (0x01 << 3) > > > +#define BQ24261_ICHRG_200ma (0x01 << 4) > > >

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-29 Thread Pavel Machek
On Wed 2014-01-29 18:53:34, Jenny Tc wrote: On Tue, Jan 28, 2014 at 07:14:45AM -0700, Pavel Machek wrote: +#define BQ24261_ICHRG_MASK (0x1F 3) +#define BQ24261_ICHRG_100ma (0x01 3) +#define BQ24261_ICHRG_200ma (0x01 4) +#define

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-28 Thread Jingoo Han
On Wednesday, January 29, 2014 10:24 PM, Jenny Tc wrote: > On Tue, Jan 28, 2014 at 07:14:45AM -0700, Pavel Machek wrote: > > > +#define BQ24261_ICHRG_MASK (0x1F << 3) > > > +#define BQ24261_ICHRG_100ma (0x01 << 3) > > > +#define BQ24261_ICHRG_200ma (0x01 <<

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-28 Thread Jenny Tc
On Tue, Jan 28, 2014 at 07:14:45AM -0700, Pavel Machek wrote: > > +#define BQ24261_ICHRG_MASK (0x1F << 3) > > +#define BQ24261_ICHRG_100ma(0x01 << 3) > > +#define BQ24261_ICHRG_200ma(0x01 << 4) > > +#define BQ24261_ICHRG_400ma(0x01 << 5) > >

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-28 Thread Pavel Machek
Hi! > +#define BQ24261_ICHRG_MASK (0x1F << 3) > +#define BQ24261_ICHRG_100ma (0x01 << 3) > +#define BQ24261_ICHRG_200ma (0x01 << 4) > +#define BQ24261_ICHRG_400ma (0x01 << 5) > +#define BQ24261_ICHRG_800ma (0x01 << 6) > +#define BQ24261_ICHRG_1600ma

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-28 Thread Pavel Machek
Hi! +#define BQ24261_ICHRG_MASK (0x1F 3) +#define BQ24261_ICHRG_100ma (0x01 3) +#define BQ24261_ICHRG_200ma (0x01 4) +#define BQ24261_ICHRG_400ma (0x01 5) +#define BQ24261_ICHRG_800ma (0x01 6) +#define BQ24261_ICHRG_1600ma (0x01 7)

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-28 Thread Jenny Tc
On Tue, Jan 28, 2014 at 07:14:45AM -0700, Pavel Machek wrote: +#define BQ24261_ICHRG_MASK (0x1F 3) +#define BQ24261_ICHRG_100ma(0x01 3) +#define BQ24261_ICHRG_200ma(0x01 4) +#define BQ24261_ICHRG_400ma(0x01 5) +#define

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-28 Thread Jingoo Han
On Wednesday, January 29, 2014 10:24 PM, Jenny Tc wrote: On Tue, Jan 28, 2014 at 07:14:45AM -0700, Pavel Machek wrote: +#define BQ24261_ICHRG_MASK (0x1F 3) +#define BQ24261_ICHRG_100ma (0x01 3) +#define BQ24261_ICHRG_200ma (0x01 4) +#define

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-25 Thread Pavel Machek
Hi! > +++ b/drivers/power/Makefile > @@ -59,4 +59,5 @@ obj-$(CONFIG_CHARGER_BQ24735) += bq24735-charger.o > obj-$(CONFIG_POWER_AVS) += avs/ > obj-$(CONFIG_CHARGER_SMB347) += smb347-charger.o > obj-$(CONFIG_CHARGER_TPS65090) += tps65090-charger.o >

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-25 Thread Pavel Machek
Hi! +++ b/drivers/power/Makefile @@ -59,4 +59,5 @@ obj-$(CONFIG_CHARGER_BQ24735) += bq24735-charger.o obj-$(CONFIG_POWER_AVS) += avs/ obj-$(CONFIG_CHARGER_SMB347) += smb347-charger.o obj-$(CONFIG_CHARGER_TPS65090) += tps65090-charger.o

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-23 Thread Jingoo Han
On Thursday, January 23, 2014 2:20 AM, Jenny TC wrote: > > This patch introduces BQ24261 charger driver. The driver makes use of power > supply charging driver to setup charging. So the driver does hardware > abstraction and handles h/w specific corner cases. The charging logic resides > with

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-23 Thread Jingoo Han
On Thursday, January 23, 2014 2:20 AM, Jenny TC wrote: This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power

[PATCH 4/4] power_supply: bq24261 charger driver

2014-01-22 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC ---

[PATCH 4/4] power_supply: bq24261 charger driver

2014-01-22 Thread Jenny TC
This patch introduces BQ24261 charger driver. The driver makes use of power supply charging driver to setup charging. So the driver does hardware abstraction and handles h/w specific corner cases. The charging logic resides with power supply charging driver Signed-off-by: Jenny TC