Re: [PATCH 4/5] media/ivtv: Reduce default FIFO priority

2019-08-07 Thread Hans Verkuil
On 8/2/19 10:58 AM, Peter Zijlstra wrote: > On Thu, Aug 01, 2019 at 02:38:06PM +0200, Peter Zijlstra wrote: >> If the consumer of the data are RT tasks as well (I hadn't expected that >> from a TV capture device) then I'd propose to use FIFO-50 as default. >> >> The thing is, the moment you're

Re: [PATCH 4/5] media/ivtv: Reduce default FIFO priority

2019-08-02 Thread Peter Zijlstra
On Thu, Aug 01, 2019 at 02:38:06PM +0200, Peter Zijlstra wrote: > If the consumer of the data are RT tasks as well (I hadn't expected that > from a TV capture device) then I'd propose to use FIFO-50 as default. > > The thing is, the moment you're doing actual proper RT, the admin needs > to

Re: [PATCH 4/5] media/ivtv: Reduce default FIFO priority

2019-08-01 Thread Peter Zijlstra
On Thu, Aug 01, 2019 at 08:24:22AM -0400, Andy Walls wrote: > Hi Peter: > > On Thu, 2019-08-01 at 13:13 +0200, Peter Zijlstra wrote: > > The ivtv driver creates a FIFO-99 thread by default, reduce this to > > FIFO-1. > > > > FIFO-99 is the very highest priority available to SCHED_FIFO and > > it

Re: [PATCH 4/5] media/ivtv: Reduce default FIFO priority

2019-08-01 Thread Andy Walls
Hi Peter: On Thu, 2019-08-01 at 13:13 +0200, Peter Zijlstra wrote: > The ivtv driver creates a FIFO-99 thread by default, reduce this to > FIFO-1. > > FIFO-99 is the very highest priority available to SCHED_FIFO and > it not a suitable default; it would indicate the ivtv work is the > most

[PATCH 4/5] media/ivtv: Reduce default FIFO priority

2019-08-01 Thread Peter Zijlstra
The ivtv driver creates a FIFO-99 thread by default, reduce this to FIFO-1. FIFO-99 is the very highest priority available to SCHED_FIFO and it not a suitable default; it would indicate the ivtv work is the most important work on the machine. FIFO-1 gets it above all OTHER tasks, which seems