Re: [PATCH 4/5] mm, compaction: always update cached scanner positions

2014-11-14 Thread Vlastimil Babka
On 11/04/2014 01:28 AM, Joonsoo Kim wrote: > On Fri, Oct 31, 2014 at 04:53:44PM +0100, Vlastimil Babka wrote: >> On 10/28/2014 08:08 AM, Joonsoo Kim wrote: >> >> OK, so you don't find a problem with how this patch changes >> migration scanner caching, just the free scanner, right? >> So how about

Re: [PATCH 4/5] mm, compaction: always update cached scanner positions

2014-11-14 Thread Vlastimil Babka
On 11/04/2014 01:28 AM, Joonsoo Kim wrote: On Fri, Oct 31, 2014 at 04:53:44PM +0100, Vlastimil Babka wrote: On 10/28/2014 08:08 AM, Joonsoo Kim wrote: OK, so you don't find a problem with how this patch changes migration scanner caching, just the free scanner, right? So how about making

Re: [PATCH 4/5] mm, compaction: always update cached scanner positions

2014-11-03 Thread Joonsoo Kim
On Fri, Oct 31, 2014 at 04:53:44PM +0100, Vlastimil Babka wrote: > On 10/28/2014 08:08 AM, Joonsoo Kim wrote: > >> > >>>And, I guess that pageblock skip feature effectively disable pageblock > >>>rescanning if there is no freepage during rescan. > >> > >>If there's no freepage during rescan, then

Re: [PATCH 4/5] mm, compaction: always update cached scanner positions

2014-11-03 Thread Joonsoo Kim
On Fri, Oct 31, 2014 at 04:53:44PM +0100, Vlastimil Babka wrote: On 10/28/2014 08:08 AM, Joonsoo Kim wrote: And, I guess that pageblock skip feature effectively disable pageblock rescanning if there is no freepage during rescan. If there's no freepage during rescan, then the cached

Re: [PATCH 4/5] mm, compaction: always update cached scanner positions

2014-10-31 Thread Vlastimil Babka
On 10/28/2014 08:08 AM, Joonsoo Kim wrote: And, I guess that pageblock skip feature effectively disable pageblock rescanning if there is no freepage during rescan. If there's no freepage during rescan, then the cached free_pfn also won't be pointed to the pageblock anymore. Regardless of

Re: [PATCH 4/5] mm, compaction: always update cached scanner positions

2014-10-31 Thread Vlastimil Babka
On 10/28/2014 08:08 AM, Joonsoo Kim wrote: And, I guess that pageblock skip feature effectively disable pageblock rescanning if there is no freepage during rescan. If there's no freepage during rescan, then the cached free_pfn also won't be pointed to the pageblock anymore. Regardless of

Re: [PATCH 4/5] mm, compaction: always update cached scanner positions

2014-10-28 Thread Joonsoo Kim
On Mon, Oct 27, 2014 at 10:39:01AM +0100, Vlastimil Babka wrote: > On 10/27/2014 08:35 AM, Joonsoo Kim wrote:> On Tue, Oct 07, 2014 at > 05:33:38PM +0200, Vlastimil Babka wrote: > > Hmm... I'm not sure that this patch is good thing. > > > > In asynchronous compaction, compaction could be easily

Re: [PATCH 4/5] mm, compaction: always update cached scanner positions

2014-10-28 Thread Joonsoo Kim
On Mon, Oct 27, 2014 at 10:39:01AM +0100, Vlastimil Babka wrote: On 10/27/2014 08:35 AM, Joonsoo Kim wrote: On Tue, Oct 07, 2014 at 05:33:38PM +0200, Vlastimil Babka wrote: Hmm... I'm not sure that this patch is good thing. In asynchronous compaction, compaction could be easily failed and

Re: [PATCH 4/5] mm, compaction: always update cached scanner positions

2014-10-27 Thread Vlastimil Babka
On 10/27/2014 08:35 AM, Joonsoo Kim wrote:> On Tue, Oct 07, 2014 at 05:33:38PM +0200, Vlastimil Babka wrote: >> Compaction caches the migration and free scanner positions between compaction >> invocations, so that the whole zone gets eventually scanned and there is no >> bias towards the initial

Re: [PATCH 4/5] mm, compaction: always update cached scanner positions

2014-10-27 Thread Joonsoo Kim
On Tue, Oct 07, 2014 at 05:33:38PM +0200, Vlastimil Babka wrote: > Compaction caches the migration and free scanner positions between compaction > invocations, so that the whole zone gets eventually scanned and there is no > bias towards the initial scanner positions at the beginning/end of the

Re: [PATCH 4/5] mm, compaction: always update cached scanner positions

2014-10-27 Thread Joonsoo Kim
On Tue, Oct 07, 2014 at 05:33:38PM +0200, Vlastimil Babka wrote: Compaction caches the migration and free scanner positions between compaction invocations, so that the whole zone gets eventually scanned and there is no bias towards the initial scanner positions at the beginning/end of the zone.

Re: [PATCH 4/5] mm, compaction: always update cached scanner positions

2014-10-27 Thread Vlastimil Babka
On 10/27/2014 08:35 AM, Joonsoo Kim wrote: On Tue, Oct 07, 2014 at 05:33:38PM +0200, Vlastimil Babka wrote: Compaction caches the migration and free scanner positions between compaction invocations, so that the whole zone gets eventually scanned and there is no bias towards the initial scanner

Re: [PATCH 4/5] mm, compaction: always update cached scanner positions

2014-10-20 Thread Rik van Riel
On 10/07/2014 11:33 AM, Vlastimil Babka wrote: Compaction caches the migration and free scanner positions between compaction invocations, so that the whole zone gets eventually scanned and there is no bias towards the initial scanner positions at the beginning/end of the zone. The cached

Re: [PATCH 4/5] mm, compaction: always update cached scanner positions

2014-10-20 Thread Rik van Riel
On 10/07/2014 11:33 AM, Vlastimil Babka wrote: Compaction caches the migration and free scanner positions between compaction invocations, so that the whole zone gets eventually scanned and there is no bias towards the initial scanner positions at the beginning/end of the zone. The cached

[PATCH 4/5] mm, compaction: always update cached scanner positions

2014-10-07 Thread Vlastimil Babka
Compaction caches the migration and free scanner positions between compaction invocations, so that the whole zone gets eventually scanned and there is no bias towards the initial scanner positions at the beginning/end of the zone. The cached positions are continuously updated as scanners progress

[PATCH 4/5] mm, compaction: always update cached scanner positions

2014-10-07 Thread Vlastimil Babka
Compaction caches the migration and free scanner positions between compaction invocations, so that the whole zone gets eventually scanned and there is no bias towards the initial scanner positions at the beginning/end of the zone. The cached positions are continuously updated as scanners progress