Re: [PATCH 4/5] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Alan Stern
On Thu, 28 Feb 2013, Lan Tianyu wrote: > Hi Alan: > Further thinking, the device should be disconnected since the port > can't be resumed and the device will not work normally. Something like > following. Does this make sense? > --- > diff --git a/drivers/usb/core/hub.c

RE: [PATCH 4/5] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Li, Fei
uansheng > Subject: Re: [PATCH 4/5] usb: call pm_runtime_put_sync in > pm_runtime_get_sync failed case > > On 2013年02月28日 15:57, Li Fei wrote: > > > > Even in failed case of pm_runtime_get_sync, the usage_count > > is incremented. In order to keep the usage_count wit

Re: [PATCH 4/5] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Lan Tianyu
On 2013年02月28日 15:57, Li Fei wrote: > > Even in failed case of pm_runtime_get_sync, the usage_count > is incremented. In order to keep the usage_count with correct > value and runtime power management to behave correctly, call > pm_runtime_put(_sync) in such case. Hi Fei: It's not

Re: [PATCH 4/5] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Lan Tianyu
On 2013年02月28日 15:57, Li Fei wrote: Even in failed case of pm_runtime_get_sync, the usage_count is incremented. In order to keep the usage_count with correct value and runtime power management to behave correctly, call pm_runtime_put(_sync) in such case. Hi Fei: It's not necessary.

RE: [PATCH 4/5] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Li, Fei
: [PATCH 4/5] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case On 2013年02月28日 15:57, Li Fei wrote: Even in failed case of pm_runtime_get_sync, the usage_count is incremented. In order to keep the usage_count with correct value and runtime power management to behave correctly

Re: [PATCH 4/5] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Alan Stern
On Thu, 28 Feb 2013, Lan Tianyu wrote: Hi Alan: Further thinking, the device should be disconnected since the port can't be resumed and the device will not work normally. Something like following. Does this make sense? --- diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c

[PATCH 4/5] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-27 Thread Li Fei
Even in failed case of pm_runtime_get_sync, the usage_count is incremented. In order to keep the usage_count with correct value and runtime power management to behave correctly, call pm_runtime_put(_sync) in such case. Signed-off-by Liu Chuansheng Signed-off-by: Li Fei ---

[PATCH 4/5] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-27 Thread Li Fei
Even in failed case of pm_runtime_get_sync, the usage_count is incremented. In order to keep the usage_count with correct value and runtime power management to behave correctly, call pm_runtime_put(_sync) in such case. Signed-off-by Liu Chuansheng chuansheng@intel.com Signed-off-by: Li Fei