Re: [PATCH 4/6] ACPI: LPSS: Fix ->suspend_late callbacks handling

2019-06-30 Thread Rafael J. Wysocki
On Sun, Jun 30, 2019 at 12:02 AM Rafael J. Wysocki wrote: > > On Sat, Jun 29, 2019 at 1:34 PM Hans de Goede wrote: > > > > Hi Rafael, > > > > On 29-06-19 11:50, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > If the resume_from_noirq flag is set in dev_desc, the

Re: [PATCH 4/6] ACPI: LPSS: Fix ->suspend_late callbacks handling

2019-06-29 Thread Rafael J. Wysocki
On Sat, Jun 29, 2019 at 1:34 PM Hans de Goede wrote: > > Hi Rafael, > > On 29-06-19 11:50, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > If the resume_from_noirq flag is set in dev_desc, the ->suspend_late > > callback provided by the device driver will be invoked at the "noirq" >

Re: [PATCH 4/6] ACPI: LPSS: Fix ->suspend_late callbacks handling

2019-06-29 Thread Hans de Goede
Hi Rafael, On 29-06-19 11:50, Rafael J. Wysocki wrote: From: Rafael J. Wysocki If the resume_from_noirq flag is set in dev_desc, the ->suspend_late callback provided by the device driver will be invoked at the "noirq" stage of system suspend, via acpi_lpss_do_suspend_late(), which is

[PATCH 4/6] ACPI: LPSS: Fix ->suspend_late callbacks handling

2019-06-29 Thread Rafael J. Wysocki
From: Rafael J. Wysocki If the resume_from_noirq flag is set in dev_desc, the ->suspend_late callback provided by the device driver will be invoked at the "noirq" stage of system suspend, via acpi_lpss_do_suspend_late(), which is incorrect. To fix that, drop acpi_lpss_do_suspend_late() and