Re: [PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally

2015-03-11 Thread Lorenzo Stoakes
On 11 March 2015 at 09:37, Sudip Mukherjee wrote: > in your previous patch 3/6 you made it static now you are again > removing the static keyword. may i ask why you changed it in 3/6 if you > again change it back to original in this patch? There's no good reason, it's just a mistake :) I'll fix

Re: [PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally

2015-03-11 Thread Sudip Mukherjee
On Wed, Mar 11, 2015 at 01:28:43AM +, Lorenzo Stoakes wrote: > > diff --git a/drivers/staging/sm750fb/sm750_accel.c > b/drivers/staging/sm750fb/sm750_accel.c > index 4aa763b..6521c3b 100644 > --- a/drivers/staging/sm750fb/sm750_accel.c > +++ b/drivers/staging/sm750fb/sm750_accel.c > @@ -92,7

Re: [PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally

2015-03-11 Thread Dan Carpenter
On Wed, Mar 11, 2015 at 01:28:43AM +, Lorenzo Stoakes wrote: > This patch adds a reference to hw712_fillrect which is not used elsewhere in > the driver, > but appears to be an alternative to the hw_fillrect method. This patch fixes > the following sparse warning:- > >

Re: [PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally

2015-03-11 Thread Sudip Mukherjee
On Wed, Mar 11, 2015 at 01:28:43AM +, Lorenzo Stoakes wrote: diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 4aa763b..6521c3b 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -92,7 +92,7

Re: [PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally

2015-03-11 Thread Lorenzo Stoakes
On 11 March 2015 at 09:37, Sudip Mukherjee sudipm.mukher...@gmail.com wrote: in your previous patch 3/6 you made it static now you are again removing the static keyword. may i ask why you changed it in 3/6 if you again change it back to original in this patch? There's no good reason, it's just

Re: [PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally

2015-03-11 Thread Dan Carpenter
On Wed, Mar 11, 2015 at 01:28:43AM +, Lorenzo Stoakes wrote: This patch adds a reference to hw712_fillrect which is not used elsewhere in the driver, but appears to be an alternative to the hw_fillrect method. This patch fixes the following sparse warning:-

[PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally

2015-03-10 Thread Lorenzo Stoakes
This patch adds a reference to hw712_fillrect which is not used elsewhere in the driver, but appears to be an alternative to the hw_fillrect method. This patch fixes the following sparse warning:- drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect' was not declared.

[PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally

2015-03-10 Thread Lorenzo Stoakes
This patch adds a reference to hw712_fillrect which is not used elsewhere in the driver, but appears to be an alternative to the hw_fillrect method. This patch fixes the following sparse warning:- drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect' was not declared.