Re: [PATCH 4/6] unicore32: Add common clock support

2012-09-07 Thread Mike Turquette
Quoting Thierry Reding (2012-09-02 03:21:11) > diff --git a/arch/unicore32/kernel/clock.c b/arch/unicore32/kernel/clock.c > +struct clk_uc { > + struct clk_hw hw; > }; This looks ugly. Normally register addresses, masks and the like would go here. Instead you duplicate some functions

Re: [PATCH 4/6] unicore32: Add common clock support

2012-09-07 Thread Thierry Reding
On Thu, Sep 06, 2012 at 04:42:06PM +0800, guanxue...@mprc.pku.edu.cn wrote: > > This commit adds support for the common clock framework to the Unicore32 > > architecture. > > > > Signed-off-by: Thierry Reding > > This patch can't work. > Could you disintegrate it into several small patches, so I

Re: [PATCH 4/6] unicore32: Add common clock support

2012-09-07 Thread Thierry Reding
On Thu, Sep 06, 2012 at 04:42:06PM +0800, guanxue...@mprc.pku.edu.cn wrote: This commit adds support for the common clock framework to the Unicore32 architecture. Signed-off-by: Thierry Reding thierry.red...@avionic-design.de This patch can't work. Could you disintegrate it into

Re: [PATCH 4/6] unicore32: Add common clock support

2012-09-07 Thread Mike Turquette
Quoting Thierry Reding (2012-09-02 03:21:11) diff --git a/arch/unicore32/kernel/clock.c b/arch/unicore32/kernel/clock.c snip +struct clk_uc { + struct clk_hw hw; }; This looks ugly. Normally register addresses, masks and the like would go here. Instead you duplicate some functions

Re: [PATCH 4/6] unicore32: Add common clock support

2012-09-06 Thread guanxuetao
> This commit adds support for the common clock framework to the Unicore32 > architecture. > > Signed-off-by: Thierry Reding This patch can't work. Could you disintegrate it into several small patches, so I could check it out. Thanks, Guan Xuetao > --- > arch/unicore32/Kconfig |

Re: [PATCH 4/6] unicore32: Add common clock support

2012-09-06 Thread guanxuetao
This commit adds support for the common clock framework to the Unicore32 architecture. Signed-off-by: Thierry Reding thierry.red...@avionic-design.de This patch can't work. Could you disintegrate it into several small patches, so I could check it out. Thanks, Guan Xuetao ---

[PATCH 4/6] unicore32: Add common clock support

2012-09-02 Thread Thierry Reding
This commit adds support for the common clock framework to the Unicore32 architecture. Signed-off-by: Thierry Reding --- arch/unicore32/Kconfig | 1 + arch/unicore32/include/asm/clkdev.h | 26 ++ arch/unicore32/kernel/clock.c | 560 3

[PATCH 4/6] unicore32: Add common clock support

2012-09-02 Thread Thierry Reding
This commit adds support for the common clock framework to the Unicore32 architecture. Signed-off-by: Thierry Reding thierry.red...@avionic-design.de --- arch/unicore32/Kconfig | 1 + arch/unicore32/include/asm/clkdev.h | 26 ++ arch/unicore32/kernel/clock.c | 560