Re: [PATCH 4/7] cgroup: update and fix parsing of "cgroup.subtree_control"

2014-05-13 Thread Tejun Heo
On Tue, May 13, 2014 at 11:51:51AM +0800, Li Zefan wrote: > > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > > index 35daf89..b81e7c0 100644 > > --- a/kernel/cgroup.c > > +++ b/kernel/cgroup.c > > @@ -2542,11 +2542,13 @@ static int cgroup_subtree_control_write(struct > > cgroup_subsys_state *dum

Re: [PATCH 4/7] cgroup: update and fix parsing of "cgroup.subtree_control"

2014-05-12 Thread Li Zefan
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c > index 35daf89..b81e7c0 100644 > --- a/kernel/cgroup.c > +++ b/kernel/cgroup.c > @@ -2542,11 +2542,13 @@ static int cgroup_subtree_control_write(struct > cgroup_subsys_state *dummy_css, > int ssid, ret; > > /* > - * Parse input -

[PATCH 4/7] cgroup: update and fix parsing of "cgroup.subtree_control"

2014-05-09 Thread Tejun Heo
I was confused that strsep() was equivalent to strtok_r() in skipping over consecutive delimiters. strsep() just splits at the first occurrence of one of the delimiters which makes the parsing very inflexible, which makes allowing multiple whitespace chars as delimters kinda moot. Let's just be c