Re: [PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

On Fri, May 25, 2018 at 11:24:58AM +0100, Mark Brown wrote: > On Fri, May 25, 2018 at 08:54:30AM +0300, Matti Vaittinen wrote: > > On Thu, May 24, 2018 at 06:57:21PM +0100, Mark Brown wrote: > > > > You can look at the regulators node within the parent device, you know > > > that in Linux the

Re: [PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

On Fri, May 25, 2018 at 11:24:58AM +0100, Mark Brown wrote: > On Fri, May 25, 2018 at 08:54:30AM +0300, Matti Vaittinen wrote: > > On Thu, May 24, 2018 at 06:57:21PM +0100, Mark Brown wrote: > > > > You can look at the regulators node within the parent device, you know > > > that in Linux the

Re: [PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

On Fri, May 25, 2018 at 08:54:30AM +0300, Matti Vaittinen wrote: > On Thu, May 24, 2018 at 06:57:21PM +0100, Mark Brown wrote: > > You can look at the regulators node within the parent device, you know > > that in Linux the parent device will be the MFD. > So I should parse the device-tree in

Re: [PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

On Fri, May 25, 2018 at 08:54:30AM +0300, Matti Vaittinen wrote: > On Thu, May 24, 2018 at 06:57:21PM +0100, Mark Brown wrote: > > You can look at the regulators node within the parent device, you know > > that in Linux the parent device will be the MFD. > So I should parse the device-tree in

Re: [PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

On Thu, May 24, 2018 at 06:57:21PM +0100, Mark Brown wrote: > On Thu, May 24, 2018 at 05:30:57PM +, Vaittinen, Matti wrote: > > > > On Thu, May 24, 2018 at 08:57:52AM +0300, Matti Vaittinen wrote: > > > > > > > +Required properties: > > > > + - compatible: should be "rohm,bd71837-pmic". > > >

Re: [PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

On Thu, May 24, 2018 at 06:57:21PM +0100, Mark Brown wrote: > On Thu, May 24, 2018 at 05:30:57PM +, Vaittinen, Matti wrote: > > > > On Thu, May 24, 2018 at 08:57:52AM +0300, Matti Vaittinen wrote: > > > > > > > +Required properties: > > > > + - compatible: should be "rohm,bd71837-pmic". > > >

Re: [PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

On Thu, May 24, 2018 at 05:30:57PM +, Vaittinen, Matti wrote: > > > On Thu, May 24, 2018 at 08:57:52AM +0300, Matti Vaittinen wrote: > > > > > +Required properties: > > > + - compatible: should be "rohm,bd71837-pmic". > > > + - regulator-name: should be "buck1", ..., "buck8" and "ldo1", ...,

Re: [PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

On Thu, May 24, 2018 at 05:30:57PM +, Vaittinen, Matti wrote: > > > On Thu, May 24, 2018 at 08:57:52AM +0300, Matti Vaittinen wrote: > > > > > +Required properties: > > > + - compatible: should be "rohm,bd71837-pmic". > > > + - regulator-name: should be "buck1", ..., "buck8" and "ldo1", ...,

RE: [PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

Hello Mark, First of all, thank you for taking your time to check the patches. I do appreciate it. I find reading patches hard myself. > From: Mark Brown [broo...@kernel.org] > Sent: Thursday, May 24, 2018 5:01 PM > > > On Thu, May 24, 2018 at 08:57:52AM +0300, Matti Vaittinen wrote: > > >

RE: [PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

Hello Mark, First of all, thank you for taking your time to check the patches. I do appreciate it. I find reading patches hard myself. > From: Mark Brown [broo...@kernel.org] > Sent: Thursday, May 24, 2018 5:01 PM > > > On Thu, May 24, 2018 at 08:57:52AM +0300, Matti Vaittinen wrote: > > >

Re: [PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

On Thu, May 24, 2018 at 08:57:52AM +0300, Matti Vaittinen wrote: > +Required properties: > + - compatible: should be "rohm,bd71837-pmic". > + - regulator-name: should be "buck1", ..., "buck8" and "ldo1", ..., "ldo7" The MFD is for a single device, there should be no need for compatibles on

Re: [PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

On Thu, May 24, 2018 at 08:57:52AM +0300, Matti Vaittinen wrote: > +Required properties: > + - compatible: should be "rohm,bd71837-pmic". > + - regulator-name: should be "buck1", ..., "buck8" and "ldo1", ..., "ldo7" The MFD is for a single device, there should be no need for compatibles on

[PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

Document devicetree bindings for ROHM BD71837 PMIC regulators. Signed-off-by: Matti Vaittinen --- .../bindings/regulator/rohm,bd71837-regulator.txt | 124 + 1 file changed, 124 insertions(+) create mode 100644

[PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

Document devicetree bindings for ROHM BD71837 PMIC regulators. Signed-off-by: Matti Vaittinen --- .../bindings/regulator/rohm,bd71837-regulator.txt | 124 + 1 file changed, 124 insertions(+) create mode 100644