Re: [PATCH 44/53] Input: atmel_mxt_ts - Verify Information Block checksum on probe

2013-06-10 Thread Nick Dyer
Yufeng Shen wrote: >> + dev_info(>dev, >> +"Family: %u Variant: %u Firmware V%u.%u.%02X Objects: %u\n", >> +info->family_id, info->variant_id, info->version >> 4, >> +info->version & 0xf, info->build, info->object_num); >> + > > Use

Re: [PATCH 44/53] Input: atmel_mxt_ts - Verify Information Block checksum on probe

2013-06-10 Thread Nick Dyer
Yufeng Shen wrote: + dev_info(client-dev, +Family: %u Variant: %u Firmware V%u.%u.%02X Objects: %u\n, +info-family_id, info-variant_id, info-version 4, +info-version 0xf, info-build, info-object_num); + Use data-info-XXX here, info

Re: [PATCH 44/53] Input: atmel_mxt_ts - Verify Information Block checksum on probe

2013-06-07 Thread Yufeng Shen
On Wed, Jun 5, 2013 at 1:37 PM, Nick Dyer wrote: > By reading the information block and the object table into a contiguous region > of memory, we can verify the checksum at probe time. This means we verify that > we are indeed talking to a chip that supports object protocol correctly. We > also

Re: [PATCH 44/53] Input: atmel_mxt_ts - Verify Information Block checksum on probe

2013-06-07 Thread Yufeng Shen
On Wed, Jun 5, 2013 at 1:37 PM, Nick Dyer nick.d...@itdev.co.uk wrote: By reading the information block and the object table into a contiguous region of memory, we can verify the checksum at probe time. This means we verify that we are indeed talking to a chip that supports object protocol

[PATCH 44/53] Input: atmel_mxt_ts - Verify Information Block checksum on probe

2013-06-05 Thread Nick Dyer
By reading the information block and the object table into a contiguous region of memory, we can verify the checksum at probe time. This means we verify that we are indeed talking to a chip that supports object protocol correctly. We also detect I2C comms problems much earlier, resulting in easier

[PATCH 44/53] Input: atmel_mxt_ts - Verify Information Block checksum on probe

2013-06-05 Thread Nick Dyer
By reading the information block and the object table into a contiguous region of memory, we can verify the checksum at probe time. This means we verify that we are indeed talking to a chip that supports object protocol correctly. We also detect I2C comms problems much earlier, resulting in easier