Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-15 Thread Palmer Dabbelt
On Thu, 11 Oct 2018 05:18:20 PDT (-0700), sba...@raithlin.com wrote: Palmer I don't really know anything about this, but you're welcome to add a Reviewed-by: Palmer Dabbelt Thanks. I think it would be good to get someone who's familiar with linux/mm to take a look. if you think

Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-15 Thread Palmer Dabbelt
On Thu, 11 Oct 2018 05:18:20 PDT (-0700), sba...@raithlin.com wrote: Palmer I don't really know anything about this, but you're welcome to add a Reviewed-by: Palmer Dabbelt Thanks. I think it would be good to get someone who's familiar with linux/mm to take a look. if you think

Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-11 Thread Logan Gunthorpe
On 2018-10-11 12:45 p.m., Logan Gunthorpe wrote: > Ok, I spoke too soon... > > Having this define next to the struct page definition works great for > riscv. However, making that happen in arm64 seems to be a nightmare. The > include chain in arm64 is tangled up so much that including mm_types

Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-11 Thread Logan Gunthorpe
On 2018-10-11 12:45 p.m., Logan Gunthorpe wrote: > Ok, I spoke too soon... > > Having this define next to the struct page definition works great for > riscv. However, making that happen in arm64 seems to be a nightmare. The > include chain in arm64 is tangled up so much that including mm_types

Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-11 Thread Logan Gunthorpe
On 2018-10-11 10:24 a.m., Logan Gunthorpe wrote: > > > On 2018-10-11 7:37 a.m., Christoph Hellwig wrote: >>> +/* >>> + * Log2 of the upper bound of the size of a struct page. Used for sizing >>> + * the vmemmap region only, does not affect actual memory footprint. >>> + * We don't use

Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-11 Thread Logan Gunthorpe
On 2018-10-11 10:24 a.m., Logan Gunthorpe wrote: > > > On 2018-10-11 7:37 a.m., Christoph Hellwig wrote: >>> +/* >>> + * Log2 of the upper bound of the size of a struct page. Used for sizing >>> + * the vmemmap region only, does not affect actual memory footprint. >>> + * We don't use

Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-11 Thread Logan Gunthorpe
On 2018-10-11 10:24 a.m., Logan Gunthorpe wrote: > On 2018-10-11 7:37 a.m., Christoph Hellwig wrote: >>> +/* >>> + * Log2 of the upper bound of the size of a struct page. Used for sizing >>> + * the vmemmap region only, does not affect actual memory footprint. >>> + * We don't use sizeof(struct

Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-11 Thread Logan Gunthorpe
On 2018-10-11 10:24 a.m., Logan Gunthorpe wrote: > On 2018-10-11 7:37 a.m., Christoph Hellwig wrote: >>> +/* >>> + * Log2 of the upper bound of the size of a struct page. Used for sizing >>> + * the vmemmap region only, does not affect actual memory footprint. >>> + * We don't use sizeof(struct

Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-11 Thread Logan Gunthorpe
On 2018-10-11 7:37 a.m., Christoph Hellwig wrote: >> +/* >> + * Log2 of the upper bound of the size of a struct page. Used for sizing >> + * the vmemmap region only, does not affect actual memory footprint. >> + * We don't use sizeof(struct page) directly since taking its size here >> + *

Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-11 Thread Logan Gunthorpe
On 2018-10-11 7:37 a.m., Christoph Hellwig wrote: >> +/* >> + * Log2 of the upper bound of the size of a struct page. Used for sizing >> + * the vmemmap region only, does not affect actual memory footprint. >> + * We don't use sizeof(struct page) directly since taking its size here >> + *

Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-11 Thread Christoph Hellwig
> +/* > + * Log2 of the upper bound of the size of a struct page. Used for sizing > + * the vmemmap region only, does not affect actual memory footprint. > + * We don't use sizeof(struct page) directly since taking its size here > + * requires its definition to be available at this point in the

Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-11 Thread Christoph Hellwig
> +/* > + * Log2 of the upper bound of the size of a struct page. Used for sizing > + * the vmemmap region only, does not affect actual memory footprint. > + * We don't use sizeof(struct page) directly since taking its size here > + * requires its definition to be available at this point in the

Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-11 Thread Stephen Bates
Palmer > I don't really know anything about this, but you're welcome to add a > >Reviewed-by: Palmer Dabbelt Thanks. I think it would be good to get someone who's familiar with linux/mm to take a look. > if you think it'll help. I'm assuming you're targeting a different tree for

Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-11 Thread Stephen Bates
Palmer > I don't really know anything about this, but you're welcome to add a > >Reviewed-by: Palmer Dabbelt Thanks. I think it would be good to get someone who's familiar with linux/mm to take a look. > if you think it'll help. I'm assuming you're targeting a different tree for

Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-10 Thread Palmer Dabbelt
On Fri, 05 Oct 2018 09:16:42 PDT (-0700), log...@deltatee.com wrote: This patch implements sparsemem support for risc-v which helps pave the way for memory hotplug and eventually P2P support. We introduce Kconfig options for virtual and physical address bits which are used to calculate the size

Re: [PATCH 5/5] RISC-V: Implement sparsemem

2018-10-10 Thread Palmer Dabbelt
On Fri, 05 Oct 2018 09:16:42 PDT (-0700), log...@deltatee.com wrote: This patch implements sparsemem support for risc-v which helps pave the way for memory hotplug and eventually P2P support. We introduce Kconfig options for virtual and physical address bits which are used to calculate the size

[PATCH 5/5] RISC-V: Implement sparsemem

2018-10-05 Thread Logan Gunthorpe
This patch implements sparsemem support for risc-v which helps pave the way for memory hotplug and eventually P2P support. We introduce Kconfig options for virtual and physical address bits which are used to calculate the size of the vmemmap and set the MAX_PHYSMEM_BITS. The vmemmap is located

[PATCH 5/5] RISC-V: Implement sparsemem

2018-10-05 Thread Logan Gunthorpe
This patch implements sparsemem support for risc-v which helps pave the way for memory hotplug and eventually P2P support. We introduce Kconfig options for virtual and physical address bits which are used to calculate the size of the vmemmap and set the MAX_PHYSMEM_BITS. The vmemmap is located