Re: [PATCH 5/5] efi: Split efi_enter_virtual_mode

2014-01-20 Thread Matt Fleming
On Mon, 20 Jan, at 02:46:25PM, Borislav Petkov wrote: > On Mon, Jan 20, 2014 at 01:44:07PM +, Matt Fleming wrote: > > > +void __init kexec_enter_virtual_mode(void) > > > +{ > > > > Could this be static for now? > > Didn't you wanna do arch/x86/platform/efi/kexec.c anyway? Yes, but the patche

Re: [PATCH 5/5] efi: Split efi_enter_virtual_mode

2014-01-20 Thread Borislav Petkov
On Mon, Jan 20, 2014 at 01:44:07PM +, Matt Fleming wrote: > > +void __init kexec_enter_virtual_mode(void) > > +{ > > Could this be static for now? Didn't you wanna do arch/x86/platform/efi/kexec.c anyway? -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine.

Re: [PATCH 5/5] efi: Split efi_enter_virtual_mode

2014-01-20 Thread Matt Fleming
On Sat, 18 Jan, at 12:48:18PM, Borislav Petkov wrote: > From: Borislav Petkov > > ... into a kexec flavor for better code readability and simplicity. The > original one was getting ugly with ifdeffery. > > Signed-off-by: Borislav Petkov > Tested-by: Toshi Kani > --- > arch/x86/platform/efi/ef

[PATCH 5/5] efi: Split efi_enter_virtual_mode

2014-01-18 Thread Borislav Petkov
From: Borislav Petkov ... into a kexec flavor for better code readability and simplicity. The original one was getting ugly with ifdeffery. Signed-off-by: Borislav Petkov Tested-by: Toshi Kani --- arch/x86/platform/efi/efi.c | 148 +--- include/linux/ef