Re: [PATCH 5/5] net: dsa: fix a leaked reference by adding missing of_node_put

2019-02-24 Thread David Miller
From: Wen Yang Date: Fri, 22 Feb 2019 15:15:42 +0800 > diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c > index 8c431e0..89823f0 100644 > --- a/net/dsa/dsa2.c > +++ b/net/dsa/dsa2.c > @@ -613,7 +613,7 @@ static int dsa_switch_parse_ports_of(struct dsa_switch > *ds, > struct device_node

[PATCH 5/5] net: dsa: fix a leaked reference by adding missing of_node_put

2019-02-21 Thread Wen Yang
The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./net/dsa/port.c:294:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented