* Oleg Nesterov [2012-07-13 15:29:16]:
> On 07/13, Srikar Dronamraju wrote:
> >
> > * Oleg Nesterov [2012-07-08 22:30:11]:
> >
> > > Kill insert_vm_struct()->uprobe_mmap(). It is not needed, nobody
> > > except arch/ia64/kernel/perfmon.c uses insert_vm_struct(vma) with
> > > vma->vm_file !=
* Oleg Nesterov [2012-07-08 22:30:11]:
> Kill insert_vm_struct()->uprobe_mmap(). It is not needed, nobody
> except arch/ia64/kernel/perfmon.c uses insert_vm_struct(vma) with
> vma->vm_file != NULL.
>
> And it is wrong. Again, get_user_pages() can not succeed before
> vma_link(vma) makes is
On 07/13, Srikar Dronamraju wrote:
>
> * Oleg Nesterov [2012-07-08 22:30:11]:
>
> > Kill insert_vm_struct()->uprobe_mmap(). It is not needed, nobody
> > except arch/ia64/kernel/perfmon.c uses insert_vm_struct(vma) with
> > vma->vm_file != NULL.
> >
>
> Right, but somebody else might start using
* Oleg Nesterov [2012-07-08 22:30:11]:
> Kill insert_vm_struct()->uprobe_mmap(). It is not needed, nobody
> except arch/ia64/kernel/perfmon.c uses insert_vm_struct(vma) with
> vma->vm_file != NULL.
>
Right, but somebody else might start using this later.
I cant think of a use case though.
>
* Oleg Nesterov o...@redhat.com [2012-07-08 22:30:11]:
Kill insert_vm_struct()-uprobe_mmap(). It is not needed, nobody
except arch/ia64/kernel/perfmon.c uses insert_vm_struct(vma) with
vma-vm_file != NULL.
Right, but somebody else might start using this later.
I cant think of a use case
On 07/13, Srikar Dronamraju wrote:
* Oleg Nesterov o...@redhat.com [2012-07-08 22:30:11]:
Kill insert_vm_struct()-uprobe_mmap(). It is not needed, nobody
except arch/ia64/kernel/perfmon.c uses insert_vm_struct(vma) with
vma-vm_file != NULL.
Right, but somebody else might start using
* Oleg Nesterov o...@redhat.com [2012-07-08 22:30:11]:
Kill insert_vm_struct()-uprobe_mmap(). It is not needed, nobody
except arch/ia64/kernel/perfmon.c uses insert_vm_struct(vma) with
vma-vm_file != NULL.
And it is wrong. Again, get_user_pages() can not succeed before
vma_link(vma) makes
* Oleg Nesterov o...@redhat.com [2012-07-13 15:29:16]:
On 07/13, Srikar Dronamraju wrote:
* Oleg Nesterov o...@redhat.com [2012-07-08 22:30:11]:
Kill insert_vm_struct()-uprobe_mmap(). It is not needed, nobody
except arch/ia64/kernel/perfmon.c uses insert_vm_struct(vma) with
Kill insert_vm_struct()->uprobe_mmap(). It is not needed, nobody
except arch/ia64/kernel/perfmon.c uses insert_vm_struct(vma) with
vma->vm_file != NULL.
And it is wrong. Again, get_user_pages() can not succeed before
vma_link(vma) makes is visible to find_vma(). And even if this
worked, we must
Kill insert_vm_struct()-uprobe_mmap(). It is not needed, nobody
except arch/ia64/kernel/perfmon.c uses insert_vm_struct(vma) with
vma-vm_file != NULL.
And it is wrong. Again, get_user_pages() can not succeed before
vma_link(vma) makes is visible to find_vma(). And even if this
worked, we must not
10 matches
Mail list logo
