Re: [PATCH 5/6] Drivers: net: hyperv: Enable send side checksum offload

2014-03-09 Thread Ben Hutchings
On Thu, 2014-03-06 at 03:13 -0800, K. Y. Srinivasan wrote: [...] > @@ -593,8 +658,9 @@ static int netvsc_probe(struct hv_device *dev, > net->netdev_ops = &device_ops; > > /* TODO: Add GSO and Checksum offload */ > - net->hw_features = NETIF_F_RXCSUM | NETIF_F_SG; > - net->feat

RE: [PATCH 5/6] Drivers: net: hyperv: Enable send side checksum offload

2014-03-06 Thread KY Srinivasan
@redhat.com > Subject: Re: [PATCH 5/6] Drivers: net: hyperv: Enable send side checksum > offload > > From: KY Srinivasan > Date: Thu, 6 Mar 2014 20:29:13 + > > > > > > >> -Original Message- > >> From: David Miller [mailto:da...@davemloft

Re: [PATCH 5/6] Drivers: net: hyperv: Enable send side checksum offload

2014-03-06 Thread David Miller
org; >> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; >> jasow...@redhat.com >> Subject: Re: [PATCH 5/6] Drivers: net: hyperv: Enable send side checksum >> offload >> >> From: "K. Y. Srinivasan" >> Date: Thu, 6 Mar 20

RE: [PATCH 5/6] Drivers: net: hyperv: Enable send side checksum offload

2014-03-06 Thread KY Srinivasan
@redhat.com > Subject: Re: [PATCH 5/6] Drivers: net: hyperv: Enable send side checksum > offload > > From: "K. Y. Srinivasan" > Date: Thu, 6 Mar 2014 03:13:09 -0800 > > > +bool get_net_transport_info(struct sk_buff *skb, bool *is_v4, > > +

Re: [PATCH 5/6] Drivers: net: hyperv: Enable send side checksum offload

2014-03-06 Thread David Miller
From: "K. Y. Srinivasan" Date: Thu, 6 Mar 2014 03:13:09 -0800 > +bool get_net_transport_info(struct sk_buff *skb, bool *is_v4, > + bool *is_tcp, bool *is_udp, u32 *trans_off) > +{ Returning so many values like this is awkward, at best. Why not return a well defined

[PATCH 5/6] Drivers: net: hyperv: Enable send side checksum offload

2014-03-06 Thread K. Y. Srinivasan
Enable send side checksum offload. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c | 70 +- 1 files changed, 68 insertions(+), 2 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/n