Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On 2017/1/13 6:44, Jaegeuk Kim wrote: > This patch adds a kernel thread to issue discard commands. > It proposes three states, D_PREP, D_SUBMIT, and D_DONE to identify current > bio status. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu

Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On 2017/1/13 6:44, Jaegeuk Kim wrote: > This patch adds a kernel thread to issue discard commands. > It proposes three states, D_PREP, D_SUBMIT, and D_DONE to identify current > bio status. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu

Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On 02/08, Christoph Hellwig wrote: > On Mon, Feb 06, 2017 at 07:44:03PM -0800, Jaegeuk Kim wrote: > > Sorry for the late response due to the travel. > > > > When doing fstrim with a fresh f2fs image fomatted on Intel NVMe SSD whose > > model name is SSDPE2MW012T4, I've got the following trace. >

Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On 02/08, Christoph Hellwig wrote: > On Mon, Feb 06, 2017 at 07:44:03PM -0800, Jaegeuk Kim wrote: > > Sorry for the late response due to the travel. > > > > When doing fstrim with a fresh f2fs image fomatted on Intel NVMe SSD whose > > model name is SSDPE2MW012T4, I've got the following trace. >

Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On Mon, Feb 06, 2017 at 07:44:03PM -0800, Jaegeuk Kim wrote: > Sorry for the late response due to the travel. > > When doing fstrim with a fresh f2fs image fomatted on Intel NVMe SSD whose > model name is SSDPE2MW012T4, I've got the following trace. > So, I investigated why block_rq_complete()

Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On Mon, Feb 06, 2017 at 07:44:03PM -0800, Jaegeuk Kim wrote: > Sorry for the late response due to the travel. > > When doing fstrim with a fresh f2fs image fomatted on Intel NVMe SSD whose > model name is SSDPE2MW012T4, I've got the following trace. > So, I investigated why block_rq_complete()

Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On 02/05, Christoph Hellwig wrote: > On Mon, Jan 16, 2017 at 09:32:20AM -0800, Christoph Hellwig wrote: > > On Fri, Jan 13, 2017 at 11:12:11AM -0800, Jaegeuk Kim wrote: > > > Previously, I've done to issue discard bios asynchronously. But the > > > problem that > > > I've got is that was not

Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On 02/05, Christoph Hellwig wrote: > On Mon, Jan 16, 2017 at 09:32:20AM -0800, Christoph Hellwig wrote: > > On Fri, Jan 13, 2017 at 11:12:11AM -0800, Jaegeuk Kim wrote: > > > Previously, I've done to issue discard bios asynchronously. But the > > > problem that > > > I've got is that was not

Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On Mon, Jan 16, 2017 at 09:32:20AM -0800, Christoph Hellwig wrote: > On Fri, Jan 13, 2017 at 11:12:11AM -0800, Jaegeuk Kim wrote: > > Previously, I've done to issue discard bios asynchronously. But the problem > > that > > I've got is that was not enough. When testing nvme SSD with noop IO > >

Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On Mon, Jan 16, 2017 at 09:32:20AM -0800, Christoph Hellwig wrote: > On Fri, Jan 13, 2017 at 11:12:11AM -0800, Jaegeuk Kim wrote: > > Previously, I've done to issue discard bios asynchronously. But the problem > > that > > I've got is that was not enough. When testing nvme SSD with noop IO > >

Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On Fri, Jan 13, 2017 at 11:12:11AM -0800, Jaegeuk Kim wrote: > Previously, I've done to issue discard bios asynchronously. But the problem > that > I've got is that was not enough. When testing nvme SSD with noop IO scheduler, > submit_bio() was blocked at every 8 async discard bios, resulting in

Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On Fri, Jan 13, 2017 at 11:12:11AM -0800, Jaegeuk Kim wrote: > Previously, I've done to issue discard bios asynchronously. But the problem > that > I've got is that was not enough. When testing nvme SSD with noop IO scheduler, > submit_bio() was blocked at every 8 async discard bios, resulting in

Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On 01/13, Christoph Hellwig wrote: > On Thu, Jan 12, 2017 at 02:44:06PM -0800, Jaegeuk Kim wrote: > > This patch adds a kernel thread to issue discard commands. > > It proposes three states, D_PREP, D_SUBMIT, and D_DONE to identify current > > bio status. > > Why? Instead of creating the

Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On 01/13, Christoph Hellwig wrote: > On Thu, Jan 12, 2017 at 02:44:06PM -0800, Jaegeuk Kim wrote: > > This patch adds a kernel thread to issue discard commands. > > It proposes three states, D_PREP, D_SUBMIT, and D_DONE to identify current > > bio status. > > Why? Instead of creating the

Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On Thu, Jan 12, 2017 at 02:44:06PM -0800, Jaegeuk Kim wrote: > This patch adds a kernel thread to issue discard commands. > It proposes three states, D_PREP, D_SUBMIT, and D_DONE to identify current > bio status. Why? Instead of creating the complexity of a thread you should look into issuing

Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

On Thu, Jan 12, 2017 at 02:44:06PM -0800, Jaegeuk Kim wrote: > This patch adds a kernel thread to issue discard commands. > It proposes three states, D_PREP, D_SUBMIT, and D_DONE to identify current > bio status. Why? Instead of creating the complexity of a thread you should look into issuing

[PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

This patch adds a kernel thread to issue discard commands. It proposes three states, D_PREP, D_SUBMIT, and D_DONE to identify current bio status. Signed-off-by: Jaegeuk Kim --- fs/f2fs/f2fs.h| 11 + fs/f2fs/segment.c | 128

[PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously

This patch adds a kernel thread to issue discard commands. It proposes three states, D_PREP, D_SUBMIT, and D_DONE to identify current bio status. Signed-off-by: Jaegeuk Kim --- fs/f2fs/f2fs.h| 11 + fs/f2fs/segment.c | 128 +- 2 files