Re: [PATCH 5/6] kmod: preempt on kmod_umh_threads_get()

2017-05-25 Thread Dmitry Torokhov
On Thu, May 25, 2017 at 01:19:31PM +0200, Petr Mladek wrote: > On Wed 2017-05-24 19:27:38, Dmitry Torokhov wrote: > > On Thu, May 25, 2017 at 03:00:17AM +0200, Luis R. Rodriguez wrote: > > > On Wed, May 24, 2017 at 05:45:37PM -0700, Dmitry Torokhov wrote: > > > > On Thu, May 25, 2017 at 02:14:52AM

Re: [PATCH 5/6] kmod: preempt on kmod_umh_threads_get()

2017-05-25 Thread Luis R. Rodriguez
On Thu, May 25, 2017 at 01:19:31PM +0200, Petr Mladek wrote: > On Wed 2017-05-24 19:27:38, Dmitry Torokhov wrote: > > On Thu, May 25, 2017 at 03:00:17AM +0200, Luis R. Rodriguez wrote: > > > On Wed, May 24, 2017 at 05:45:37PM -0700, Dmitry Torokhov wrote: > > > > On Thu, May 25, 2017 at 02:14:52AM

Re: [PATCH 5/6] kmod: preempt on kmod_umh_threads_get()

2017-05-25 Thread Jessica Yu
+++ Dmitry Torokhov [24/05/17 19:27 -0700]: On Thu, May 25, 2017 at 03:00:17AM +0200, Luis R. Rodriguez wrote: On Wed, May 24, 2017 at 05:45:37PM -0700, Dmitry Torokhov wrote: > On Thu, May 25, 2017 at 02:14:52AM +0200, Luis R. Rodriguez wrote: > > On Fri, May 19, 2017 at 03:27:12PM -0700, Dmitr

Re: [PATCH 5/6] kmod: preempt on kmod_umh_threads_get()

2017-05-25 Thread Petr Mladek
On Wed 2017-05-24 19:27:38, Dmitry Torokhov wrote: > On Thu, May 25, 2017 at 03:00:17AM +0200, Luis R. Rodriguez wrote: > > On Wed, May 24, 2017 at 05:45:37PM -0700, Dmitry Torokhov wrote: > > > On Thu, May 25, 2017 at 02:14:52AM +0200, Luis R. Rodriguez wrote: > > > > On Fri, May 19, 2017 at 03:27

Re: [PATCH 5/6] kmod: preempt on kmod_umh_threads_get()

2017-05-24 Thread Dmitry Torokhov
On Thu, May 25, 2017 at 03:00:17AM +0200, Luis R. Rodriguez wrote: > On Wed, May 24, 2017 at 05:45:37PM -0700, Dmitry Torokhov wrote: > > On Thu, May 25, 2017 at 02:14:52AM +0200, Luis R. Rodriguez wrote: > > > On Fri, May 19, 2017 at 03:27:12PM -0700, Dmitry Torokhov wrote: > > > > On Thu, May 18,

Re: [PATCH 5/6] kmod: preempt on kmod_umh_threads_get()

2017-05-24 Thread Luis R. Rodriguez
On Wed, May 24, 2017 at 05:45:37PM -0700, Dmitry Torokhov wrote: > On Thu, May 25, 2017 at 02:14:52AM +0200, Luis R. Rodriguez wrote: > > On Fri, May 19, 2017 at 03:27:12PM -0700, Dmitry Torokhov wrote: > > > On Thu, May 18, 2017 at 08:24:43PM -0700, Luis R. Rodriguez wrote: > > > > In theory it is

Re: [PATCH 5/6] kmod: preempt on kmod_umh_threads_get()

2017-05-24 Thread Dmitry Torokhov
On Thu, May 25, 2017 at 02:14:52AM +0200, Luis R. Rodriguez wrote: > On Fri, May 19, 2017 at 03:27:12PM -0700, Dmitry Torokhov wrote: > > On Thu, May 18, 2017 at 08:24:43PM -0700, Luis R. Rodriguez wrote: > > > In theory it is possible multiple concurrent threads will try to > > > kmod_umh_threads_

Re: [PATCH 5/6] kmod: preempt on kmod_umh_threads_get()

2017-05-24 Thread Luis R. Rodriguez
On Fri, May 19, 2017 at 03:27:12PM -0700, Dmitry Torokhov wrote: > On Thu, May 18, 2017 at 08:24:43PM -0700, Luis R. Rodriguez wrote: > > In theory it is possible multiple concurrent threads will try to > > kmod_umh_threads_get() and as such atomic_inc(&kmod_concurrent) at > > the same time, theref

Re: [PATCH 5/6] kmod: preempt on kmod_umh_threads_get()

2017-05-19 Thread Dmitry Torokhov
On Thu, May 18, 2017 at 08:24:43PM -0700, Luis R. Rodriguez wrote: > In theory it is possible multiple concurrent threads will try to > kmod_umh_threads_get() and as such atomic_inc(&kmod_concurrent) at > the same time, therefore enabling a small time during which we've > bumped kmod_concurrent but

[PATCH 5/6] kmod: preempt on kmod_umh_threads_get()

2017-05-18 Thread Luis R. Rodriguez
In theory it is possible multiple concurrent threads will try to kmod_umh_threads_get() and as such atomic_inc(&kmod_concurrent) at the same time, therefore enabling a small time during which we've bumped kmod_concurrent but have not really enabled work. By using preemption we mitigate this a bit.