Re: [PATCH 5/6] statx: Make windows attributes available for CIFS, NTFS and FAT to use

2016-10-03 Thread Steve French
On Mon, May 2, 2016 at 5:52 PM, Andreas Dilger wrote: > On Apr 29, 2016, at 6:58 AM, David Howells wrote: >> >> Make windows attributes available for CIFS, NTFS and FAT to use in the >> statx struct. The attribute flags map directly by value to those in

Re: [PATCH 5/6] statx: Make windows attributes available for CIFS, NTFS and FAT to use

2016-10-03 Thread Steve French
On Mon, May 2, 2016 at 5:52 PM, Andreas Dilger wrote: > On Apr 29, 2016, at 6:58 AM, David Howells wrote: >> >> Make windows attributes available for CIFS, NTFS and FAT to use in the >> statx struct. The attribute flags map directly by value to those in the >> CIFS PDU flags. Some of these

Re: [PATCH 5/6] statx: Make windows attributes available for CIFS, NTFS and FAT to use

2016-05-08 Thread Christoph Hellwig
On Fri, Apr 29, 2016 at 01:58:14PM +0100, David Howells wrote: > Make windows attributes available for CIFS, NTFS and FAT to use in the > statx struct. The attribute flags map directly by value to those in the > CIFS PDU flags. Some of these bits can also be used by JFS, UFS and HPFS. Err, no

Re: [PATCH 5/6] statx: Make windows attributes available for CIFS, NTFS and FAT to use

2016-05-08 Thread Christoph Hellwig
On Fri, Apr 29, 2016 at 01:58:14PM +0100, David Howells wrote: > Make windows attributes available for CIFS, NTFS and FAT to use in the > statx struct. The attribute flags map directly by value to those in the > CIFS PDU flags. Some of these bits can also be used by JFS, UFS and HPFS. Err, no

Re: [PATCH 5/6] statx: Make windows attributes available for CIFS, NTFS and FAT to use

2016-05-03 Thread David Howells
Andreas Dilger wrote: > > __u32 st_win_attrs; > > It seems some of these flags are duplicated with the st_information field, > and some are duplicate with FS_IOC_GETFLAGS values, and returning the same > information in multiple ways is confusing. > > If these flags are

Re: [PATCH 5/6] statx: Make windows attributes available for CIFS, NTFS and FAT to use

2016-05-03 Thread David Howells
Andreas Dilger wrote: > > __u32 st_win_attrs; > > It seems some of these flags are duplicated with the st_information field, > and some are duplicate with FS_IOC_GETFLAGS values, and returning the same > information in multiple ways is confusing. > > If these flags are part of the CIFS

Re: [PATCH 5/6] statx: Make windows attributes available for CIFS, NTFS and FAT to use

2016-05-02 Thread Andreas Dilger
On Apr 29, 2016, at 6:58 AM, David Howells wrote: > > Make windows attributes available for CIFS, NTFS and FAT to use in the > statx struct. The attribute flags map directly by value to those in the > CIFS PDU flags. Some of these bits can also be used by JFS, UFS and

Re: [PATCH 5/6] statx: Make windows attributes available for CIFS, NTFS and FAT to use

2016-05-02 Thread Andreas Dilger
On Apr 29, 2016, at 6:58 AM, David Howells wrote: > > Make windows attributes available for CIFS, NTFS and FAT to use in the > statx struct. The attribute flags map directly by value to those in the > CIFS PDU flags. Some of these bits can also be used by JFS, UFS and HPFS. > > The statx

[PATCH 5/6] statx: Make windows attributes available for CIFS, NTFS and FAT to use

2016-04-29 Thread David Howells
Make windows attributes available for CIFS, NTFS and FAT to use in the statx struct. The attribute flags map directly by value to those in the CIFS PDU flags. Some of these bits can also be used by JFS, UFS and HPFS. The statx struct acquires: __u32 st_win_attrs; The value in this

[PATCH 5/6] statx: Make windows attributes available for CIFS, NTFS and FAT to use

2016-04-29 Thread David Howells
Make windows attributes available for CIFS, NTFS and FAT to use in the statx struct. The attribute flags map directly by value to those in the CIFS PDU flags. Some of these bits can also be used by JFS, UFS and HPFS. The statx struct acquires: __u32 st_win_attrs; The value in this