Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-12-02 Thread Christoffer Dall
On Mon, Dec 01, 2014 at 11:50:14AM +, Alex Bennée wrote: > > Christoffer Dall writes: > > > On Tue, Nov 25, 2014 at 04:10:03PM +, Alex Bennée wrote: > >> This adds support for single-stepping the guest. As userspace can and > >> will manipulate guest registers before restarting any

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-12-02 Thread Christoffer Dall
On Mon, Dec 01, 2014 at 11:50:14AM +, Alex Bennée wrote: Christoffer Dall christoffer.d...@linaro.org writes: On Tue, Nov 25, 2014 at 04:10:03PM +, Alex Bennée wrote: This adds support for single-stepping the guest. As userspace can and will manipulate guest registers before

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-12-01 Thread Alex Bennée
Christoffer Dall writes: > On Tue, Nov 25, 2014 at 04:10:03PM +, Alex Bennée wrote: >> This adds support for single-stepping the guest. As userspace can and >> will manipulate guest registers before restarting any tweaking of the >> registers has to occur just before control is passed back

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-12-01 Thread Alex Bennée
Christoffer Dall christoffer.d...@linaro.org writes: On Tue, Nov 25, 2014 at 04:10:03PM +, Alex Bennée wrote: This adds support for single-stepping the guest. As userspace can and will manipulate guest registers before restarting any tweaking of the registers has to occur just before

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-11-30 Thread Christoffer Dall
On Tue, Nov 25, 2014 at 04:10:03PM +, Alex Bennée wrote: > This adds support for single-stepping the guest. As userspace can and > will manipulate guest registers before restarting any tweaking of the > registers has to occur just before control is passed back to the guest. > Furthermore while

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-11-30 Thread Peter Maydell
On 30 November 2014 at 10:10, Christoffer Dall wrote: > In any case, I think it was related to how userspace observes the state > of the CPU, because when you do the MMIO operation emulation in > userspace, currently if you observe the PC though GET_ONE_REG, you'll > see a PC pointing to the next

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-11-30 Thread Christoffer Dall
On Wed, Nov 26, 2014 at 07:27:06PM +, Peter Maydell wrote: > On 25 November 2014 at 16:10, Alex Bennée wrote: > > This adds support for single-stepping the guest. As userspace can and > > will manipulate guest registers before restarting any tweaking of the > > registers has to occur just

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-11-30 Thread Christoffer Dall
On Wed, Nov 26, 2014 at 07:27:06PM +, Peter Maydell wrote: On 25 November 2014 at 16:10, Alex Bennée alex.ben...@linaro.org wrote: This adds support for single-stepping the guest. As userspace can and will manipulate guest registers before restarting any tweaking of the registers has to

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-11-30 Thread Peter Maydell
On 30 November 2014 at 10:10, Christoffer Dall christoffer.d...@linaro.org wrote: In any case, I think it was related to how userspace observes the state of the CPU, because when you do the MMIO operation emulation in userspace, currently if you observe the PC though GET_ONE_REG, you'll see a

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-11-30 Thread Christoffer Dall
On Tue, Nov 25, 2014 at 04:10:03PM +, Alex Bennée wrote: This adds support for single-stepping the guest. As userspace can and will manipulate guest registers before restarting any tweaking of the registers has to occur just before control is passed back to the guest. Furthermore while

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-11-26 Thread Peter Maydell
On 25 November 2014 at 16:10, Alex Bennée wrote: > This adds support for single-stepping the guest. As userspace can and > will manipulate guest registers before restarting any tweaking of the > registers has to occur just before control is passed back to the guest. > Furthermore while guest

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-11-26 Thread Alex Bennée
Andrew Jones writes: > On Tue, Nov 25, 2014 at 04:10:03PM +, Alex Bennée wrote: >> This adds support for single-stepping the guest. As userspace can and >> will manipulate guest registers before restarting any tweaking of the >> registers has to occur just before control is passed back to

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-11-26 Thread Andrew Jones
On Tue, Nov 25, 2014 at 04:10:03PM +, Alex Bennée wrote: > This adds support for single-stepping the guest. As userspace can and > will manipulate guest registers before restarting any tweaking of the > registers has to occur just before control is passed back to the guest. > Furthermore while

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-11-26 Thread Andrew Jones
On Tue, Nov 25, 2014 at 04:10:03PM +, Alex Bennée wrote: This adds support for single-stepping the guest. As userspace can and will manipulate guest registers before restarting any tweaking of the registers has to occur just before control is passed back to the guest. Furthermore while

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-11-26 Thread Alex Bennée
Andrew Jones drjo...@redhat.com writes: On Tue, Nov 25, 2014 at 04:10:03PM +, Alex Bennée wrote: This adds support for single-stepping the guest. As userspace can and will manipulate guest registers before restarting any tweaking of the registers has to occur just before control is

Re: [PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-11-26 Thread Peter Maydell
On 25 November 2014 at 16:10, Alex Bennée alex.ben...@linaro.org wrote: This adds support for single-stepping the guest. As userspace can and will manipulate guest registers before restarting any tweaking of the registers has to occur just before control is passed back to the guest.

[PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-11-25 Thread Alex Bennée
This adds support for single-stepping the guest. As userspace can and will manipulate guest registers before restarting any tweaking of the registers has to occur just before control is passed back to the guest. Furthermore while guest debugging is in effect we need to squash the ability of the

[PATCH 5/7] KVM: arm64: guest debug, add support for single-step

2014-11-25 Thread Alex Bennée
This adds support for single-stepping the guest. As userspace can and will manipulate guest registers before restarting any tweaking of the registers has to occur just before control is passed back to the guest. Furthermore while guest debugging is in effect we need to squash the ability of the