Re: [PATCH 5/7] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-08-11 Thread Vince Weaver
On Mon, 12 Aug 2013, Michael Ellerman wrote: > > Yes I think so. The interface is already defined and it's little endian, > so on big endian we just need to swap. > > The only part I'm not clear on is how things are handled in perf > userspace, it seems to already do some byte swapping. It

Re: [PATCH 5/7] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-08-11 Thread Michael Ellerman
On Sat, Aug 10, 2013 at 10:34:58PM -0400, Vince Weaver wrote: > On Sat, 10 Aug 2013, Sukadev Bhattiprolu wrote: > > > > > include/uapi/linux/perf_event.h | 55 > > +++ > > 1 files changed, 55 insertions(+), 0 deletions(-) > > > +#define __PERF_LE 1234 >

Re: [PATCH 5/7] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-08-11 Thread Sukadev Bhattiprolu
Vince Weaver [vi...@deater.net] wrote: | On Sat, 10 Aug 2013, Sukadev Bhattiprolu wrote: | | > | > include/uapi/linux/perf_event.h | 55 +++ | > 1 files changed, 55 insertions(+), 0 deletions(-) | | > +#define __PERF_LE 1234 | > +#define __PERF_BE 4321

Re: [PATCH 5/7] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-08-11 Thread Sukadev Bhattiprolu
Vince Weaver [vi...@deater.net] wrote: | On Sat, 10 Aug 2013, Sukadev Bhattiprolu wrote: | | | include/uapi/linux/perf_event.h | 55 +++ | 1 files changed, 55 insertions(+), 0 deletions(-) | | +#define __PERF_LE 1234 | +#define __PERF_BE 4321 | +

Re: [PATCH 5/7] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-08-11 Thread Michael Ellerman
On Sat, Aug 10, 2013 at 10:34:58PM -0400, Vince Weaver wrote: On Sat, 10 Aug 2013, Sukadev Bhattiprolu wrote: include/uapi/linux/perf_event.h | 55 +++ 1 files changed, 55 insertions(+), 0 deletions(-) +#define __PERF_LE 1234 +#define

Re: [PATCH 5/7] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-08-11 Thread Vince Weaver
On Mon, 12 Aug 2013, Michael Ellerman wrote: Yes I think so. The interface is already defined and it's little endian, so on big endian we just need to swap. The only part I'm not clear on is how things are handled in perf userspace, it seems to already do some byte swapping. It would be

Re: [PATCH 5/7] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-08-10 Thread Vince Weaver
On Sat, 10 Aug 2013, Sukadev Bhattiprolu wrote: > > include/uapi/linux/perf_event.h | 55 > +++ > 1 files changed, 55 insertions(+), 0 deletions(-) > +#define __PERF_LE1234 > +#define __PERF_BE4321 > + > +#if defined(__KERNEL__) I could be wrong,

[PATCH 5/7] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-08-10 Thread Sukadev Bhattiprolu
[PATCH 5/7] powerpc/perf: Define big-endian version of perf_mem_data_src perf_mem_data_src is an union that is initialized via the ->val field and accessed via the bitmap fields. For this to work on big endian platforms, we also need a big-endian represenation of perf_mem_data_src. Cc: Steph

[PATCH 5/7] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-08-10 Thread Sukadev Bhattiprolu
[PATCH 5/7] powerpc/perf: Define big-endian version of perf_mem_data_src perf_mem_data_src is an union that is initialized via the -val field and accessed via the bitmap fields. For this to work on big endian platforms, we also need a big-endian represenation of perf_mem_data_src. Cc: Stephane

Re: [PATCH 5/7] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-08-10 Thread Vince Weaver
On Sat, 10 Aug 2013, Sukadev Bhattiprolu wrote: include/uapi/linux/perf_event.h | 55 +++ 1 files changed, 55 insertions(+), 0 deletions(-) +#define __PERF_LE1234 +#define __PERF_BE4321 + +#if defined(__KERNEL__) I could be wrong, but I