Re: [PATCH 5/7] x86/uaccess: Warn on uaccess faults other than #PF

2016-05-29 Thread Andy Lutomirski
On Wed, May 25, 2016 at 2:49 AM, Borislav Petkov wrote: > On Tue, May 24, 2016 at 03:48:42PM -0700, Andy Lutomirski wrote: >> If a uaccess instruction fails due to an8 error other than #PF, >> warn. If the fault is #GP, it most likely indicates access to a >> non-canonical

Re: [PATCH 5/7] x86/uaccess: Warn on uaccess faults other than #PF

2016-05-29 Thread Andy Lutomirski
On Wed, May 25, 2016 at 2:49 AM, Borislav Petkov wrote: > On Tue, May 24, 2016 at 03:48:42PM -0700, Andy Lutomirski wrote: >> If a uaccess instruction fails due to an8 error other than #PF, >> warn. If the fault is #GP, it most likely indicates access to a >> non-canonical address, which means

Re: [PATCH 5/7] x86/uaccess: Warn on uaccess faults other than #PF

2016-05-25 Thread Borislav Petkov
On Tue, May 24, 2016 at 03:48:42PM -0700, Andy Lutomirski wrote: > If a uaccess instruction fails due to an8 error other than #PF, > warn. If the fault is #GP, it most likely indicates access to a > non-canonical address, which means that an access_ok check is > missing, and that's bad. If the

Re: [PATCH 5/7] x86/uaccess: Warn on uaccess faults other than #PF

2016-05-25 Thread Borislav Petkov
On Tue, May 24, 2016 at 03:48:42PM -0700, Andy Lutomirski wrote: > If a uaccess instruction fails due to an8 error other than #PF, > warn. If the fault is #GP, it most likely indicates access to a > non-canonical address, which means that an access_ok check is > missing, and that's bad. If the

[PATCH 5/7] x86/uaccess: Warn on uaccess faults other than #PF

2016-05-24 Thread Andy Lutomirski
If a uaccess instruction fails due to an8 error other than #PF, warn. If the fault is #GP, it most likely indicates access to a non-canonical address, which means that an access_ok check is missing, and that's bad. If the fault is something else (#UD?), then something is very wrong and we should

[PATCH 5/7] x86/uaccess: Warn on uaccess faults other than #PF

2016-05-24 Thread Andy Lutomirski
If a uaccess instruction fails due to an8 error other than #PF, warn. If the fault is #GP, it most likely indicates access to a non-canonical address, which means that an access_ok check is missing, and that's bad. If the fault is something else (#UD?), then something is very wrong and we should