Re: [PATCH 5/9] perf sort: Separate out memory-specific sort keys

2013-04-01 Thread Namhyung Kim
On Mon, 1 Apr 2013 22:29:37 +0200, Jiri Olsa wrote: > On Mon, Apr 01, 2013 at 08:35:21PM +0900, Namhyung Kim wrote: > > SNIP > >> + >> int sort_dimension__add(const char *tok) >> { >> unsigned int i; >> @@ -964,6 +971,33 @@ int sort_dimension__add(const char *tok) >> return 0;

Re: [PATCH 5/9] perf sort: Separate out memory-specific sort keys

2013-04-01 Thread Jiri Olsa
On Mon, Apr 01, 2013 at 08:35:21PM +0900, Namhyung Kim wrote: SNIP > + > int sort_dimension__add(const char *tok) > { > unsigned int i; > @@ -964,6 +971,33 @@ int sort_dimension__add(const char *tok) > return 0; > } > > + for (i = 0; i <

[PATCH 5/9] perf sort: Separate out memory-specific sort keys

2013-04-01 Thread Namhyung Kim
From: Namhyung Kim Since they're used only for perf mem, separate out them to a different dimension so that normal user cannot access them by any chance. For global/local weights, I'm not entirely sure to place them into the memory dimension. But it's the only user at this time. Cc: Andi

[PATCH 5/9] perf sort: Separate out memory-specific sort keys

2013-04-01 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com Since they're used only for perf mem, separate out them to a different dimension so that normal user cannot access them by any chance. For global/local weights, I'm not entirely sure to place them into the memory dimension. But it's the only user at this

Re: [PATCH 5/9] perf sort: Separate out memory-specific sort keys

2013-04-01 Thread Jiri Olsa
On Mon, Apr 01, 2013 at 08:35:21PM +0900, Namhyung Kim wrote: SNIP + int sort_dimension__add(const char *tok) { unsigned int i; @@ -964,6 +971,33 @@ int sort_dimension__add(const char *tok) return 0; } + for (i = 0; i

Re: [PATCH 5/9] perf sort: Separate out memory-specific sort keys

2013-04-01 Thread Namhyung Kim
On Mon, 1 Apr 2013 22:29:37 +0200, Jiri Olsa wrote: On Mon, Apr 01, 2013 at 08:35:21PM +0900, Namhyung Kim wrote: SNIP + int sort_dimension__add(const char *tok) { unsigned int i; @@ -964,6 +971,33 @@ int sort_dimension__add(const char *tok) return 0; } +