Re: [PATCH 6/6] mm: numa: Cleanup flow of transhuge page migration

2013-01-27 Thread Hugh Dickins
On Tue, 22 Jan 2013, Mel Gorman wrote: > From: Hugh Dickins > > When correcting commit 04fa5d6a (mm: migrate: check page_count of > THP before migrating) Hugh Dickins noted that the control flow for > transhuge migration was difficult to follow. Unconditionally calling > put_page() in

Re: [PATCH 6/6] mm: numa: Cleanup flow of transhuge page migration

2013-01-27 Thread Hugh Dickins
On Tue, 22 Jan 2013, Mel Gorman wrote: From: Hugh Dickins hu...@google.com When correcting commit 04fa5d6a (mm: migrate: check page_count of THP before migrating) Hugh Dickins noted that the control flow for transhuge migration was difficult to follow. Unconditionally calling put_page() in

[PATCH 6/6] mm: numa: Cleanup flow of transhuge page migration

2013-01-22 Thread Mel Gorman
From: Hugh Dickins When correcting commit 04fa5d6a (mm: migrate: check page_count of THP before migrating) Hugh Dickins noted that the control flow for transhuge migration was difficult to follow. Unconditionally calling put_page() in numamigrate_isolate_page() made the failure paths of both

[PATCH 6/6] mm: numa: Cleanup flow of transhuge page migration

2013-01-22 Thread Mel Gorman
From: Hugh Dickins hu...@google.com When correcting commit 04fa5d6a (mm: migrate: check page_count of THP before migrating) Hugh Dickins noted that the control flow for transhuge migration was difficult to follow. Unconditionally calling put_page() in numamigrate_isolate_page() made the failure