Re: [PATCH 6/6] spi : use class iteration api

2008-01-21 Thread David Brownell
On Monday 21 January 2008, Dave Young wrote: > Convert to use the class iteration api. > > Signed-off-by: Dave Young <[EMAIL PROTECTED]> Ack. > --- > drivers/spi/spi.c | 24 ++-- > 1 file changed, 14 insertions(+), 10 deletions(-) > > diff -upr linux/drivers/spi/spi.c

Re: [PATCH 6/6] spi : use class iteration api

2008-01-21 Thread Dave Young
Convert to use the class iteration api. Signed-off-by: Dave Young <[EMAIL PROTECTED]> --- drivers/spi/spi.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c --- linux/drivers/spi/spi.c

Re: [PATCH 6/6] spi : use class iteration api

2008-01-21 Thread Dave Young
On Jan 22, 2008 2:56 PM, David Brownell <[EMAIL PROTECTED]> wrote: > On Monday 21 January 2008, Dave Young wrote: > > +static int __spi_master_match(struct device *dev, void *data) > > +{ > > +struct spi_master *m; > > +u16 *bus_num = (u16 *)data; > > That's "void *data" so "u16 *bus_num = data"

Re: [PATCH 6/6] spi : use class iteration api

2008-01-21 Thread David Brownell
On Monday 21 January 2008, Dave Young wrote: > +static int __spi_master_match(struct device *dev, void *data) > +{ > +   struct spi_master *m; > +   u16 *bus_num = (u16 *)data; That's "void *data" so "u16 *bus_num = data" is preferred. -- To unsubscribe from this list: send the line

[PATCH 6/6] spi : use class iteration api

2008-01-21 Thread Dave Young
Convert to use the class iteration api. Signed-off-by: Dave Young <[EMAIL PROTECTED]> --- drivers/spi/spi.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c --- linux/drivers/spi/spi.c

[PATCH 6/6] spi : use class iteration api

2008-01-21 Thread Dave Young
Convert to use the class iteration api. Signed-off-by: Dave Young [EMAIL PROTECTED] --- drivers/spi/spi.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c --- linux/drivers/spi/spi.c 2008-01-16

Re: [PATCH 6/6] spi : use class iteration api

2008-01-21 Thread David Brownell
On Monday 21 January 2008, Dave Young wrote: +static int __spi_master_match(struct device *dev, void *data) +{ +   struct spi_master *m; +   u16 *bus_num = (u16 *)data; That's void *data so u16 *bus_num = data is preferred. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 6/6] spi : use class iteration api

2008-01-21 Thread Dave Young
On Jan 22, 2008 2:56 PM, David Brownell [EMAIL PROTECTED] wrote: On Monday 21 January 2008, Dave Young wrote: +static int __spi_master_match(struct device *dev, void *data) +{ +struct spi_master *m; +u16 *bus_num = (u16 *)data; That's void *data so u16 *bus_num = data is preferred.

Re: [PATCH 6/6] spi : use class iteration api

2008-01-21 Thread Dave Young
Convert to use the class iteration api. Signed-off-by: Dave Young [EMAIL PROTECTED] --- drivers/spi/spi.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c --- linux/drivers/spi/spi.c 2008-01-22

Re: [PATCH 6/6] spi : use class iteration api

2008-01-21 Thread David Brownell
On Monday 21 January 2008, Dave Young wrote: Convert to use the class iteration api. Signed-off-by: Dave Young [EMAIL PROTECTED] Ack. --- drivers/spi/spi.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff -upr linux/drivers/spi/spi.c