> > +/* FUNC interface - backlight power control */
> > +#define BACKLIGHT_POWER0x4
> > +#define BACKLIGHT_OFF 0x3
> > +#define BACKLIGHT_ON 0x0
>
> A minor detail: BACKLIGHT_OFF and BACKLIGHT_ON are potential parameter
> values while BACKLIGHT_POWER is essentially a parameter
> > +/* FUNC interface - backlight power control */
> > +#define BACKLIGHT_POWER0x4
> > +#define BACKLIGHT_OFF 0x3
> > +#define BACKLIGHT_ON 0x0
>
> A minor detail: BACKLIGHT_OFF and BACKLIGHT_ON are potential parameter
> values while BACKLIGHT_POWER is essentially a parameter
On Sun, Feb 11, 2018 at 10:07:26PM +0100, Micha?? K??pie?? wrote:
> Use named constants instead of integers in call_fext_func() invocations
> related to backlight power control in order to more clearly convey the
> intent of each call.
>
> Signed-off-by: Micha?? K??pie??
> ---
On Sun, Feb 11, 2018 at 10:07:26PM +0100, Micha?? K??pie?? wrote:
> Use named constants instead of integers in call_fext_func() invocations
> related to backlight power control in order to more clearly convey the
> intent of each call.
>
> Signed-off-by: Micha?? K??pie??
> ---
[cut]
> +/* FUNC
Use named constants instead of integers in call_fext_func() invocations
related to backlight power control in order to more clearly convey the
intent of each call.
Signed-off-by: Michał Kępień
---
drivers/platform/x86/fujitsu-laptop.c | 14 +++---
1 file changed, 11
Use named constants instead of integers in call_fext_func() invocations
related to backlight power control in order to more clearly convey the
intent of each call.
Signed-off-by: Michał Kępień
---
drivers/platform/x86/fujitsu-laptop.c | 14 +++---
1 file changed, 11 insertions(+), 3
6 matches
Mail list logo