Re: [PATCH 6/7] platform/x86: fujitsu-laptop: Define constants for backlight power control

2018-02-18 Thread Michał Kępień
> > +/* FUNC interface - backlight power control */ > > +#define BACKLIGHT_POWER0x4 > > +#define BACKLIGHT_OFF 0x3 > > +#define BACKLIGHT_ON 0x0 > > A minor detail: BACKLIGHT_OFF and BACKLIGHT_ON are potential parameter > values while BACKLIGHT_POWER is essentially a parameter

Re: [PATCH 6/7] platform/x86: fujitsu-laptop: Define constants for backlight power control

2018-02-18 Thread Michał Kępień
> > +/* FUNC interface - backlight power control */ > > +#define BACKLIGHT_POWER0x4 > > +#define BACKLIGHT_OFF 0x3 > > +#define BACKLIGHT_ON 0x0 > > A minor detail: BACKLIGHT_OFF and BACKLIGHT_ON are potential parameter > values while BACKLIGHT_POWER is essentially a parameter

Re: [PATCH 6/7] platform/x86: fujitsu-laptop: Define constants for backlight power control

2018-02-16 Thread Jonathan Woithe
On Sun, Feb 11, 2018 at 10:07:26PM +0100, Micha?? K??pie?? wrote: > Use named constants instead of integers in call_fext_func() invocations > related to backlight power control in order to more clearly convey the > intent of each call. > > Signed-off-by: Micha?? K??pie?? > ---

Re: [PATCH 6/7] platform/x86: fujitsu-laptop: Define constants for backlight power control

2018-02-16 Thread Jonathan Woithe
On Sun, Feb 11, 2018 at 10:07:26PM +0100, Micha?? K??pie?? wrote: > Use named constants instead of integers in call_fext_func() invocations > related to backlight power control in order to more clearly convey the > intent of each call. > > Signed-off-by: Micha?? K??pie?? > --- [cut] > +/* FUNC

[PATCH 6/7] platform/x86: fujitsu-laptop: Define constants for backlight power control

2018-02-11 Thread Michał Kępień
Use named constants instead of integers in call_fext_func() invocations related to backlight power control in order to more clearly convey the intent of each call. Signed-off-by: Michał Kępień --- drivers/platform/x86/fujitsu-laptop.c | 14 +++--- 1 file changed, 11

[PATCH 6/7] platform/x86: fujitsu-laptop: Define constants for backlight power control

2018-02-11 Thread Michał Kępień
Use named constants instead of integers in call_fext_func() invocations related to backlight power control in order to more clearly convey the intent of each call. Signed-off-by: Michał Kępień --- drivers/platform/x86/fujitsu-laptop.c | 14 +++--- 1 file changed, 11 insertions(+), 3