Re: [PATCH 6/8] livepatch: Remove Nop structures when unused

2018-04-10 Thread Petr Mladek
On Tue 2018-04-10 11:14:21, Miroslav Benes wrote: > On Fri, 23 Mar 2018, Petr Mladek wrote: > > This patch allows to unpatch and free the dynamic structures independently > > when the transition finishes. > > > > The free part is a bit tricky because kobject free callbacks are called > > asynchron

Re: [PATCH 6/8] livepatch: Remove Nop structures when unused

2018-04-10 Thread Miroslav Benes
On Fri, 23 Mar 2018, Petr Mladek wrote: > Replaced patches are removed from the stack when the transition is > finished. It means that Nop structures will never be needed again > and can be removed. Why should we care? > > + Nop structures make false feeling that the function is patched > e

Re: [PATCH 6/8] livepatch: Remove Nop structures when unused

2018-04-06 Thread Josh Poimboeuf
On Fri, Mar 23, 2018 at 01:00:26PM +0100, Petr Mladek wrote: > Replaced patches are removed from the stack when the transition is > finished. It means that Nop structures will never be needed again > and can be removed. Why should we care? Warning, grammar pedantry ahead. "Nop" isn't a proper nou

[PATCH 6/8] livepatch: Remove Nop structures when unused

2018-03-23 Thread Petr Mladek
Replaced patches are removed from the stack when the transition is finished. It means that Nop structures will never be needed again and can be removed. Why should we care? + Nop structures make false feeling that the function is patched even though the ftrace handler has no effect. + Ftr