Re: [PATCH 7/7] modpost: handle relocations mismatch in __ex_table.

2015-04-15 Thread Quentin Casasnovas
On Wed, Apr 15, 2015 at 12:57:37PM +0930, Rusty Russell wrote: > > I've applied his patch, then the following: Thanks. > > modpost: handle -ffunction-sections > > 52dc0595d540 introduced OTHER_TEXT_SECTIONS for identifying what > sections could validly have __ex_table entries. Unfortunately,

Re: [PATCH 7/7] modpost: handle relocations mismatch in __ex_table.

2015-04-14 Thread Rusty Russell
Quentin Casasnovas writes: > On Tue, Apr 14, 2015 at 02:14:14PM +0200, Thierry Reding wrote: >> On Tue, Mar 17, 2015 at 01:40:02PM +0100, Quentin Casasnovas wrote: >> > If one of these addresses point to a non-executable section, something is >> > seriously wrong since it either means the kernel w

Re: [PATCH 7/7] modpost: handle relocations mismatch in __ex_table.

2015-04-14 Thread Quentin Casasnovas
On Tue, Apr 14, 2015 at 02:14:14PM +0200, Thierry Reding wrote: > On Tue, Mar 17, 2015 at 01:40:02PM +0100, Quentin Casasnovas wrote: > > If one of these addresses point to a non-executable section, something is > > seriously wrong since it either means the kernel will never fault from > > there or

Re: [PATCH 7/7] modpost: handle relocations mismatch in __ex_table.

2015-04-14 Thread Thierry Reding
On Tue, Mar 17, 2015 at 01:40:02PM +0100, Quentin Casasnovas wrote: > __ex_table is a simple table section where each entry is a pair of > addresses - the first address is an address which can fault in kernel > space, and the second address points to where the kernel should jump to > when handling

Re: [PATCH 7/7] modpost: handle relocations mismatch in __ex_table.

2015-04-13 Thread Quentin Casasnovas
On Mon, Apr 13, 2015 at 08:48:56PM +0930, Rusty Russell wrote: > Quentin Casasnovas writes: > > __ex_table is a simple table section where each entry is a pair of > > addresses - the first address is an address which can fault in kernel > > space, and the second address points to where the kernel

Re: [PATCH 7/7] modpost: handle relocations mismatch in __ex_table.

2015-04-13 Thread Rusty Russell
Quentin Casasnovas writes: > __ex_table is a simple table section where each entry is a pair of > addresses - the first address is an address which can fault in kernel > space, and the second address points to where the kernel should jump to > when handling that fault. This is how copy_from_user(

Re: [PATCH 7/7] modpost: handle relocations mismatch in __ex_table.

2015-03-18 Thread Quentin Casasnovas
Adding Rusty and Michal to CC. On Tue, Mar 17, 2015 at 01:40:02PM +0100, Quentin Casasnovas wrote: > __ex_table is a simple table section where each entry is a pair of > addresses - the first address is an address which can fault in kernel > space, and the second address points to where the kernel

[PATCH 7/7] modpost: handle relocations mismatch in __ex_table.

2015-03-17 Thread Quentin Casasnovas
__ex_table is a simple table section where each entry is a pair of addresses - the first address is an address which can fault in kernel space, and the second address points to where the kernel should jump to when handling that fault. This is how copy_from_user() does not crash the kernel if users