Re: [PATCH 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar.

2018-11-23 Thread Guenter Roeck
On 11/23/18 3:10 AM, Enric Balletbo i Serra wrote: Hi Guenter, On 22/11/18 20:25, Guenter Roeck wrote: On Thu, Nov 22, 2018 at 12:33:56PM +0100, Enric Balletbo i Serra wrote: Due to the way attribute groups visibility work, the function cros_ec_lightbar_attrs_are_visible is called multiple

Re: [PATCH 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar.

2018-11-23 Thread Guenter Roeck
On 11/23/18 3:10 AM, Enric Balletbo i Serra wrote: Hi Guenter, On 22/11/18 20:25, Guenter Roeck wrote: On Thu, Nov 22, 2018 at 12:33:56PM +0100, Enric Balletbo i Serra wrote: Due to the way attribute groups visibility work, the function cros_ec_lightbar_attrs_are_visible is called multiple

Re: [PATCH 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar.

2018-11-23 Thread Enric Balletbo i Serra
Hi Guenter, On 22/11/18 20:25, Guenter Roeck wrote: > On Thu, Nov 22, 2018 at 12:33:56PM +0100, Enric Balletbo i Serra wrote: >> Due to the way attribute groups visibility work, the function >> cros_ec_lightbar_attrs_are_visible is called multiple times, once per >> attribute, and each of these

Re: [PATCH 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar.

2018-11-23 Thread Enric Balletbo i Serra
Hi Guenter, On 22/11/18 20:25, Guenter Roeck wrote: > On Thu, Nov 22, 2018 at 12:33:56PM +0100, Enric Balletbo i Serra wrote: >> Due to the way attribute groups visibility work, the function >> cros_ec_lightbar_attrs_are_visible is called multiple times, once per >> attribute, and each of these

Re: [PATCH 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar.

2018-11-22 Thread Guenter Roeck
On Thu, Nov 22, 2018 at 12:33:56PM +0100, Enric Balletbo i Serra wrote: > Due to the way attribute groups visibility work, the function > cros_ec_lightbar_attrs_are_visible is called multiple times, once per > attribute, and each of these calls makes an EC transaction. For what is > worth the EC

Re: [PATCH 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar.

2018-11-22 Thread Guenter Roeck
On Thu, Nov 22, 2018 at 12:33:56PM +0100, Enric Balletbo i Serra wrote: > Due to the way attribute groups visibility work, the function > cros_ec_lightbar_attrs_are_visible is called multiple times, once per > attribute, and each of these calls makes an EC transaction. For what is > worth the EC

[PATCH 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar.

2018-11-22 Thread Enric Balletbo i Serra
Due to the way attribute groups visibility work, the function cros_ec_lightbar_attrs_are_visible is called multiple times, once per attribute, and each of these calls makes an EC transaction. For what is worth the EC log reports multiple errors on boot when the lightbar is not available. Instead,

[PATCH 7/7] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar.

2018-11-22 Thread Enric Balletbo i Serra
Due to the way attribute groups visibility work, the function cros_ec_lightbar_attrs_are_visible is called multiple times, once per attribute, and each of these calls makes an EC transaction. For what is worth the EC log reports multiple errors on boot when the lightbar is not available. Instead,