Re: [PATCH 7/8] pstore: Remove needless lock during console writes

2018-11-02 Thread Joel Fernandes
On Fri, Nov 02, 2018 at 01:40:06PM -0700, Kees Cook wrote: > On Fri, Nov 2, 2018 at 11:32 AM, Joel Fernandes > wrote: > > On Thu, Nov 01, 2018 at 04:51:59PM -0700, Kees Cook wrote: > >> Since commit 70ad35db3321 ("pstore: Convert console write to use > >> ->write_buf"), the console writer does no

Re: [PATCH 7/8] pstore: Remove needless lock during console writes

2018-11-02 Thread Kees Cook
On Fri, Nov 2, 2018 at 11:32 AM, Joel Fernandes wrote: > On Thu, Nov 01, 2018 at 04:51:59PM -0700, Kees Cook wrote: >> Since commit 70ad35db3321 ("pstore: Convert console write to use >> ->write_buf"), the console writer does not use the preallocated crash >> dump buffer any more, so there is no r

Re: [PATCH 7/8] pstore: Remove needless lock during console writes

2018-11-02 Thread Joel Fernandes
On Thu, Nov 01, 2018 at 04:51:59PM -0700, Kees Cook wrote: > Since commit 70ad35db3321 ("pstore: Convert console write to use > ->write_buf"), the console writer does not use the preallocated crash > dump buffer any more, so there is no reason to perform locking around it. Out of curiosity, what w

[PATCH 7/8] pstore: Remove needless lock during console writes

2018-11-01 Thread Kees Cook
Since commit 70ad35db3321 ("pstore: Convert console write to use ->write_buf"), the console writer does not use the preallocated crash dump buffer any more, so there is no reason to perform locking around it. Signed-off-by: Kees Cook --- fs/pstore/platform.c | 29 ++--- 1