Re: [PATCH 7/9] i2c: rk3x: Simplify with dev_err_probe()

[Wolfram Sang]

On Wed, Sep 02, 2020 at 05:06:41PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and the error value gets printed.
> 
> Signed-off-by: Krzysztof Kozlowski 

Applied to for-next, thanks!



signature.asc
Description: PGP signature

Re: [PATCH 7/9] i2c: rk3x: Simplify with dev_err_probe()

[Heiko Stübner]

Am Mittwoch, 2. September 2020, 17:06:41 CEST schrieb Krzysztof Kozlowski:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and the error value gets printed.
> 
> Signed-off-by: Krzysztof Kozlowski 

Reviewed-by: Heiko Stuebner 

[PATCH 7/9] i2c: rk3x: Simplify with dev_err_probe()

[Krzysztof Kozlowski]

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski 
---
 drivers/i2c/busses/i2c-rk3x.c | 19 +++
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index 8e3cc85d1921..819ab4ee517e 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -1312,18 +1312,13 @@ static int rk3x_i2c_probe(struct platform_device *pdev)
i2c->pclk = devm_clk_get(>dev, "pclk");
}
 
-   if (IS_ERR(i2c->clk)) {
-   ret = PTR_ERR(i2c->clk);
-   if (ret != -EPROBE_DEFER)
-   dev_err(>dev, "Can't get bus clk: %d\n", ret);
-   return ret;
-   }
-   if (IS_ERR(i2c->pclk)) {
-   ret = PTR_ERR(i2c->pclk);
-   if (ret != -EPROBE_DEFER)
-   dev_err(>dev, "Can't get periph clk: %d\n", ret);
-   return ret;
-   }
+   if (IS_ERR(i2c->clk))
+   return dev_err_probe(>dev, PTR_ERR(i2c->clk),
+"Can't get bus clk\n");
+
+   if (IS_ERR(i2c->pclk))
+   return dev_err_probe(>dev, PTR_ERR(i2c->pclk),
+"Can't get periph clk\n");
 
ret = clk_prepare(i2c->clk);
if (ret < 0) {
-- 
2.17.1