Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-05 Thread David Miller
From: Lee Jones Date: Mon, 5 Nov 2012 09:44:19 +0100 > On Sun, 04 Nov 2012, David Miller wrote: > >> From: Lee Jones >> Date: Sun, 4 Nov 2012 11:53:32 +0100 >> >> > On Sun, 04 Nov 2012, Paul Bolle wrote: >> > >> >> On Sat, 2012-11-03 at 23:48 +0100, Lee Jones wrote: >> >> > On Sat, 03 Nov

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-05 Thread Lee Jones
On Mon, 05 Nov 2012, Paul Bolle wrote: > On Mon, 2012-11-05 at 09:44 +0100, Lee Jones wrote: > > On Sun, 04 Nov 2012, David Miller wrote: > > > I think the most appropriate thing to do is make CONFIG_ISDN depend > > > upon CONFIG_NETDEVICES in the Kconfig file. > > > > ... and then remove the

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-05 Thread Paul Bolle
On Mon, 2012-11-05 at 09:44 +0100, Lee Jones wrote: > On Sun, 04 Nov 2012, David Miller wrote: > > I think the most appropriate thing to do is make CONFIG_ISDN depend > > upon CONFIG_NETDEVICES in the Kconfig file. > > ... and then remove the CONFIG_NETDEVICES guards in isdn_common.c? If ISDN

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-05 Thread Lee Jones
On Sun, 04 Nov 2012, David Miller wrote: > From: Lee Jones > Date: Sun, 4 Nov 2012 11:53:32 +0100 > > > On Sun, 04 Nov 2012, Paul Bolle wrote: > > > >> On Sat, 2012-11-03 at 23:48 +0100, Lee Jones wrote: > >> > On Sat, 03 Nov 2012, Paul Bolle wrote: > >> > > On Sat, 2012-11-03 at 23:02 +0100,

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-05 Thread Lee Jones
On Sun, 04 Nov 2012, David Miller wrote: From: Lee Jones lee.jo...@linaro.org Date: Sun, 4 Nov 2012 11:53:32 +0100 On Sun, 04 Nov 2012, Paul Bolle wrote: On Sat, 2012-11-03 at 23:48 +0100, Lee Jones wrote: On Sat, 03 Nov 2012, Paul Bolle wrote: On Sat, 2012-11-03 at 23:02 +0100,

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-05 Thread Paul Bolle
On Mon, 2012-11-05 at 09:44 +0100, Lee Jones wrote: On Sun, 04 Nov 2012, David Miller wrote: I think the most appropriate thing to do is make CONFIG_ISDN depend upon CONFIG_NETDEVICES in the Kconfig file. ... and then remove the CONFIG_NETDEVICES guards in isdn_common.c? If ISDN would

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-05 Thread Lee Jones
On Mon, 05 Nov 2012, Paul Bolle wrote: On Mon, 2012-11-05 at 09:44 +0100, Lee Jones wrote: On Sun, 04 Nov 2012, David Miller wrote: I think the most appropriate thing to do is make CONFIG_ISDN depend upon CONFIG_NETDEVICES in the Kconfig file. ... and then remove the

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-05 Thread David Miller
From: Lee Jones lee.jo...@linaro.org Date: Mon, 5 Nov 2012 09:44:19 +0100 On Sun, 04 Nov 2012, David Miller wrote: From: Lee Jones lee.jo...@linaro.org Date: Sun, 4 Nov 2012 11:53:32 +0100 On Sun, 04 Nov 2012, Paul Bolle wrote: On Sat, 2012-11-03 at 23:48 +0100, Lee Jones wrote:

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-04 Thread David Miller
From: Lee Jones Date: Sun, 4 Nov 2012 11:53:32 +0100 > On Sun, 04 Nov 2012, Paul Bolle wrote: > >> On Sat, 2012-11-03 at 23:48 +0100, Lee Jones wrote: >> > On Sat, 03 Nov 2012, Paul Bolle wrote: >> > > On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: >> > > > This patch fixes: >> > > >

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-04 Thread Lee Jones
On Sun, 04 Nov 2012, Paul Bolle wrote: > On Sat, 2012-11-03 at 23:48 +0100, Lee Jones wrote: > > On Sat, 03 Nov 2012, Paul Bolle wrote: > > > On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: > > > > This patch fixes: > > > > drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: > > > >

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-04 Thread Paul Bolle
On Sat, 2012-11-03 at 23:48 +0100, Lee Jones wrote: > On Sat, 03 Nov 2012, Paul Bolle wrote: > > On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: > > > This patch fixes: > > > drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: > > > drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-04 Thread Paul Bolle
On Sat, 2012-11-03 at 23:48 +0100, Lee Jones wrote: On Sat, 03 Nov 2012, Paul Bolle wrote: On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: This patch fixes: drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused variable ‘s’

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-04 Thread Lee Jones
On Sun, 04 Nov 2012, Paul Bolle wrote: On Sat, 2012-11-03 at 23:48 +0100, Lee Jones wrote: On Sat, 03 Nov 2012, Paul Bolle wrote: On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: This patch fixes: drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’:

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-04 Thread David Miller
From: Lee Jones lee.jo...@linaro.org Date: Sun, 4 Nov 2012 11:53:32 +0100 On Sun, 04 Nov 2012, Paul Bolle wrote: On Sat, 2012-11-03 at 23:48 +0100, Lee Jones wrote: On Sat, 03 Nov 2012, Paul Bolle wrote: On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: This patch fixes:

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-03 Thread Lee Jones
On Sat, 03 Nov 2012, Paul Bolle wrote: > On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: > > This patch fixes: > > drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: > > drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused variable ‘s’ > > [-Wunused-variable] > > Did you have

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-03 Thread Paul Bolle
On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: > This patch fixes: > drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: > drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused variable ‘s’ > [-Wunused-variable] Did you have CONFIG_NETDEVICES not set in this build? Paul Bolle --

[PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-03 Thread Lee Jones
This patch fixes: drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused variable ‘s’ [-Wunused-variable] Cc: Karsten Keil Cc: net...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/isdn/i4l/isdn_common.c |1 - 1 file changed,

[PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-03 Thread Lee Jones
This patch fixes: drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused variable ‘s’ [-Wunused-variable] Cc: Karsten Keil i...@linux-pingi.de Cc: net...@vger.kernel.org Signed-off-by: Lee Jones lee.jo...@linaro.org ---

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-03 Thread Paul Bolle
On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: This patch fixes: drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused variable ‘s’ [-Wunused-variable] Did you have CONFIG_NETDEVICES not set in this build? Paul Bolle -- To

Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning

2012-11-03 Thread Lee Jones
On Sat, 03 Nov 2012, Paul Bolle wrote: On Sat, 2012-11-03 at 23:02 +0100, Lee Jones wrote: This patch fixes: drivers/isdn/i4l/isdn_common.c: In function ‘isdn_ioctl’: drivers/isdn/i4l/isdn_common.c:1278:8: warning: unused variable ‘s’ [-Wunused-variable] Did you have