Re: [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec

2017-02-03 Thread Robert Jarzmik
Mark Brown writes: >> >> As for the "sound specific part", it's because AC97 bus is mainly used in >> >> sound >> >> oriented drivers, but still the codec IPs provide more than just sound, >> >> as the >> >> Wolfson codecs for instance. > >> > I'd like to get Mark Brown's opinion on this. > > I'

Re: [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec

2016-12-06 Thread Mark Brown
On Sat, Nov 26, 2016 at 10:18:38AM +0100, Robert Jarzmik wrote: > >> >> +#define WM9705_VENDOR_ID 0x574d4c05 > >> >> +#define WM9712_VENDOR_ID 0x574d4c12 > >> >> +#define WM9713_VENDOR_ID 0x574d4c13 > >> >> +#define WM97xx_VENDOR_ID_MASK 0x > >> > These are probably better represented as

Re: [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec

2016-11-26 Thread Robert Jarzmik
Lee Jones writes: > Mark, please see below: You'll get better chances to have an answer if you put Mark in the To: list. Mark, Lee has question, especially in the part where he wrote "I'd like to get Mark Brown's opinion on this.". I added the code extract in [1] to spare you going through the a

Re: [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec

2016-11-21 Thread Lee Jones
Mark, please see below: On Sat, 19 Nov 2016, Robert Jarzmik wrote: > Lee Jones writes: > > >> +#define WM9705_VENDOR_ID 0x574d4c05 > >> +#define WM9712_VENDOR_ID 0x574d4c12 > >> +#define WM9713_VENDOR_ID 0x574d4c13 > >> +#define WM97xx_VENDOR_ID_MASK 0x > > > > These are probably better

Re: [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec

2016-11-19 Thread Robert Jarzmik
Lee Jones writes: > On Wed, 26 Oct 2016, Robert Jarzmik wrote: >> +config MFD_WM97xx >> +tristate "Wolfson Microelectronics WM97xx" >> +select MFD_CORE >> +select REGMAP_AC97 >> +select AC97_BUS_COMPAT if AC97_BUS_NEW >> +help >> + > > Surplus '\n' here. Right, for v2. >> +

Re: [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec

2016-11-18 Thread Lee Jones
On Wed, 26 Oct 2016, Robert Jarzmik wrote: > The WM9705, WM9712 and WM9713 are highly integrated codecs, with an > audio codec, DAC and ADC, GPIO unit and a touchscreen interface. > > Historically the support was spread across drivers/input/touchscreen and > sound/soc/codecs. The sharing was done

Re: [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec

2016-10-27 Thread Charles Keepax
On Wed, Oct 26, 2016 at 09:41:46PM +0200, Robert Jarzmik wrote: > The WM9705, WM9712 and WM9713 are highly integrated codecs, with an > audio codec, DAC and ADC, GPIO unit and a touchscreen interface. > > Historically the support was spread across drivers/input/touchscreen and > sound/soc/codecs.

[PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec

2016-10-26 Thread Robert Jarzmik
The WM9705, WM9712 and WM9713 are highly integrated codecs, with an audio codec, DAC and ADC, GPIO unit and a touchscreen interface. Historically the support was spread across drivers/input/touchscreen and sound/soc/codecs. The sharing was done through ac97 bus sharing. This model will not withsta