Re: [PATCH 8/9] staging: dgap: cleanup dgap_firmware_load() function

2014-06-13 Thread Dan Carpenter
On Fri, Jun 13, 2014 at 04:43:37PM +0900, Daeseok Youn wrote: > @@ -583,8 +585,51 @@ static int dgap_init_one(struct pci_dev *pdev, const > struct pci_device_id *ent) > if (rc) > return rc; > > - dgap_numboards++; > - return dgap_firmware_load(pdev,

[PATCH 8/9] staging: dgap: cleanup dgap_firmware_load() function

2014-06-13 Thread Daeseok Youn
The dgap_firmware_load() has a lot of stuff beside loding firmware. So some registering and initializing for device are moved into dgap_init_one(). And also adds unwinding on error in dgap_init_one(). Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 81

[PATCH 8/9] staging: dgap: cleanup dgap_firmware_load() function

2014-06-13 Thread Daeseok Youn
The dgap_firmware_load() has a lot of stuff beside loding firmware. So some registering and initializing for device are moved into dgap_init_one(). And also adds unwinding on error in dgap_init_one(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 81

Re: [PATCH 8/9] staging: dgap: cleanup dgap_firmware_load() function

2014-06-13 Thread Dan Carpenter
On Fri, Jun 13, 2014 at 04:43:37PM +0900, Daeseok Youn wrote: @@ -583,8 +585,51 @@ static int dgap_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) if (rc) return rc; - dgap_numboards++; - return dgap_firmware_load(pdev, ent-driver_data); +