Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-16 Thread Michal Hocko
On Fri 16-11-18 14:19:10, Sasha Levin wrote: > On Fri, Nov 16, 2018 at 07:44:57PM +0100, Michal Hocko wrote: > > On Fri 16-11-18 13:19:04, Sasha Levin wrote: > > > On Fri, Nov 16, 2018 at 09:55:25AM +0100, Michal Hocko wrote: > > [...] > > > > > Race condition with memory hotplug due to missing

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-16 Thread Michal Hocko
On Fri 16-11-18 14:19:10, Sasha Levin wrote: > On Fri, Nov 16, 2018 at 07:44:57PM +0100, Michal Hocko wrote: > > On Fri 16-11-18 13:19:04, Sasha Levin wrote: > > > On Fri, Nov 16, 2018 at 09:55:25AM +0100, Michal Hocko wrote: > > [...] > > > > > Race condition with memory hotplug due to missing

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-16 Thread Sasha Levin
On Fri, Nov 16, 2018 at 07:44:57PM +0100, Michal Hocko wrote: On Fri 16-11-18 13:19:04, Sasha Levin wrote: On Fri, Nov 16, 2018 at 09:55:25AM +0100, Michal Hocko wrote: [...] > > Race condition with memory hotplug due to missing locks: > > > >

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-16 Thread Sasha Levin
On Fri, Nov 16, 2018 at 07:44:57PM +0100, Michal Hocko wrote: On Fri 16-11-18 13:19:04, Sasha Levin wrote: On Fri, Nov 16, 2018 at 09:55:25AM +0100, Michal Hocko wrote: [...] > > Race condition with memory hotplug due to missing locks: > > > >

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-16 Thread Michal Hocko
On Fri 16-11-18 13:19:04, Sasha Levin wrote: > On Fri, Nov 16, 2018 at 09:55:25AM +0100, Michal Hocko wrote: [...] > > > Race condition with memory hotplug due to missing locks: > > > > > > https://marc.info/?l=linux-mm=154211934011188=2 > > > > Memory hotplug locking is dubious at best and

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-16 Thread Michal Hocko
On Fri 16-11-18 13:19:04, Sasha Levin wrote: > On Fri, Nov 16, 2018 at 09:55:25AM +0100, Michal Hocko wrote: [...] > > > Race condition with memory hotplug due to missing locks: > > > > > > https://marc.info/?l=linux-mm=154211934011188=2 > > > > Memory hotplug locking is dubious at best and

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-16 Thread Sasha Levin
On Fri, Nov 16, 2018 at 09:55:25AM +0100, Michal Hocko wrote: On Thu 15-11-18 18:01:18, Sasha Levin wrote: On Thu, Nov 15, 2018 at 02:47:19PM -0800, Andrew Morton wrote: > On Thu, 15 Nov 2018 17:37:18 -0500 Sasha Levin wrote: > > > On Thu, Nov 15, 2018 at 02:08:10PM -0800, Andrew Morton wrote:

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-16 Thread Sasha Levin
On Fri, Nov 16, 2018 at 09:55:25AM +0100, Michal Hocko wrote: On Thu 15-11-18 18:01:18, Sasha Levin wrote: On Thu, Nov 15, 2018 at 02:47:19PM -0800, Andrew Morton wrote: > On Thu, 15 Nov 2018 17:37:18 -0500 Sasha Levin wrote: > > > On Thu, Nov 15, 2018 at 02:08:10PM -0800, Andrew Morton wrote:

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-16 Thread Michal Hocko
On Thu 15-11-18 18:01:18, Sasha Levin wrote: > On Thu, Nov 15, 2018 at 02:47:19PM -0800, Andrew Morton wrote: > > On Thu, 15 Nov 2018 17:37:18 -0500 Sasha Levin wrote: > > > > > On Thu, Nov 15, 2018 at 02:08:10PM -0800, Andrew Morton wrote: > > > >On Tue, 13 Nov 2018 00:52:51 -0500 Sasha Levin

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-16 Thread Michal Hocko
On Thu 15-11-18 18:01:18, Sasha Levin wrote: > On Thu, Nov 15, 2018 at 02:47:19PM -0800, Andrew Morton wrote: > > On Thu, 15 Nov 2018 17:37:18 -0500 Sasha Levin wrote: > > > > > On Thu, Nov 15, 2018 at 02:08:10PM -0800, Andrew Morton wrote: > > > >On Tue, 13 Nov 2018 00:52:51 -0500 Sasha Levin

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-15 Thread Sasha Levin
On Thu, Nov 15, 2018 at 02:47:19PM -0800, Andrew Morton wrote: On Thu, 15 Nov 2018 17:37:18 -0500 Sasha Levin wrote: On Thu, Nov 15, 2018 at 02:08:10PM -0800, Andrew Morton wrote: >On Tue, 13 Nov 2018 00:52:51 -0500 Sasha Levin wrote: > >> From: Jann Horn >> >> [ Upstream commit

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-15 Thread Sasha Levin
On Thu, Nov 15, 2018 at 02:47:19PM -0800, Andrew Morton wrote: On Thu, 15 Nov 2018 17:37:18 -0500 Sasha Levin wrote: On Thu, Nov 15, 2018 at 02:08:10PM -0800, Andrew Morton wrote: >On Tue, 13 Nov 2018 00:52:51 -0500 Sasha Levin wrote: > >> From: Jann Horn >> >> [ Upstream commit

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-15 Thread Andrew Morton
On Thu, 15 Nov 2018 17:37:18 -0500 Sasha Levin wrote: > On Thu, Nov 15, 2018 at 02:08:10PM -0800, Andrew Morton wrote: > >On Tue, 13 Nov 2018 00:52:51 -0500 Sasha Levin wrote: > > > >> From: Jann Horn > >> > >> [ Upstream commit f0ecf25a093fc0589f0a6bc4c1ea068bbb67d220 ] > >> > >> Having two

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-15 Thread Andrew Morton
On Thu, 15 Nov 2018 17:37:18 -0500 Sasha Levin wrote: > On Thu, Nov 15, 2018 at 02:08:10PM -0800, Andrew Morton wrote: > >On Tue, 13 Nov 2018 00:52:51 -0500 Sasha Levin wrote: > > > >> From: Jann Horn > >> > >> [ Upstream commit f0ecf25a093fc0589f0a6bc4c1ea068bbb67d220 ] > >> > >> Having two

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-15 Thread Sasha Levin
On Thu, Nov 15, 2018 at 02:08:10PM -0800, Andrew Morton wrote: On Tue, 13 Nov 2018 00:52:51 -0500 Sasha Levin wrote: From: Jann Horn [ Upstream commit f0ecf25a093fc0589f0a6bc4c1ea068bbb67d220 ] Having two gigantic arrays that must manually be kept in sync, including ifdefs, isn't exactly

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-15 Thread Sasha Levin
On Thu, Nov 15, 2018 at 02:08:10PM -0800, Andrew Morton wrote: On Tue, 13 Nov 2018 00:52:51 -0500 Sasha Levin wrote: From: Jann Horn [ Upstream commit f0ecf25a093fc0589f0a6bc4c1ea068bbb67d220 ] Having two gigantic arrays that must manually be kept in sync, including ifdefs, isn't exactly

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-15 Thread Andrew Morton
On Tue, 13 Nov 2018 00:52:51 -0500 Sasha Levin wrote: > From: Jann Horn > > [ Upstream commit f0ecf25a093fc0589f0a6bc4c1ea068bbb67d220 ] > > Having two gigantic arrays that must manually be kept in sync, including > ifdefs, isn't exactly robust. To make it easier to catch such issues in >

Re: [PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-15 Thread Andrew Morton
On Tue, 13 Nov 2018 00:52:51 -0500 Sasha Levin wrote: > From: Jann Horn > > [ Upstream commit f0ecf25a093fc0589f0a6bc4c1ea068bbb67d220 ] > > Having two gigantic arrays that must manually be kept in sync, including > ifdefs, isn't exactly robust. To make it easier to catch such issues in >

[PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-12 Thread Sasha Levin
From: Jann Horn [ Upstream commit f0ecf25a093fc0589f0a6bc4c1ea068bbb67d220 ] Having two gigantic arrays that must manually be kept in sync, including ifdefs, isn't exactly robust. To make it easier to catch such issues in the future, add a BUILD_BUG_ON(). Link:

[PATCH AUTOSEL 3.18 8/9] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size

2018-11-12 Thread Sasha Levin
From: Jann Horn [ Upstream commit f0ecf25a093fc0589f0a6bc4c1ea068bbb67d220 ] Having two gigantic arrays that must manually be kept in sync, including ifdefs, isn't exactly robust. To make it easier to catch such issues in the future, add a BUILD_BUG_ON(). Link: