From: Christoph Hellwig <h...@lst.de>

[ Upstream commit 428805c0c5e76ef643b1fbc893edfb636b3d8aef ]

get_gendisk grabs a reference on the disk and file operation, so this
code will leak both of them while having absolutely no use for the
gendisk itself.

This effectively reverts commit 2df83fa4bce421f ("PM / Hibernate: Use
get_gendisk to verify partition if resume_file is integer format")

Signed-off-by: Christoph Hellwig <h...@lst.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 kernel/power/hibernate.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
index 3124cebaec31e..7d73b30c55ccd 100644
--- a/kernel/power/hibernate.c
+++ b/kernel/power/hibernate.c
@@ -779,17 +779,6 @@ static int software_resume(void)
 
        /* Check if the device is there */
        swsusp_resume_device = name_to_dev_t(resume_file);
-
-       /*
-        * name_to_dev_t is ineffective to verify parition if resume_file is in
-        * integer format. (e.g. major:minor)
-        */
-       if (isdigit(resume_file[0]) && resume_wait) {
-               int partno;
-               while (!get_gendisk(swsusp_resume_device, &partno))
-                       msleep(10);
-       }
-
        if (!swsusp_resume_device) {
                /*
                 * Some device discovery might still be in progress; we need
-- 
2.25.1

Reply via email to