Re: [PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback

2017-06-22 Thread Andrew Lunn
> what should the Mac driver do when it receive the error? I assume that it > will return it to userspace. because the rtnl_lock ensure only one ethtool > is executing, if the function return error, it means some bug in the mac > driver, am I right? Yes, return it. It could be there are other use

Re: [PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback

2017-06-22 Thread Andrew Lunn
> what should the Mac driver do when it receive the error? I assume that it > will return it to userspace. because the rtnl_lock ensure only one ethtool > is executing, if the function return error, it means some bug in the mac > driver, am I right? Yes, return it. It could be there are other use

Re: [PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback

2017-06-22 Thread Yunsheng Lin
hi, Andrew On 2017/6/23 11:20, Andrew Lunn wrote: > On Thu, Jun 22, 2017 at 04:53:33PM +0800, Lin Yun Sheng wrote: >> Use function set_loopback in phy_driver to setup phy loopback >> when doing ethtool self test. >> >> Signed-off-by: Lin Yun Sheng >> --- >>

Re: [PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback

2017-06-22 Thread Yunsheng Lin
hi, Andrew On 2017/6/23 11:20, Andrew Lunn wrote: > On Thu, Jun 22, 2017 at 04:53:33PM +0800, Lin Yun Sheng wrote: >> Use function set_loopback in phy_driver to setup phy loopback >> when doing ethtool self test. >> >> Signed-off-by: Lin Yun Sheng >> --- >>

Re: [PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback

2017-06-22 Thread Andrew Lunn
On Thu, Jun 22, 2017 at 04:53:33PM +0800, Lin Yun Sheng wrote: > Use function set_loopback in phy_driver to setup phy loopback > when doing ethtool self test. > > Signed-off-by: Lin Yun Sheng > --- > drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 64 >

Re: [PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback

2017-06-22 Thread Andrew Lunn
On Thu, Jun 22, 2017 at 04:53:33PM +0800, Lin Yun Sheng wrote: > Use function set_loopback in phy_driver to setup phy loopback > when doing ethtool self test. > > Signed-off-by: Lin Yun Sheng > --- > drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 64 > > 1 file

[PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback

2017-06-22 Thread Lin Yun Sheng
Use function set_loopback in phy_driver to setup phy loopback when doing ethtool self test. Signed-off-by: Lin Yun Sheng --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 64 1 file changed, 10 insertions(+), 54 deletions(-) diff --git

[PATCH NET 2/2] net: hns: Use phy_driver to setup Phy loopback

2017-06-22 Thread Lin Yun Sheng
Use function set_loopback in phy_driver to setup phy loopback when doing ethtool self test. Signed-off-by: Lin Yun Sheng --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 64 1 file changed, 10 insertions(+), 54 deletions(-) diff --git