RE: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

> On 07/15/2016 07:25 AM, Stanislaw Gruszka wrote: > > On Thu, Jul 14, 2016 at 09:44:22AM +, Grumbach, Emmanuel wrote: > >>> If I understad correctly this error happen 100% of the time, not > >>> only during init. Hence seems there is an issue here, i.e. cur_ucode > >>> is not marked correctly

RE: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

> On 07/15/2016 07:25 AM, Stanislaw Gruszka wrote: > > On Thu, Jul 14, 2016 at 09:44:22AM +, Grumbach, Emmanuel wrote: > >>> If I understad correctly this error happen 100% of the time, not > >>> only during init. Hence seems there is an issue here, i.e. cur_ucode > >>> is not marked correctly

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On 07/15/2016 07:25 AM, Stanislaw Gruszka wrote: > On Thu, Jul 14, 2016 at 09:44:22AM +, Grumbach, Emmanuel wrote: >>> If I understad correctly this error happen 100% of the time, not only during >>> init. Hence seems there is an issue here, i.e. cur_ucode is not marked >>> correctly as

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On 07/15/2016 07:25 AM, Stanislaw Gruszka wrote: > On Thu, Jul 14, 2016 at 09:44:22AM +, Grumbach, Emmanuel wrote: >>> If I understad correctly this error happen 100% of the time, not only during >>> init. Hence seems there is an issue here, i.e. cur_ucode is not marked >>> correctly as

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Thu, Jul 14, 2016 at 09:44:22AM +, Grumbach, Emmanuel wrote: > > If I understad correctly this error happen 100% of the time, not only during > > init. Hence seems there is an issue here, i.e. cur_ucode is not marked > > correctly as IWL_UCODE_REGULAR or iwl_mvm_get_temp() fail 100% of the

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Thu, Jul 14, 2016 at 09:44:22AM +, Grumbach, Emmanuel wrote: > > If I understad correctly this error happen 100% of the time, not only during > > init. Hence seems there is an issue here, i.e. cur_ucode is not marked > > correctly as IWL_UCODE_REGULAR or iwl_mvm_get_temp() fail 100% of the

RE: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

> > On Mon, Jul 11, 2016 at 06:27:30PM +, Grumbach, Emmanuel wrote: > > I guess that works, but it seems wrong to me. Usually, registration > > should happen only upon INIT, and yes, at that time the firmware is > > not ready to provide the information yet. > > > > > > > As can be seen in

RE: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

> > On Mon, Jul 11, 2016 at 06:27:30PM +, Grumbach, Emmanuel wrote: > > I guess that works, but it seems wrong to me. Usually, registration > > should happen only upon INIT, and yes, at that time the firmware is > > not ready to provide the information yet. > > > > > > > As can be seen in

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Mon, Jul 11, 2016 at 06:27:30PM +, Grumbach, Emmanuel wrote: > I guess that works, but it seems wrong to me. Usually, registration > should happen only upon INIT, and yes, at that time the firmware is not > ready to provide the information yet. > > > > As can be seen in the current code

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Mon, Jul 11, 2016 at 06:27:30PM +, Grumbach, Emmanuel wrote: > I guess that works, but it seems wrong to me. Usually, registration > should happen only upon INIT, and yes, at that time the firmware is not > ready to provide the information yet. > > > > As can be seen in the current code

RE: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

> > Prarit Bhargava writes: > > > On 07/13/2016 03:24 AM, Luca Coelho wrote: > > > >> I totally agree with Emmanuel and Kalle. We should not change this. > >> It is a design decision to return an error when the interface is > >> down, this is very common with other subsystems

RE: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

> > Prarit Bhargava writes: > > > On 07/13/2016 03:24 AM, Luca Coelho wrote: > > > >> I totally agree with Emmanuel and Kalle. We should not change this. > >> It is a design decision to return an error when the interface is > >> down, this is very common with other subsystems as well. > > > >

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

Prarit Bhargava writes: > On 07/13/2016 03:24 AM, Luca Coelho wrote: > >> I totally agree with Emmanuel and Kalle. We should not change this. >> It is a design decision to return an error when the interface is >> down, this is very common with other subsystems as well. > >

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

Prarit Bhargava writes: > On 07/13/2016 03:24 AM, Luca Coelho wrote: > >> I totally agree with Emmanuel and Kalle. We should not change this. >> It is a design decision to return an error when the interface is >> down, this is very common with other subsystems as well. > > Please show me another

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

Prarit Bhargava writes: > On 07/13/2016 02:50 AM, Kalle Valo wrote: >> Prarit Bhargava writes: >> We implement thermal zone because we do support it, but the problem is that we need the firmware to be loaded for that. So you can argue that

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

Prarit Bhargava writes: > On 07/13/2016 02:50 AM, Kalle Valo wrote: >> Prarit Bhargava writes: >> We implement thermal zone because we do support it, but the problem is that we need the firmware to be loaded for that. So you can argue that we should register *later* when the

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On 07/13/2016 03:24 AM, Luca Coelho wrote: > On Wed, 2016-07-13 at 09:50 +0300, Kalle Valo wrote: >> Prarit Bhargava writes: >> We implement thermal zone because we do support it, but the problem is that we need the firmware to be loaded for that. So you can

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On 07/13/2016 03:24 AM, Luca Coelho wrote: > On Wed, 2016-07-13 at 09:50 +0300, Kalle Valo wrote: >> Prarit Bhargava writes: >> We implement thermal zone because we do support it, but the problem is that we need the firmware to be loaded for that. So you can argue that

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On 07/13/2016 02:50 AM, Kalle Valo wrote: > Prarit Bhargava writes: > >>> We implement thermal zone because we do support it, but the problem is >>> that we need the firmware to be loaded for that. So you can argue that >>> we should register *later* when the firmware is

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On 07/13/2016 02:50 AM, Kalle Valo wrote: > Prarit Bhargava writes: > >>> We implement thermal zone because we do support it, but the problem is >>> that we need the firmware to be loaded for that. So you can argue that >>> we should register *later* when the firmware is loaded. But this is

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Wed, 2016-07-13 at 09:50 +0300, Kalle Valo wrote: > Prarit Bhargava writes: > > > > We implement thermal zone because we do support it, but the > > > problem is > > > that we need the firmware to be loaded for that. So you can argue > > > that > > > we should register

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Wed, 2016-07-13 at 09:50 +0300, Kalle Valo wrote: > Prarit Bhargava writes: > > > > We implement thermal zone because we do support it, but the > > > problem is > > > that we need the firmware to be loaded for that. So you can argue > > > that > > > we should register *later* when the

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

Prarit Bhargava writes: >> We implement thermal zone because we do support it, but the problem is >> that we need the firmware to be loaded for that. So you can argue that >> we should register *later* when the firmware is loaded. But this is >> really not helping all that

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

Prarit Bhargava writes: >> We implement thermal zone because we do support it, but the problem is >> that we need the firmware to be loaded for that. So you can argue that >> we should register *later* when the firmware is loaded. But this is >> really not helping all that much because the

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On 07/11/2016 02:27 PM, Grumbach, Emmanuel wrote: > On Mon, 2016-07-11 at 14:19 -0400, Prarit Bhargava wrote: >> >> On 07/11/2016 02:00 PM, Emmanuel Grumbach wrote: >>> On Mon, Jul 11, 2016 at 6:18 PM, Prarit Bhargava

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On 07/11/2016 02:27 PM, Grumbach, Emmanuel wrote: > On Mon, 2016-07-11 at 14:19 -0400, Prarit Bhargava wrote: >> >> On 07/11/2016 02:00 PM, Emmanuel Grumbach wrote: >>> On Mon, Jul 11, 2016 at 6:18 PM, Prarit Bhargava >>> wrote: Didn't get any feedback or review comments on this patch.

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Mon, 2016-07-11 at 14:19 -0400, Prarit Bhargava wrote: > > On 07/11/2016 02:00 PM, Emmanuel Grumbach wrote: > > On Mon, Jul 11, 2016 at 6:18 PM, Prarit Bhargava > > wrote: > > > > > > Didn't get any feedback or review comments on this patch. > > > Resending ... > > > >

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Mon, 2016-07-11 at 14:19 -0400, Prarit Bhargava wrote: > > On 07/11/2016 02:00 PM, Emmanuel Grumbach wrote: > > On Mon, Jul 11, 2016 at 6:18 PM, Prarit Bhargava > > wrote: > > > > > > Didn't get any feedback or review comments on this patch. > > > Resending ... > > > > > > P. > > > >

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On 07/11/2016 02:00 PM, Emmanuel Grumbach wrote: > On Mon, Jul 11, 2016 at 6:18 PM, Prarit Bhargava wrote: >> >> Didn't get any feedback or review comments on this patch. Resending ... >> >> P. > > This change is obviously completely broken. It simply disables the >

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On 07/11/2016 02:00 PM, Emmanuel Grumbach wrote: > On Mon, Jul 11, 2016 at 6:18 PM, Prarit Bhargava wrote: >> >> Didn't get any feedback or review comments on this patch. Resending ... >> >> P. > > This change is obviously completely broken. It simply disables the > registration to thermal

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Mon, Jul 11, 2016 at 6:18 PM, Prarit Bhargava wrote: > > Didn't get any feedback or review comments on this patch. Resending ... > > P. This change is obviously completely broken. It simply disables the registration to thermal zone core. > > ---8<--- > > The iwlwifi

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Mon, Jul 11, 2016 at 6:18 PM, Prarit Bhargava wrote: > > Didn't get any feedback or review comments on this patch. Resending ... > > P. This change is obviously completely broken. It simply disables the registration to thermal zone core. > > ---8<--- > > The iwlwifi driver implements a

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On 07/11/2016 12:07 PM, Coelho, Luciano wrote: > On Mon, 2016-07-11 at 11:18 -0400, Prarit Bhargava wrote: >> Didn't get any feedback or review comments on this patch. Resending >> ... >> >> P. > > Sorry, this got flooded down my inbox. NP, Luciano -- My worry was that it hadn't been seen or

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On 07/11/2016 12:07 PM, Coelho, Luciano wrote: > On Mon, 2016-07-11 at 11:18 -0400, Prarit Bhargava wrote: >> Didn't get any feedback or review comments on this patch. Resending >> ... >> >> P. > > Sorry, this got flooded down my inbox. NP, Luciano -- My worry was that it hadn't been seen or

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Mon, 2016-07-11 at 11:18 -0400, Prarit Bhargava wrote: > Didn't get any feedback or review comments on this patch.  Resending > ... > > P. Sorry, this got flooded down my inbox. > ---8<--- > > The iwlwifi driver implements a thermal zone and hwmon device, but > returns -EIO on temperature

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

On Mon, 2016-07-11 at 11:18 -0400, Prarit Bhargava wrote: > Didn't get any feedback or review comments on this patch.  Resending > ... > > P. Sorry, this got flooded down my inbox. > ---8<--- > > The iwlwifi driver implements a thermal zone and hwmon device, but > returns -EIO on temperature

[PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

Didn't get any feedback or review comments on this patch. Resending ... P. ---8<--- The iwlwifi driver implements a thermal zone and hwmon device, but returns -EIO on temperature reads if the firmware isn't loaded. This results in the error iwlwifi-virtual-0 Adapter: Virtual device ERROR:

[PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

Didn't get any feedback or review comments on this patch. Resending ... P. ---8<--- The iwlwifi driver implements a thermal zone and hwmon device, but returns -EIO on temperature reads if the firmware isn't loaded. This results in the error iwlwifi-virtual-0 Adapter: Virtual device ERROR: