Re: [PATCH RESEND] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

2014-08-11 Thread Mark Einon
On Mon, Aug 11, 2014 at 01:39:59PM +0800, gre...@linuxfoundation.org wrote: > On Mon, Aug 11, 2014 at 12:32:55AM +0300, Anca Emanuel wrote: > > Do you have this hardware ? And did you test this ? > > Mark is the maintainer of this driver, I assume he has the hardware, if > not, I don't care, I

Re: [PATCH RESEND] staging: et131x: Fix errors caused by phydev-addr accesses before initialisation

2014-08-11 Thread Mark Einon
On Mon, Aug 11, 2014 at 01:39:59PM +0800, gre...@linuxfoundation.org wrote: On Mon, Aug 11, 2014 at 12:32:55AM +0300, Anca Emanuel wrote: Do you have this hardware ? And did you test this ? Mark is the maintainer of this driver, I assume he has the hardware, if not, I don't care, I trust

Re: [PATCH RESEND] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

2014-08-10 Thread gre...@linuxfoundation.org
On Mon, Aug 11, 2014 at 12:32:55AM +0300, Anca Emanuel wrote: > Do you have this hardware ? And did you test this ? Mark is the maintainer of this driver, I assume he has the hardware, if not, I don't care, I trust him :) > How can you cc stable without an Tested by somebody else ? Since when

Re: [PATCH RESEND] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

2014-08-10 Thread Anca Emanuel
Do you have this hardware ? And did you test this ? How can you cc stable without an Tested by somebody else ? On Mon, Aug 11, 2014 at 12:16 AM, Mark Einon wrote: > Fix two reported bugs, caused by et131x_adapter->phydev->addr being accessed > before it is initialised, by: > > - letting

[PATCH RESEND] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

2014-08-10 Thread Mark Einon
Fix two reported bugs, caused by et131x_adapter->phydev->addr being accessed before it is initialised, by: - letting et131x_mii_write() take a phydev address, instead of using the one stored in adapter by default. This is so et131x_mdio_write() can use it's own addr value. - removing

[PATCH RESEND] staging: et131x: Fix errors caused by phydev-addr accesses before initialisation

2014-08-10 Thread Mark Einon
Fix two reported bugs, caused by et131x_adapter-phydev-addr being accessed before it is initialised, by: - letting et131x_mii_write() take a phydev address, instead of using the one stored in adapter by default. This is so et131x_mdio_write() can use it's own addr value. - removing

Re: [PATCH RESEND] staging: et131x: Fix errors caused by phydev-addr accesses before initialisation

2014-08-10 Thread Anca Emanuel
Do you have this hardware ? And did you test this ? How can you cc stable without an Tested by somebody else ? On Mon, Aug 11, 2014 at 12:16 AM, Mark Einon mark.ei...@gmail.com wrote: Fix two reported bugs, caused by et131x_adapter-phydev-addr being accessed before it is initialised, by: -

Re: [PATCH RESEND] staging: et131x: Fix errors caused by phydev-addr accesses before initialisation

2014-08-10 Thread gre...@linuxfoundation.org
On Mon, Aug 11, 2014 at 12:32:55AM +0300, Anca Emanuel wrote: Do you have this hardware ? And did you test this ? Mark is the maintainer of this driver, I assume he has the hardware, if not, I don't care, I trust him :) How can you cc stable without an Tested by somebody else ? Since when is