Re: [PATCH RESEND 1/2] watchdog: mtx1-wdt: use devm_gpio_request_one()

2013-05-26 Thread Wim Van Sebroeck
Hi Jingoo, > Use devm_gpio_request_one() to make cleanup paths simpler. > > Signed-off-by: Jingoo Han > --- > drivers/watchdog/mtx-1_wdt.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > Patch added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this

Re: [PATCH RESEND 1/2] watchdog: mtx1-wdt: use devm_gpio_request_one()

2013-05-26 Thread Wim Van Sebroeck
Hi Jingoo, Use devm_gpio_request_one() to make cleanup paths simpler. Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/watchdog/mtx-1_wdt.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) Patch added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe

Re: [PATCH RESEND 1/2] watchdog: mtx1-wdt: use devm_gpio_request_one()

2013-04-29 Thread Guenter Roeck
On Tue, Apr 30, 2013 at 10:54:03AM +0900, Jingoo Han wrote: > On Tuesday, April 30, 2013 1:44 AM, Guenter Roeck wrote: > > On Mon, Apr 29, 2013 at 06:30:43PM +0900, Jingoo Han wrote: > > > Use devm_gpio_request_one() to make cleanup paths simpler. > > > > > > Signed-off-by: Jingoo Han > > > >

Re: [PATCH RESEND 1/2] watchdog: mtx1-wdt: use devm_gpio_request_one()

2013-04-29 Thread Jingoo Han
On Tuesday, April 30, 2013 1:44 AM, Guenter Roeck wrote: > On Mon, Apr 29, 2013 at 06:30:43PM +0900, Jingoo Han wrote: > > Use devm_gpio_request_one() to make cleanup paths simpler. > > > > Signed-off-by: Jingoo Han > > This patch also addresses the missing gpio_free in the probe error path >

Re: [PATCH RESEND 1/2] watchdog: mtx1-wdt: use devm_gpio_request_one()

2013-04-29 Thread Guenter Roeck
On Mon, Apr 29, 2013 at 06:30:43PM +0900, Jingoo Han wrote: > Use devm_gpio_request_one() to make cleanup paths simpler. > > Signed-off-by: Jingoo Han This patch also addresses the missing gpio_free in the probe error path (if the call to misc_register() fails). Reviewed-by: Guenter Roeck >

[PATCH RESEND 1/2] watchdog: mtx1-wdt: use devm_gpio_request_one()

2013-04-29 Thread Jingoo Han
Use devm_gpio_request_one() to make cleanup paths simpler. Signed-off-by: Jingoo Han --- drivers/watchdog/mtx-1_wdt.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c index 14dab6f..b434111 100644 ---

[PATCH RESEND 1/2] watchdog: mtx1-wdt: use devm_gpio_request_one()

2013-04-29 Thread Jingoo Han
Use devm_gpio_request_one() to make cleanup paths simpler. Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/watchdog/mtx-1_wdt.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c index 14dab6f..b434111

Re: [PATCH RESEND 1/2] watchdog: mtx1-wdt: use devm_gpio_request_one()

2013-04-29 Thread Guenter Roeck
On Mon, Apr 29, 2013 at 06:30:43PM +0900, Jingoo Han wrote: Use devm_gpio_request_one() to make cleanup paths simpler. Signed-off-by: Jingoo Han jg1@samsung.com This patch also addresses the missing gpio_free in the probe error path (if the call to misc_register() fails). Reviewed-by:

Re: [PATCH RESEND 1/2] watchdog: mtx1-wdt: use devm_gpio_request_one()

2013-04-29 Thread Jingoo Han
On Tuesday, April 30, 2013 1:44 AM, Guenter Roeck wrote: On Mon, Apr 29, 2013 at 06:30:43PM +0900, Jingoo Han wrote: Use devm_gpio_request_one() to make cleanup paths simpler. Signed-off-by: Jingoo Han jg1@samsung.com This patch also addresses the missing gpio_free in the probe error

Re: [PATCH RESEND 1/2] watchdog: mtx1-wdt: use devm_gpio_request_one()

2013-04-29 Thread Guenter Roeck
On Tue, Apr 30, 2013 at 10:54:03AM +0900, Jingoo Han wrote: On Tuesday, April 30, 2013 1:44 AM, Guenter Roeck wrote: On Mon, Apr 29, 2013 at 06:30:43PM +0900, Jingoo Han wrote: Use devm_gpio_request_one() to make cleanup paths simpler. Signed-off-by: Jingoo Han jg1@samsung.com